Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <cover.1578235515.git.gupt21@gmail.com> <7d7c949890c4bdb12ecc9f8b15a5c0a69b7604a8.1578235515.git.gupt21@gmail.com>
 <20200106192912.GB754821@kroah.com>
In-Reply-To: <20200106192912.GB754821@kroah.com>
From:   rishi gupta <gupt21@gmail.com>
Date:   Thu, 9 Jan 2020 14:52:52 +0530
Message-ID: <CALUj-gt6FGJEMqfsbfZUCeY3Jmz5B-xwEY9+yPUPXP9YusuOaA@mail.gmail.com>
Subject: Re: [PATCH v1 3/3] tty: documentation: abi: add ttyvs null modem
 driver sysfs nodes
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     robh+dt@kernel.org, jslaby@suse.com, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Oh sorry, I will update this.

On Tue, Jan 7, 2020 at 12:59 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Mon, Jan 06, 2020 at 12:51:55PM +0530, Rishi Gupta wrote:
> > The ttyvs driver exposes sysfs files to emulate various serial
> > port events. This commit document these files.
> >
> > Signed-off-by: Rishi Gupta <gupt21@gmail.com>
> > ---
> >  .../ABI/testing/sysfs-devices-virtual-tty_ttyvs        | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >  create mode 100644 Documentation/ABI/testing/sysfs-devices-virtual-tty_ttyvs
> >
> > diff --git a/Documentation/ABI/testing/sysfs-devices-virtual-tty_ttyvs b/Documentation/ABI/testing/sysfs-devices-virtual-tty_ttyvs
> > new file mode 100644
> > index 0000000..69b04e0
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-devices-virtual-tty_ttyvs
> > @@ -0,0 +1,18 @@
> > +What:                /sys/devices/virtual/tty/ttyvsN/event
> > +Date:                January 2020
> > +Contact:     Rishi Gupta <gupt21@gmail.com>
> > +KernelVersion:       5.5
> > +Description:
> > +             The ttyvs driver will emulate serial port event; parity error,
> > +             framing error, overrun error, asserting or de-asserting break
> > +             conditions and ring indication when user space application
> > +             writes an event code on this sysfs file.
>
> You did not actually document any of the values read/written to this
> file, like you did in your 0/X patch description :(
>
> greg k-h