Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Abel Vesa <abel.vesa@nxp.com>
To:     Peng Fan <peng.fan@nxp.com>
CC:     "sboyd@kernel.org" <sboyd@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        Leonard Crestez <leonard.crestez@nxp.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Anson Huang <anson.huang@nxp.com>, Jacky Bai <ping.bai@nxp.com>
Subject: Re: [PATCH 0/4] clk: imx: imx8m: introduce
 imx8m_clk_hw_core_composite
Thread-Topic: [PATCH 0/4] clk: imx: imx8m: introduce
 imx8m_clk_hw_core_composite
Thread-Index: AQHVxtJpermqa5NGzEysq2aeSusjm6fiKRmA
Date:   Thu, 9 Jan 2020 10:55:58 +0000
Message-ID: <20200109105557.gntbgzj3efbqpjwf@fsr-ub1664-175>
References: <1578563269-32710-1-git-send-email-peng.fan@nxp.com>
In-Reply-To: <1578563269-32710-1-git-send-email-peng.fan@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 34a17818-7e82-4fd4-3f15-08d794f2825f
x-ms-traffictypediagnostic: AM0PR04MB6324:|AM0PR04MB6324:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM0PR04MB6324FF8E8061A92F1A19B9EAF6390@AM0PR04MB6324.eurprd04.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-forefront-prvs: 02778BF158
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(7916004)(376002)(39860400002)(366004)(136003)(346002)(396003)(189003)(199004)(6486002)(66476007)(66446008)(956004)(66556008)(5660300002)(66946007)(6496006)(81166006)(64756008)(53546011)(9686003)(478600001)(6862004)(4326008)(86362001)(8676002)(2906002)(186003)(16526019)(316002)(26005)(81156014)(44832011)(71200400001)(1076003)(8936002)(6636002)(33716001)(52116002)(54906003)(32563001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB6324;H:AM0PR04MB5779.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 36Hp7ZAkqORd9O5wSMZdQ7gojPvhAqgGRRyQr/uHSkUsUX1+wxqVNyPaVgrO/Dco9j/rOf1YyBZQCxMyzqTsrOy+KNZbEw17eNN2UXUHImFlShtEvrokiEna3CGFKf/UfCWwlK0TC36RuZf9rbQiPV6IjqKqP/RwaaGPLiNB2tQtijNJg0BClRBl4NznUciwyz/K79J1jRRpOMRv3Mj79bRn64DDO9v+jSK4fdIecO+iYrOyivXQq4k+t6XiFiLBakF2H1wRKkIY/WJ+BuyGa/0z2j6uBVaIxECmBreLTIIyirwo9WTJt5mClvKlWs7hjce8xooBLCwuH9DW3GyR5QL+tuKVtusCoKcHWC0ZFKxPbAa6/Bm+kfMDyOy9ZRF/ACN2X0NC29U+iZ6QQC/E5N/GRQUmN76zrpzmoeML4HsiPr/VEdEjhy5/b3Ewv7NNW1ry72yi6/0XAurUY0wIcfQp53oHx8puYYYouOl+mRGc9wGv2vdQYvn1IKBTmD6c
Content-Type: text/plain; charset="us-ascii"
Content-ID: <205F1779450AE149A9D3ED27732F1C2A@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34a17818-7e82-4fd4-3f15-08d794f2825f
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2020 10:55:58.8400
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XK9fcP4xxo3+CmZHwNgquuA8ByzqBMP6D4sqqbqBdcOlDa5CYC3Lk3AJqQIE486PBiRIiWVoCPxJYKbjgeNs+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6324
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-01-09 09:51:49, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>=20
> To i.MX8M family, there are different types of clock slices,
> bus/core/ip and etc. Currently, the imx8m_clk_hw_composite
> api could only handle bus and ip clock slice, it could
> not handle core slice. The difference is core slice not have
> pre divider and the width of post divider is 3 bits.
>=20
> To simplify code and reuse imx8m_clk_hw_composite, introduce a
> flag IMX_COMPOSITE_CORE to differentiate the slices.
>=20
> With this new helper, we could simplify i.MX8M SoC clk drivers.
>=20

I like the simplification this patchset adds, but maybe we should
keep the extra flags (or clock types) at the end of the API, so=20
instead of imx8m_clk_hw_core_composite maybe we could use=20
imx8m_clk_hw_composite_core.

Other than that:

Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

> Peng Fan (4):
>   clk: imx: composite-8m: add imx8m_clk_hw_core_composite
>   clk: imx: imx8mq: use imx8m_clk_hw_core_composite
>   clk: imx: imx8mm: use imx8m_clk_hw_core_composite
>   clk: imx: imx8mn: use imx8m_clk_hw_core_composite
>=20
>  drivers/clk/imx/clk-composite-8m.c | 18 ++++++++++++++----
>  drivers/clk/imx/clk-imx8mm.c       | 17 +++++------------
>  drivers/clk/imx/clk-imx8mn.c       | 10 +++-------
>  drivers/clk/imx/clk-imx8mq.c       | 19 +++++--------------
>  drivers/clk/imx/clk.h              | 12 ++++++++++--
>  5 files changed, 37 insertions(+), 39 deletions(-)
>=20
> --=20
> 2.16.4
>=20