Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2023865ybl; Thu, 9 Jan 2020 05:42:15 -0800 (PST) X-Google-Smtp-Source: APXvYqzbslrRzMgZW9kCgPISe2CS7UqdCbOqokMLLRFmVU5j2tJuDxhZqhC9/jrxCMpxE2ntFNKg X-Received: by 2002:a9d:7501:: with SMTP id r1mr8830025otk.196.1578577335718; Thu, 09 Jan 2020 05:42:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578577335; cv=none; d=google.com; s=arc-20160816; b=Mp8HIZNz4D/qSIylmIg09GZoC9N4NR2zW+cCKklerNsucJUdA2+azjiekKoqldgi2d bOOPW7+RYJbTP4j1+Ee9wSDYB/5Tqhx0ERP56uOG5VmU1uAErHKFkNWbAVTOIMrAAXKV da/+h09Q0WsZaiLFPdH2wPlHGyw8zUjR/misW5wN1bMzwfWeycLNsn9e61XxBi9SbWyS GlLQM3SxVzTj7QUq/SNZym5FgYyTRH1Wy6A+XXUY2T6+z7QJKfD4NQWaLeG8CxxtePXH ns/LWJuPSxGnaXSie+7k4X4FO6WpaqDcvHRuotry7xlPCWKcv/lqEh4cuy+LmIfGpBCf ueWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=d4GM5QdaZGQJWLerzDP1FFROat4IX9J6HLbQqWuOYa8=; b=DyI3supB90OPbcFkPx+tq1KqT8aiU5Moe0AaC/WUiSakuNR3esVQdfLvkM5U5kZmnd T6mSwlUDzSz0yZglptrrwONfQtCCSl1p0JXhPZuyErZ8Vk3ySWx1M56wf+FxDoTLLBse LxP7i6TaqJp5E0sP7F3ALGL2II0RrI9dfU67qNLbDxf2t7zB3XhBC8rchraT2vQS62XV b3XSqyRlRgRcG49MSsxYZxxzcSx7lmvfNjqC1G8HQlkTAYPJLhtJ9GZdkNx04NOgh3kW DbhBZintFejCovbegOwCTphXVOCqEG0HMe2eZIH+WAoouQ8LT4jCg0HpLm1BglGKgtbR dpWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m90si4139312otc.259.2020.01.09.05.42.03; Thu, 09 Jan 2020 05:42:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731149AbgAINbL (ORCPT + 99 others); Thu, 9 Jan 2020 08:31:11 -0500 Received: from foss.arm.com ([217.140.110.172]:59102 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729114AbgAINbK (ORCPT ); Thu, 9 Jan 2020 08:31:10 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 77B9431B; Thu, 9 Jan 2020 05:31:10 -0800 (PST) Received: from e112269-lin.cambridge.arm.com (e112269-lin.cambridge.arm.com [10.1.194.52]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 432493F534; Thu, 9 Jan 2020 05:31:09 -0800 (PST) From: Steven Price To: Daniel Vetter , David Airlie , Rob Herring , Tomeu Vizoso Cc: Alyssa Rosenzweig , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Robin Murphy , Steven Price Subject: [PATCH] drm/panfrost: Remove core stack power management Date: Thu, 9 Jan 2020 13:31:04 +0000 Message-Id: <20200109133104.11661-1-steven.price@arm.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Explict management of the GPU's core stacks is only necessary in the case of a broken integration with the PDC. Since there are no known platforms which have such a broken integration let's remove the explict control from the driver since this apparently causes problems on other platforms and will have a small performance penality. The out of tree mali_kbase driver contains this text regarding controlling the core stack (CONFIGMALI_CORESTACK): Enabling this feature on supported GPUs will let the driver powering on/off the GPU core stack independently without involving the Power Domain Controller. This should only be enabled on platforms which integration of the PDC to the Mali GPU is known to be problematic. This feature is currently only supported on t-Six and t-HEx GPUs. If unsure, say N. Signed-off-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_gpu.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c index 8822ec13a0d6..460fc190de6e 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c @@ -309,10 +309,6 @@ void panfrost_gpu_power_on(struct panfrost_device *pfdev) ret = readl_relaxed_poll_timeout(pfdev->iomem + L2_READY_LO, val, val == pfdev->features.l2_present, 100, 1000); - gpu_write(pfdev, STACK_PWRON_LO, pfdev->features.stack_present); - ret |= readl_relaxed_poll_timeout(pfdev->iomem + STACK_READY_LO, - val, val == pfdev->features.stack_present, 100, 1000); - gpu_write(pfdev, SHADER_PWRON_LO, pfdev->features.shader_present); ret |= readl_relaxed_poll_timeout(pfdev->iomem + SHADER_READY_LO, val, val == pfdev->features.shader_present, 100, 1000); @@ -329,7 +325,6 @@ void panfrost_gpu_power_off(struct panfrost_device *pfdev) { gpu_write(pfdev, TILER_PWROFF_LO, 0); gpu_write(pfdev, SHADER_PWROFF_LO, 0); - gpu_write(pfdev, STACK_PWROFF_LO, 0); gpu_write(pfdev, L2_PWROFF_LO, 0); } -- 2.20.1