Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2103160ybl; Thu, 9 Jan 2020 07:00:07 -0800 (PST) X-Google-Smtp-Source: APXvYqz2Fx+kff9h21+w+reunJ2XsZ3zWbeWV5e/M66DHj/mxmn47kiS6f4KRV1djBUtv0qMyYry X-Received: by 2002:a05:6830:174e:: with SMTP id 14mr8575744otz.142.1578582007651; Thu, 09 Jan 2020 07:00:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578582007; cv=none; d=google.com; s=arc-20160816; b=aorlC4yJPQ3ZxzIMU5Uodsy0R3hIStbpulytFlbSaSjXr5no3amWhRZfNMSefZEzrJ DydJoQydRZSDlyAttuOlaju1l/r21R+aZt7D4Q3K+SW/FBXvXWl+3rnIhx+qZa1B9cRg TBfT8la+jf6nuDKjaseVjP1iyPQYAoEFd8imOyGyxPbwzw7JkU0k3/9g14vKKPbhqfqv AmLPt+Bpj3MCHFvmie91I1QNhxMWgxQO0uzASTUAri9Xxqg+2z8FjFAlAaySXz7mD50l AkS5EhoIl6Muj8NuihDSpEb/5O5W0yZ6BfkDlJkyML/guSTAEefZ3hvojNpKeBLlX6TP 6WyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=PgUNRGi/g5uS3IeI9ANmULTMewuA9OxhO89/tXhgjes=; b=I/Y10KLITCd6N17GAC3PiIoD2iAiGtFe0Y3n00YOs6Gw8n5ma9OiIouMSp9M+GOnXS dk94L7ECPKROUV6yYtM7+vrjYjqwwIB0+rG3oF9KWi/q8VaedLvxBvKDaQ7MeK6uMnKJ MBIsoCmCp+zMlXclD2QzRR9UN9OmE5F69uNg2IYLVrXXzedsDH5K97HQa13GBDZ/TAIw QfLhBa+P0jwcJAjr2zSwoLRrlwpP2opPN69z2UxkvtXQkGzhP3KbM+CzkVorkUno9pFK mpDAF08Pi99MzTpWOzskBDAsF7kqQ3EBRlVM+zWFXN3sOoCgSZbDcywk/SP3qZwrqC5R a0OQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u16si3813501oia.233.2020.01.09.06.59.55; Thu, 09 Jan 2020 07:00:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730216AbgAIM7q (ORCPT + 99 others); Thu, 9 Jan 2020 07:59:46 -0500 Received: from mga06.intel.com ([134.134.136.31]:45114 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728435AbgAIM7q (ORCPT ); Thu, 9 Jan 2020 07:59:46 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 04:59:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,413,1571727600"; d="scan'208";a="423246044" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by fmsmga006.fm.intel.com with ESMTP; 09 Jan 2020 04:59:44 -0800 Received: by tassilo.localdomain (Postfix, from userid 1000) id D19B0301003; Thu, 9 Jan 2020 04:59:44 -0800 (PST) Date: Thu, 9 Jan 2020 04:59:44 -0800 From: Andi Kleen To: Jiri Olsa Cc: Jann Horn , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , kernel list Subject: Re: "perf ftrace" segfault because ->cpus!=NULL but ->all_cpus==NULL Message-ID: <20200109125944.GS15478@tassilo.jf.intel.com> References: <20200109122443.GF52936@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109122443.GF52936@krava> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > oops, ftrace is using evlist without event ;-) so all_cpus > will not get initialized.. > > Andi, should we initialize evlist::all_cpus with the first > cpus we get, like in the patch below? I assume perf stat -A still works for all CPUs? If yes it's ok. -andi