Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2174532ybl; Thu, 9 Jan 2020 08:08:01 -0800 (PST) X-Google-Smtp-Source: APXvYqx30KcoryYuHuLa2bjGNjO6eADWvrTUWpkYlISFjZSPU/JSQpgKSK06tEDjY4NsXmiX15ug X-Received: by 2002:a9d:480b:: with SMTP id c11mr9598030otf.283.1578586080909; Thu, 09 Jan 2020 08:08:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578586080; cv=none; d=google.com; s=arc-20160816; b=PAubASu8sQ06G3Cva4UOhQdMcn1dJgTu06+pAoGiTb+lPg/Y/BI6JWtwtHciZ/renN KGVQP9I2oGCzmdj1H7qCzbJeMMGKdyVnSRXBnUifWLcBb79hC7W/tzrYZmJF/XCqPcJv EIqSngL9dHH1H03WaOLPcPPxBlxoQ2GhbAkiQzQiwCAdOcVMFTQa3P8l3+UI9GQo7Eqf lD3pp2920mV1Twn5zYWi0qxyALyBmkODYgVIN7GFtrKWgUUG1MFgyvexZlO5Ob3sEjOx dwdBW+1SdHCTuncJYAnNGrtWoUE8wlbSJPFc+P2+ZOH5FUBKsVY8OfQLjtm1ktNLvrlV EwYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Bwws+tO9I9tQbRiOVrZn10ifd3BCAQ4eGYhkP7+nREo=; b=f3tEszSOkJVuK5hA5eAf5jAbTV5GscQxJm/UWMIxGA/+UQIjvf2ygvEgMu+DC7pypT fPGkoHDJ9BY6J7uGsX8NO/slYuLWnObfkjak/oWZ6+XgcDyc5WDwMFjoWpnhw/v0tNHc kJ9rVjDZOQiOFbSUnMWD1kRIQpG+q4DwQHkyvylWJd7wZzt9/j6WWxCoDJoMu70HQ99C h3OPqXCB4vO+k+GpVESGHuW0A4UmMSvB9m7x1L3Fgw5u9/HFLYsaH7kXNT/7N8/dDNm4 Jpj0YI82RXo0L3pIj1sIVL87hQQJBGsq2DctAaFXYZoJszOLn8wB3TvkvAKWs27q2DKs 0m7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=GFv+wsOm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2si4108701oth.267.2020.01.09.08.07.44; Thu, 09 Jan 2020 08:08:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=GFv+wsOm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731634AbgAIOYr (ORCPT + 99 others); Thu, 9 Jan 2020 09:24:47 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:33612 "EHLO mail-wm1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731628AbgAIOYr (ORCPT ); Thu, 9 Jan 2020 09:24:47 -0500 Received: by mail-wm1-f52.google.com with SMTP id d139so2178475wmd.0 for ; Thu, 09 Jan 2020 06:24:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Bwws+tO9I9tQbRiOVrZn10ifd3BCAQ4eGYhkP7+nREo=; b=GFv+wsOmFHcCod8xr4q4mFZcrLDXObBrNqM8qQca43lrRQjVBm3vPTwcdb5Yqq4n1/ Uv1lW2i+PqKw6CukLnQ0G8HS6P5x7H9xw1ngCGDOkUnaPaaCbi7+znRr/A9l0tvrrPiG RRyMahdThv1GIzRU5Ndjfx/j5efxzs/DdYIXw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Bwws+tO9I9tQbRiOVrZn10ifd3BCAQ4eGYhkP7+nREo=; b=bywMk4i6A5q8NK9Y+nFau9jvuspQ1Im9iGKjLJd5Sj8zIhu9562cSOrl/FROGDmuw1 yzLg9Jn8WjabD6rPIu783EJy3+x9CNkcswHnWFVDBAvP/QJU79oLqVEPmQUBTkV/kowP QlaKR6Ot8zv3Vta4r5yn4JipRz9FR63wKn+Jns0/ZsiLfvETCinzaeIhkYDGdeMPXa9D 92kVlhtoc3aegIP587KncKHanxcSK9izCnZqgxTGxbU3rkaicks2P2fSOvFdS381Wl0g 0pgvWFUoqXENOe0rlCzYXb58n43L3vEUqGrG0ynO/5Q2Ri5rFyGu0uti8UgKEBb/AN1V 1teQ== X-Gm-Message-State: APjAAAVeGwOUNCsiHewsJj7BkXBokiz6MVxAoaDAc0RaDiymiMv6sHO/ Zh3/zaAP9fxcSnlvnLGk85wI9w== X-Received: by 2002:a1c:b4c3:: with SMTP id d186mr5112329wmf.140.1578579885654; Thu, 09 Jan 2020 06:24:45 -0800 (PST) Received: from localhost ([2620:10d:c092:200::1:37ce]) by smtp.gmail.com with ESMTPSA id t81sm3070545wmg.6.2020.01.09.06.24.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2020 06:24:45 -0800 (PST) Date: Thu, 9 Jan 2020 14:24:44 +0000 From: Chris Down To: Chen Yu Cc: x86@kernel.org, Thomas Gleixner , Borislav Petkov , Ingo Molnar , "H. Peter Anvin" , Alexey Dobriyan , Andrew Morton , Reinette Chatre , Fenghua Yu , Tony Luck , Michal Hocko , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][RESEND v5] x86/resctrl: Add task resctrl information display Message-ID: <20200109142444.GB61542@chrisdown.name> References: <20200109135001.10076-1-yu.c.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200109135001.10076-1-yu.c.chen@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chen Yu writes: >+#ifdef CONFIG_PROC_CPU_RESCTRL >+ >+/* >+ * A task can only be part of one control >+ * group and of one monitoring group which >+ * is associated to that control group. >+ * So one line is simple and clear enough: Can we please avoid using the word "control group" to describe these? It's extremely confusing for readers since it's exactly the same word as used for actual cgroups, especially since those are also a form of "resource control"... Doesn't official documentation refer to them as "resource groups" to avoid this?