Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2454013ybl; Thu, 9 Jan 2020 13:04:22 -0800 (PST) X-Google-Smtp-Source: APXvYqyk3TyJsBvy8xLKqTY7gbtnA098i4BOQUIdvm7IUZRC4X5VxKW6VzGmE5fLPE1aIxaxnLkD X-Received: by 2002:aca:f507:: with SMTP id t7mr4916992oih.156.1578603862216; Thu, 09 Jan 2020 13:04:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578603862; cv=none; d=google.com; s=arc-20160816; b=eDxuPeI8NLIND1ak3RIGji5MECGJ620QINaTrdtxYtLdBnC6A5+LTFvdRHRv02NRgX B/Qg4dYWhzZzf0SacIl2tzcoKmVp3AsMyVyjraRKeeZ74RaWHXMnVeQMvRNVKm3g3/Yl nokgr65wGHAztA9vTh28UlJfuS7PSB+D6dr7DophFBT0Qjh9AzU4UrYI8V3VDZj7w44D oXkgD3wmjSWpttKvebq4PkWybJZKmSUqck0PPb7oFbWF/8rs/nY3gdKx5kwKUasJARYT cyUitYN2lJmIV9eHwMTIl24XvbFJcqtVR2BdP7egXRbNNjBaeP938r22c9OlkwcXvwIf f7Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:mime-version :message-id:date:dkim-signature; bh=Jf5B4EbQ+30kjad3rYjf3nQGksGo1BPEiNIOzLgULXA=; b=WeCEsiFP+RpWHtbSOXrfEOOheFfFvDFKjIIqFcmkVs9FQw24ZSlB/22O3SD9Oo68WK AyuiWOjUuHztFbUaR/3Cc2rZI0nQhZ6z0aqvnj8EsyAiBNhvVpkjttgEzA8JVS+sMaNF qTA/RbXa66ahFJOjHfEnZbs4dif5Vd7lsv6OLqksFOMICZnlCNfpkDMa+cIPfUNYohEl 0Eryor3SUtcETFbSGseGJKIZSQHguufTfq5amcHHyH7HGctrYNC61QdDX+/4cY9RR7/A 4rhq+eqfN8MXD/XKY/z89iJIk7fFaFrqQpaxKT0OKLjXEge/0BSvMeXnImOHrqnBC5ht dx0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=S0pffzvI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i19si4037870oik.272.2020.01.09.13.04.10; Thu, 09 Jan 2020 13:04:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=S0pffzvI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732913AbgAIT7E (ORCPT + 99 others); Thu, 9 Jan 2020 14:59:04 -0500 Received: from mail-qk1-f202.google.com ([209.85.222.202]:51401 "EHLO mail-qk1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732624AbgAIT7D (ORCPT ); Thu, 9 Jan 2020 14:59:03 -0500 Received: by mail-qk1-f202.google.com with SMTP id 194so4895793qkh.18 for ; Thu, 09 Jan 2020 11:59:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=Jf5B4EbQ+30kjad3rYjf3nQGksGo1BPEiNIOzLgULXA=; b=S0pffzvIDcM3Erqu+B6kTPNDcpFqNGr5Lgn1Fru3tO/n7DHI2gxYrjybPEJWWCh8qJ Pq0rgh1x4T67aJo9Y/zOOMYHmaBy/jb6Su0M5dUAAiR9WjHyU+YkuKRtnzHYWGCyWKyE MqwTw1DzPgVrFVIXrMNlxC3ecz6b3un5RTrwDgI00pOnvxkf6Wy1J5pEUYd0lVc4izWr VWOj3Nyud4Ev6G1bkQDxfDiynv0ORLWJeBXNAAy1Xa4s5vRAYDSYRYx6SXZbxDu/s+fy 17QqQeerEc+n7g0sUmMtpqMYLtTi71Zc7Mkp0zM6VJIhpvpLIV8t7L68BkFDNQTCyWfp 85Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=Jf5B4EbQ+30kjad3rYjf3nQGksGo1BPEiNIOzLgULXA=; b=SNgLNO0bwT72BdmQcyg9Lq3X/MFWE6W34LedwXhF6nMDcau5/AkF/vCeI9HLUzw0EQ iX7Df+L346XFIZ2s8pfQdois2m3I4kDl+LOFOTsAp3v2M/sp1bnBDNRUJfXh3SkhmEHj WbSGv19/9UVlEYoV6aL4hygkx4nkhlKv+14cClPyW25dlbZU0mC6qwVFolLTU6Ag4cjy XWSAHXC4N29kUkC+vktD/uKpA0gwrc7eLs9Y1+jwLPJ7u+gn1C4TmEH3gXwCVZv4D2r7 pLpIGsOS0wGBdQTtgqoFmhgGJBd24ITPEz5T02vJJm/oH5LOWWwVjH1BC3Q+TmK/53eb 18zA== X-Gm-Message-State: APjAAAWjuGkJxUcmkCQsBH6UD53yeUjP6dapyuKaR3iYBTXA6xIjL51c FW8zkYKhbeOSBS1tWOiMvd3BtXcl X-Received: by 2002:a37:e507:: with SMTP id e7mr11506262qkg.358.1578599942496; Thu, 09 Jan 2020 11:59:02 -0800 (PST) Date: Thu, 9 Jan 2020 14:58:55 -0500 Message-Id: <20200109195855.17353-1-brho@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.25.0.rc1.283.g88dfdc4193-goog Subject: [PATCH] KVM: squelch uninitialized variable warning From: Barret Rhoden To: pbonzini@redhat.com Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If gfn_to_hva_many() fails, __kvm_gfn_to_hva_cache_init() will return an error. Before it does, it might use nr_pages_avail, which my compiler complained about: virt/kvm/kvm_main.c:2193:13: warning: 'nr_pages_avail' may be used uninitialized in this function [-Wmaybe-uninitialized] start_gfn += nr_pages_avail; Signed-off-by: Barret Rhoden --- virt/kvm/kvm_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index d9aced677ddd..f8249b153d33 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -2172,7 +2172,7 @@ static int __kvm_gfn_to_hva_cache_init(struct kvm_memslots *slots, gfn_t start_gfn = gpa >> PAGE_SHIFT; gfn_t end_gfn = (gpa + len - 1) >> PAGE_SHIFT; gfn_t nr_pages_needed = end_gfn - start_gfn + 1; - gfn_t nr_pages_avail; + gfn_t nr_pages_avail = 0; int r = start_gfn <= end_gfn ? 0 : -EINVAL; ghc->gpa = gpa; -- 2.25.0.rc1.283.g88dfdc4193-goog