Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/1] media: dvb_dummy_tuner: implement driver skeleton
To:     Shuah Khan <skhan@linuxfoundation.org>, mchehab@kernel.org,
        sean@mess.org, tglx@linutronix.de, gregkh@linuxfoundation.org
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
References: <20200109152408.919325-1-dwlsalmeida@gmail.com>
 <20200109152408.919325-2-dwlsalmeida@gmail.com>
 <5f296977-6aac-cfd9-9082-ff824f85ab43@linuxfoundation.org>
From:   "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Message-ID: <ebec2bb5-8db0-76fe-9c66-0316c1800f7c@gmail.com>
Date:   Thu, 9 Jan 2020 18:00:01 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <5f296977-6aac-cfd9-9082-ff824f85ab43@linuxfoundation.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Shuah, thank you for you input!


>
> Looks like there is more code to be added to register/unregister 

Just to be clear, attach() is missing, but register / unregister belong 
in the bridge driver. Is this correct?


>
> Please add more detail here on what this driver does. What this
> driver is used for and so on.
>
>
> Samehere. Give more details on what this driver does. Add enough detail
> to help users decide why they should enable it or not. 
>
> General practice is the following.
>
> Copyright (c) 2020 Daniel W. S. Almeida <dwlsalmeida@gmail.com>

> Please add details about the driver similar to the .c file. 

OK.


Thanks

- Daniel