Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2457936ybl; Thu, 9 Jan 2020 13:08:19 -0800 (PST) X-Google-Smtp-Source: APXvYqwUYUTUlP1PWMX95fwkvkL7MLtIRuBcST4w7SH62Xa6wcBuBbqawL/xKi2auCZ70Gg4xYo2 X-Received: by 2002:a05:6808:143:: with SMTP id h3mr4943332oie.61.1578604099098; Thu, 09 Jan 2020 13:08:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578604099; cv=none; d=google.com; s=arc-20160816; b=0JCcyqDy4LSFbeBB7CZCbTjOSAp6gB5vOfoFlHK0O66KcTPLMgP5Bui8TjnLlW1IkX p8vYaf6rk+D5UM0HqJ9u2alzC9SIIwMq3n079XjYfmWJyFa6IcriKYrz9FkWel1VABbK fVJPSa0MwhLkCGFbxTJSxd1RCW9AXRczZC+Exn9m6bMbnz9iKEwMC8k0Ejve072wME25 SbuZoawWq6d85zavq6o8bJA8gYLEjdmTHmea8Jwl53w5/EaX2kbeSiHBd26hGVttEurL XZzjauIRlI3/DXeJr13sms20Or8p1V1KD0iRzN8NM568D4GRdDWIXW7nZ954vZIqM+Kw OMZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=3w3iPy3/uKzT9CehdtuPaCa9fBrGdze9h68n+1qUrKk=; b=SEala9uXxVjDyE2dyEsD/ImGbM5wyJhxb32OEd+jRSgSKtizqenXcZyE8ytE9MTE3l JN8iPY0Vu0WkjSdXdenMR+xqxHRhGy2Su/gqT053ZbpMfUKT/TfsoinY/pEdCPC9C+2o hRDYnw98uCGSgldNKkgNdA8DSr+WsPGkeujQxVbF9Zs7R442JwNmXwEwsNdOI8WWDHzS +CW38IM035LowEncQoe23kqcwFNXKO2iCDquAIxqylbPQ8AMX194b2gIZ3CdBRY5dA+/ dAumO1R6x3rtiKLl0n7plnZ7Z/GYvQAWUqLyqZwVMygjubqEoHyImVU4+uiK704V5H7x Q6xw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a205si4280387oii.95.2020.01.09.13.08.05; Thu, 09 Jan 2020 13:08:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728241AbgAIVFo (ORCPT + 99 others); Thu, 9 Jan 2020 16:05:44 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:55732 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728052AbgAIVFo (ORCPT ); Thu, 9 Jan 2020 16:05:44 -0500 Received: from p5b06da22.dip0.t-ipconnect.de ([91.6.218.34] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1ipez7-0008OC-Ij; Thu, 09 Jan 2020 22:04:53 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 0AA1A105BCE; Thu, 9 Jan 2020 22:04:53 +0100 (CET) From: Thomas Gleixner To: Sean Christopherson , Paolo Bonzini Cc: Paul Mackerras , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, syzbot+c9d1fb51ac9d0d10c39d@syzkaller.appspotmail.com, Andrea Arcangeli , Dan Williams , Barret Rhoden , David Hildenbrand , Jason Zeng , Dave Jiang , Liran Alon , linux-nvdimm Subject: Re: [PATCH 05/14] x86/mm: Introduce lookup_address_in_mm() In-Reply-To: <20200108202448.9669-6-sean.j.christopherson@intel.com> References: <20200108202448.9669-1-sean.j.christopherson@intel.com> <20200108202448.9669-6-sean.j.christopherson@intel.com> Date: Thu, 09 Jan 2020 22:04:53 +0100 Message-ID: <871rs8batm.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sean Christopherson writes: > diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h > index b5e49e6bac63..400ac8da75e8 100644 > --- a/arch/x86/include/asm/pgtable_types.h > +++ b/arch/x86/include/asm/pgtable_types.h > @@ -561,6 +561,10 @@ static inline void update_page_count(int level, unsigned long pages) { } > extern pte_t *lookup_address(unsigned long address, unsigned int *level); > extern pte_t *lookup_address_in_pgd(pgd_t *pgd, unsigned long address, > unsigned int *level); > + > +struct mm_struct; > +pte_t *lookup_address_in_mm(struct mm_struct *mm, unsigned long address, > + unsigned int *level); Please keep the file consistent and use extern even if not required. Other than that: Reviewed-by: Thomas Gleixner