Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 9 Jan 2020 14:49:35 -0700
From:   Jerry Snitselaar <jsnitsel@redhat.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
        Peter Huewe <peterhuewe@gmx.de>,
        Jason Gunthorpe <jgg@ziepe.ca>, linux-integrity@vger.kernel.org
Subject: Re: [PATCH v4] tpm: Add tpm_version_major sysfs file
Message-ID: <20200109214935.ud7p7uwjimilxvi7@cantor>
Reply-To: Jerry Snitselaar <jsnitsel@redhat.com>
Mail-Followup-To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        linux-kernel@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
        Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
        linux-integrity@vger.kernel.org
References: <20191030225843.23366-1-jsnitsel@redhat.com>
 <20191128010826.w4ixlix3s3ovta3m@cantor>
 <20191129235131.GA21546@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
In-Reply-To: <20191129235131.GA21546@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat Nov 30 19, Jarkko Sakkinen wrote:
>On Wed, Nov 27, 2019 at 06:08:26PM -0700, Jerry Snitselaar wrote:
>> On Wed Oct 30 19, Jerry Snitselaar wrote:
>> > Easily determining what TCG version a tpm device implements
>> > has been a pain point for userspace for a long time, so
>> > add a sysfs file to report the TCG major version of a tpm device.
>> >
>> > Also add an entry to Documentation/ABI/stable/sysfs-class-tpm
>> > describing the new file.
>> >
>> > Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>> > Cc: Mimi Zohar <zohar@linux.ibm.com>
>> > Cc: Peter Huewe <peterhuewe@gmx.de>
>> > Cc: Jason Gunthorpe <jgg@ziepe.ca>
>> > Cc: linux-integrity@vger.kernel.org
>> > Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
>> > ---
>> > v4: - Change file name to tpm_version_major
>> >    - Actually display just the major version.
>> >    - change structs to tpm1_* & tpm2_*
>> >      instead of tpm12_* tpm20_*.
>> > v3: - Change file name to version_major.
>> > v2: - Fix TCG usage in commit message.
>> >    - Add entry to sysfs-class-tpm in Documentation/ABI/stable
>> >
>> > Documentation/ABI/stable/sysfs-class-tpm | 11 ++++++++
>> > drivers/char/tpm/tpm-sysfs.c             | 34 +++++++++++++++++++-----
>> > 2 files changed, 38 insertions(+), 7 deletions(-)
>> >
>>
>> Anyone else have feedback?
>
>I can apply this after the issues on hand have been sorted out.
>
>/Jarkko
>

Hi Jarkko,

Will this get queued up for 5.6?

Regards,
Jerry