Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200107214042.855757-1-arnd@arndb.de> <20200108102602.43d4c5433eb495cdbf387e9b@kernel.org>
 <20200109140202.fd5488a2ac02f81b25d83b88@linux-foundation.org>
In-Reply-To: <20200109140202.fd5488a2ac02f81b25d83b88@linux-foundation.org>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Thu, 9 Jan 2020 23:18:19 +0100
Message-ID: <CAK8P3a3Cy_WwtJGLF96tXrqT=hYw50NHy+DbaW2=DEbf_iXUeg@mail.gmail.com>
Subject: Re: [PATCH] kallsyms: work around bogus -Wrestrict warning
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Masami Hiramatsu <mhiramat@kernel.org>,
        Oleksandr Natalenko <oleksandr@redhat.com>,
        Linux-MM <linux-mm@kvack.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Will Deacon <will@kernel.org>,
        Song Liu <songliubraving@fb.com>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Marc Zyngier <maz@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jan 9, 2020 at 11:02 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Wed, 8 Jan 2020 10:26:02 +0900 Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > Hi Arnd,
> >
> > On Tue,  7 Jan 2020 22:40:26 +0100
> > Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > > gcc -O3 produces some really odd warnings for this file:
> > >
> > > kernel/kallsyms.c: In function 'sprint_symbol':
> > > kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
> > >    strcpy(buffer, name);
> > >    ^~~~~~~~~~~~~~~~~~~~
> > > kernel/kallsyms.c: In function 'sprint_symbol_no_offset':
> > > kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
> > >    strcpy(buffer, name);
> > >    ^~~~~~~~~~~~~~~~~~~~
> > > kernel/kallsyms.c: In function 'sprint_backtrace':
> > > kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
> > >    strcpy(buffer, name);
> > >    ^~~~~~~~~~~~~~~~~~~~
> > >
> > > This obviously cannot be since it is preceded by an 'if (name != buffer)'
> > > check.
> >
> > Hmm, this looks like a bug in gcc.
>
> Yes, we're getting a lot of such reports.  I don't think current gcc is
> ready for this patch so I'll drop it, sorry.

I've been building with gcc-8 and got around 20 false positive
warnings, three real bugs
and a few files that introduce increased stack usage. I have sent
patches for every one
of these and have a clean randconfig builds again on arm, arm64 and
x86 (a few thousand
so far).

Most of the false-positive warnings are for understandable reasons and easy to
work around, the one above is probably the most blatant screwup by gcc.

My feeling is that we can deal with the warnings here and I wouldn't
mind getting
it enabled in mainline from that perspective, but there are two caveats:

- v5.6 is probably too early since we're close to the merge window and a lot of
  my fixups have not been merged yet

- I have no good estimate of how many runtime failures there will be.
  Oleksandr hasn't found any issues after running with -O3 kernels for
  a longer time, but any significant change to the toolchain likely causes
  problems for somebody.

        Arnd