Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     =?utf-8?Q?'Pali_Roh=C3=A1r'?= <pali.rohar@gmail.com>
Cc:     <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <valdis.kletnieks@vt.edu>,
        <hch@lst.de>, <sj1557.seo@samsung.com>, <linkinjeon@gmail.com>,
        <tytso@mit.edu>,
        "'Gabriel Krisman Bertazi'" <krisman@collabora.com>
In-Reply-To: <20200105165115.37dyrcwtgf6zgc6r@pali>
Subject: RE: [PATCH v9 10/13] exfat: add nls operations
Date:   Fri, 10 Jan 2020 07:37:40 +0900
Message-ID: <001501d5c73d$66954a10$33bfde30$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQJSGi/S1M7UFBjz5N3SW71o+eawLwHz+Lr1AtmMBwQCEsM+eKazQ8Cw
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20200102082036.29643-1-namjae.jeon@samsung.com>
        <CGME20200102082407epcas1p4cf10cd3d0ca2903707ab01b1cc523a05@epcas1p4.samsung.com>
        <20200102082036.29643-11-namjae.jeon@samsung.com>
        <20200105165115.37dyrcwtgf6zgc6r@pali>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> On Thursday 02 January 2020 16:20:33 Namjae Jeon wrote:
> > This adds the implementation of nls operations for exfat.
> 
> Hello! In whole patch series are different naming convention for
> nls/Unicode related terms. E.g. uni16s, utf16s, nls, vfsname, ...
> 
> Could this be fixed, so it would be unambiguously named? "uni16s" name is
> misleading as Unicode does not fit into 16byte type.
> 
> Based on what is in nls.h I would propose following names:
> 
> * unicode_t *utf32s always for strings in UTF-32/UCS-4 encoding (host
>   endianity) (or "unicode_t *unis" as this is the fixed-width encoding
>   for all Unicode codepoints)
> 
> * wchar_t *utf16s always for strings in UTF-16 encoding (host endianity)
> 
> * u8 *utf8s always for strings in UTF-8 encoding
> 
> * wchar_t *ucs2s always for strings in UCS-2 encoding (host endianity)
> 
> Plus in the case you need to work with UTF-16 or UCS-2 in little endian,
> add appropriate naming suffixes.
> 
> And use e.g. "vfsname" (char * OR unsigned char * OR u8 *) like you
> already have on some places for strings in iocharset= encoding.
Will rename them on v10.

Thanks!