Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2542684ybl; Thu, 9 Jan 2020 14:47:39 -0800 (PST) X-Google-Smtp-Source: APXvYqzRbpTV+DCgtYrmnVc47GeIu8GpK7gcpEieNkQiOgj8r+7N/D4CoTVnTqLiGQMkq812iX+h X-Received: by 2002:aca:5fc6:: with SMTP id t189mr5320119oib.166.1578610058930; Thu, 09 Jan 2020 14:47:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578610058; cv=none; d=google.com; s=arc-20160816; b=S05wo/sSHGnL8JxY6KhCsu0zKMV6HKU8VqyGl7Dq3/FLhcSLxv3lluhfR/e/X4QoxY rQAK2zeUqB7skT1SQqTSL+Yzj7XhRM9zbwLz61ehvBUmmin5xtn/RdGpY8M11RZnlFcw 7t1slQA5S7z2vl2uhAuWGDi2ri75evZuze6MThTXvCUUCu4hA8V7+duNbznCuNOjnvdi JcbxCh8jOV2ISZWcwAYgF2vy1pQM+Z7yK/Sm91kBXTq/X5KrvkQPOj+6QvP4H9P1BskB MHhhLU+OAVQ5h9f/uGlUJumDFEipxQLAKdN+EJyQzadHqoOIdPncuhr1ZvefnAdGEsS6 QBTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=IDLYJpNn9gDDVDsAw8JkYnVzGkE3sq6/3kOzxLaB4f0=; b=MUdANZHG/zo2Hv7vhDuwvuZJOW7hP4XfRrfqyMOM8l5qOOxc7qpxFCWZ0RPHdQZApD 5/rN47g7r/OhgSJ4qdvQRhswkAGT+vyRRFrH7/VnFc71QWG/ZNwRi8FvFCcDZETPKbCD UI++ERKlicqI0roIxHSXcCBSoME76gmZ5jSOIbB/kJ1NYaKN0+D16BFaVTqp+56obt/o jVhqMwZbdlCscKdCFhQZTl989ex/xMSld9GbxRbVnekK9mdqIT8mWtcgZAKL9UtPls2d 3EpAdXW4w9JXzE0rYpo1OkjeXh9vIitd52JvJG9TcqLLRL7ivtEJd0bTrJKREtryoory ZGHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FaLhyKPa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d5si4379250oij.139.2020.01.09.14.47.27; Thu, 09 Jan 2020 14:47:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FaLhyKPa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728657AbgAIWqS (ORCPT + 99 others); Thu, 9 Jan 2020 17:46:18 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38821 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725807AbgAIWqS (ORCPT ); Thu, 9 Jan 2020 17:46:18 -0500 Received: by mail-wr1-f67.google.com with SMTP id y17so9206882wrh.5 for ; Thu, 09 Jan 2020 14:46:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IDLYJpNn9gDDVDsAw8JkYnVzGkE3sq6/3kOzxLaB4f0=; b=FaLhyKPa3tNpOCqhBodsSnP5nYvHJf5yurTgiOKV0GJBOLCWo72fgLccduC8u/YD6I X0hFP9UIZZnjoLkjW7fgOjM/L2Xv2DVfWK0SDsqF2ht3HjQA72VnL3iel9ZyLVWhvtf8 WGdTZjy2N1isiMqRsbf6hQ0GYywjonN8LyQsVxNgyEc/EZvXETMmNwON/9VkvAGdxtf0 QaRJxKN4z6CK31neCtkJY76RmVmGPGXNBHBjFjFX3K/PSFWfZMciSZCNn13lsMAMGVUm KJf/rXp9hibfTMIyKHJDetcXQtUriyk4aF5VVn+6UpUyjXHBsSf6RRhEvsxtml5gd65s ouyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=IDLYJpNn9gDDVDsAw8JkYnVzGkE3sq6/3kOzxLaB4f0=; b=QIb5AzcxLSY4WR5zmsWo7uOb2yNSoyoeGF8rFklDo23jfOZw9nF/iYGRglZhiyyL8u fNYk/4HOninsEV1lGYwPPgm+5Hxq7OOSpjBr84dteGWhUiN74YUSo215RWWEB8f0zsa3 k60wirFsGLNWCOyPLVEtN2LQUNDwi35SYf4a7CLY1ONSL/CSIsJyh/X5Fsc/k+dSXKM7 iIeW95GaI0TswtG94pxOk7kwG9I0P/V/cecOEcHCTz5WyKg6c5g8Tm0rmJeKv/UqUOUN eZKxI8eiaThX6EBJ9G0Or51hgmwCNZtCLXQvkilB+iIL7TeNzSZCghuEjgVOOABXnQqd Ngaw== X-Gm-Message-State: APjAAAXlMwSwXzCjYRxSh1QKhiQHuSkeVYs/p9HFZ73vOF3drMbdNIpJ N7IRG1yDxWegVZwPg8R88bdHqQ== X-Received: by 2002:a5d:5044:: with SMTP id h4mr118585wrt.4.1578609976095; Thu, 09 Jan 2020 14:46:16 -0800 (PST) Received: from ?IPv6:2a01:e34:ed2f:f020:f1d5:61e0:e9d8:1c3d? ([2a01:e34:ed2f:f020:f1d5:61e0:e9d8:1c3d]) by smtp.googlemail.com with ESMTPSA id w20sm34428wmk.34.2020.01.09.14.46.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2020 14:46:15 -0800 (PST) Subject: Re: [PATCH] drivers: thermal: step_wise: add support for hysteresis To: Ram Chandrasekar , Amit Kucheria , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, swboyd@chromium.org, j-keerthy@ti.com, thara.gopinath@linaro.org, Zhang Rui , Eduardo Valentin , Amit Kucheria Cc: Lina Iyer , linux-pm@vger.kernel.org References: <8e812065f4a76325097c5f9c17f3386736d8c1d4.1574315190.git.amit.kucheria@linaro.org> <962d48d2-87fd-1236-0623-148352a98de6@linaro.org> <4f75a862-4525-fe11-ed03-f53a13926c15@codeaurora.org> From: Daniel Lezcano Autocrypt: addr=daniel.lezcano@linaro.org; prefer-encrypt=mutual; keydata= xsFNBFv/yykBEADDdW8RZu7iZILSf3zxq5y8YdaeyZjI/MaqgnvG/c3WjFaunoTMspeusiFE sXvtg3ehTOoyD0oFjKkHaia1Zpa1m/gnNdT/WvTveLfGA1gH+yGes2Sr53Ht8hWYZFYMZc8V 2pbSKh8wepq4g8r5YI1XUy9YbcTdj5mVrTklyGWA49NOeJz2QbfytMT3DJmk40LqwK6CCSU0 9Ed8n0a+vevmQoRZJEd3Y1qXn2XHys0F6OHCC+VLENqNNZXdZE9E+b3FFW0lk49oLTzLRNIq 0wHeR1H54RffhLQAor2+4kSSu8mW5qB0n5Eb/zXJZZ/bRiXmT8kNg85UdYhvf03ZAsp3qxcr xMfMsC7m3+ADOtW90rNNLZnRvjhsYNrGIKH8Ub0UKXFXibHbafSuq7RqyRQzt01Ud8CAtq+w P9EftUysLtovGpLSpGDO5zQ++4ZGVygdYFr318aGDqCljKAKZ9hYgRimPBToDedho1S1uE6F 6YiBFnI3ry9+/KUnEP6L8Sfezwy7fp2JUNkUr41QF76nz43tl7oersrLxHzj2dYfWUAZWXva wW4IKF5sOPFMMgxoOJovSWqwh1b7hqI+nDlD3mmVMd20VyE9W7AgTIsvDxWUnMPvww5iExlY eIC0Wj9K4UqSYBOHcUPrVOKTcsBVPQA6SAMJlt82/v5l4J0pSQARAQABzSpEYW5pZWwgTGV6 Y2FubyA8ZGFuaWVsLmxlemNhbm9AbGluYXJvLm9yZz7Cwa4EEwEIAEECGwEFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4ACGQEWIQQk1ibyU76eh+bOW/SP9LjScWdVJwUCXAkeagUJDRnjhwAh CRCP9LjScWdVJxYhBCTWJvJTvp6H5s5b9I/0uNJxZ1Un69gQAJK0ODuKzYl0TvHPU8W7uOeu U7OghN/DTkG6uAkyqW+iIVi320R5QyXN1Tb6vRx6+yZ6mpJRW5S9fO03wcD8Sna9xyZacJfO UTnpfUArs9FF1pB3VIr95WwlVoptBOuKLTCNuzoBTW6jQt0sg0uPDAi2dDzf+21t/UuF7I3z KSeVyHuOfofonYD85FkQJN8lsbh5xWvsASbgD8bmfI87gEbt0wq2ND5yuX+lJK7FX4lMO6gR ZQ75g4KWDprOO/w6ebRxDjrH0lG1qHBiZd0hcPo2wkeYwb1sqZUjQjujlDhcvnZfpDGR4yLz 5WG+pdciQhl6LNl7lctNhS8Uct17HNdfN7QvAumYw5sUuJ+POIlCws/aVbA5+DpmIfzPx5Ak UHxthNIyqZ9O6UHrVg7SaF3rvqrXtjtnu7eZ3cIsfuuHrXBTWDsVwub2nm1ddZZoC530BraS d7Y7eyKs7T4mGwpsi3Pd33Je5aC/rDeF44gXRv3UnKtjq2PPjaG/KPG0fLBGvhx0ARBrZLsd 5CTDjwFA4bo+pD13cVhTfim3dYUnX1UDmqoCISOpzg3S4+QLv1bfbIsZ3KDQQR7y/RSGzcLE z164aDfuSvl+6Myb5qQy1HUQ0hOj5Qh+CzF3CMEPmU1v9Qah1ThC8+KkH/HHjPPulLn7aMaK Z8t6h7uaAYnGzjMEXZLIEhYJKwYBBAHaRw8BAQdAGdRDglTydmxI03SYiVg95SoLOKT5zZW1 7Kpt/5zcvt3CwhsEGAEIACAWIQQk1ibyU76eh+bOW/SP9LjScWdVJwUCXZLIEgIbAgCvCRCP 9LjScWdVJ40gBBkWCAAdFiEEbinX+DPdhovb6oob3uarTi9/eqYFAl2SyBIAIQkQ3uarTi9/ eqYWIQRuKdf4M92Gi9vqihve5qtOL396pnZGAP0c3VRaj3RBEOUGKxHzcu17ZUnIoJLjpHdk NfBnWU9+UgD/bwTxE56Wd8kQZ2e2UTy4BM8907FsJgAQLL4tD2YZggwWIQQk1ibyU76eh+bO W/SP9LjScWdVJ5CaD/0YQyfUzjpR1GnCSkbaLYTEUsyaHuWPI/uSpKTtcbttpYv+QmYsIwD9 8CeH3zwY0Xl/1fE9Hy59z6Vxv9YVapLx0nPDOA1zDVNq2MnutxHb8t+Imjz4ERCxysqtfYrv gao3E/h0c8SEeh+bh5MkjwmU8CwZ3doWyiVdULKESe7/Gs5OuhFzaDVPCpWdsKdCAGyUuP/+ qRWwKGVpWP0Rrt6MTK24Ibeu3xEZO8c3XOEXH5d9nf6YRqBEIizAecoCr00E9c+6BlRS0AqR OQC3/Mm7rWtco3+WOridqVXkko9AcZ8AiM5nu0F8AqYGKg0y7vkL2LOP8us85L0p57MqIR1u gDnITlTY0x4RYRWJ9+k7led5WsnWlyv84KNzbDqQExTm8itzeZYW9RvbTS63r/+FlcTa9Cz1 5fW3Qm0BsyECvpAD3IPLvX9jDIR0IkF/BQI4T98LQAkYX1M/UWkMpMYsL8tLObiNOWUl4ahb PYi5Yd8zVNYuidXHcwPAUXqGt3Cs+FIhihH30/Oe4jL0/2ZoEnWGOexIFVFpue0jdqJNiIvA F5Wpx+UiT5G8CWYYge5DtHI3m5qAP9UgPuck3N8xCihbsXKX4l8bdHfziaJuowief7igeQs/ WyY9FnZb0tl29dSa7PdDKFWu+B+ZnuIzsO5vWMoN6hMThTl1DxS+jc7ATQRb/8z6AQgAvSkg 5w7dVCSbpP6nXc+i8OBz59aq8kuL3YpxT9RXE/y45IFUVuSc2kuUj683rEEgyD7XCf4QKzOw +XgnJcKFQiACpYAowhF/XNkMPQFspPNM1ChnIL5KWJdTp0DhW+WBeCnyCQ2pzeCzQlS/qfs3 dMLzzm9qCDrrDh/aEegMMZFO+reIgPZnInAcbHj3xUhz8p2dkExRMTnLry8XXkiMu9WpchHy XXWYxXbMnHkSRuT00lUfZAkYpMP7La2UudC/Uw9WqGuAQzTqhvE1kSQe0e11Uc+PqceLRHA2 bq/wz0cGriUrcCrnkzRmzYLoGXQHqRuZazMZn2/pSIMZdDxLbwARAQABwsGNBBgBCAAgFiEE JNYm8lO+nofmzlv0j/S40nFnVScFAlv/zPoCGwwAIQkQj/S40nFnVScWIQQk1ibyU76eh+bO W/SP9LjScWdVJ/g6EACFYk+OBS7pV9KZXncBQYjKqk7Kc+9JoygYnOE2wN41QN9Xl0Rk3wri qO7PYJM28YjK3gMT8glu1qy+Ll1bjBYWXzlsXrF4szSqkJpm1cCxTmDOne5Pu6376dM9hb4K l9giUinI4jNUCbDutlt+Cwh3YuPuDXBAKO8YfDX2arzn/CISJlk0d4lDca4Cv+4yiJpEGd/r BVx2lRMUxeWQTz+1gc9ZtbRgpwoXAne4iw3FlR7pyg3NicvR30YrZ+QOiop8psWM2Fb1PKB9 4vZCGT3j2MwZC50VLfOXC833DBVoLSIoL8PfTcOJOcHRYU9PwKW0wBlJtDVYRZ/CrGFjbp2L eT2mP5fcF86YMv0YGWdFNKDCOqOrOkZVmxai65N9d31k8/O9h1QGuVMqCiOTULy/h+FKpv5q t35tlzA2nxPOX8Qj3KDDqVgQBMYJRghZyj5+N6EKAbUVa9Zq8xT6Ms2zz/y7CPW74G1GlYWP i6D9VoMMi6ICko/CXUZ77OgLtMsy3JtzTRbn/wRySOY2AsMgg0Sw6yJ0wfrVk6XAMoLGjaVt X4iPTvwocEhjvrO4eXCicRBocsIB2qZaIj3mlhk2u4AkSpkKm9cN0KWYFUxlENF4/NKWMK+g fGfsCsS3cXXiZpufZFGr+GoHwiELqfLEAQ9AhlrHGCKcgVgTOI6NHg== Message-ID: <211a066d-f801-fb21-a14d-2b00765d2547@linaro.org> Date: Thu, 9 Jan 2020 23:46:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <4f75a862-4525-fe11-ed03-f53a13926c15@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/01/2020 01:31, Ram Chandrasekar wrote: > > > On 12/11/2019 6:35 AM, Daniel Lezcano wrote: >> On 21/11/2019 06:50, Amit Kucheria wrote: >>> From: Ram Chandrasekar >>> >>> Currently, step wise governor increases the mitigation when the >>> temperature goes above a threshold and decreases the mitigation when the >>> temperature goes below the threshold. >>> >>> If there is a case where the >>> temperature is wavering around the threshold, the mitigation will be >>> applied and removed every iteration, which is not very efficient. >>> >>> The use of hysteresis temperature could avoid this ping-pong of >>> mitigation by relaxing the mitigation to happen only when the >>> temperature goes below this lower hysteresis value. >> >> What I'm worried about is how the hysteresis is used in the current >> code, where the destination of this data is to set the value in the >> sensor hardware if it is supported. >> >> Using the hysteresis in the governor seems like abusing the initial >> purpose of this information. >> >> Moreover, the hysteresis creates a gray area where the above algorithm >> (DROPPING && !throttle) => state-- or (RAISING && throttle) => state++ >> may drop the performances because we will continue mitigating even below >> the threshold. >> >> As the governor is an open-loop controller, I'm not sure if we can do >> something except adding some kind of low pass filter to prevent >> mitigation bounces. >> > > We have two different use cases for the step wise algorithm, and the > hysteresis makes sense only in one. > > For example, say we are controlling CPU junction temperature at 95C. > When using step wise, mitigation is applied iteratively and there is a > possibility that temperature can shoot up before the algorithm can reach > an optimal mitigation level to keep the temperature near threshold. > > In order to help this state machine, we use a second back stop rule in > the same thermal zone at a higher temperature (say 105C) with a > hysteresis of 10C to mitigate CPU to a fixed value, by specifying > upper/lower limit to be the same. The idea is that the second rule will > place a hard hammer to bring the temperature down close to 95C and then > it will remove the mitigation. Once mitigation is removed, the junction > temperature rule state machine will re-adjust from that point to an > optimal mitigation level. The junction temperature rule doesn’t use > hysteresis. > > Another example is skin temperature mitigation for mobile devices, where > the step wise algorithm with hysteresis just reduces the operating max > frequency to a fixed value, when the threshold is reached. And the > junction temperature rule starts mitigating from this operating max. > > That is the reason we have not generalized or mandated the hysteresis > usage in this patch. The idea is to use it selectively based on use case. Did you ever try the IPA governor? -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog