Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     "'Arnd Bergmann'" <arnd@arndb.de>
Cc:     =?utf-8?Q?'Pali_Roh=C3=A1r'?= <pali.rohar@gmail.com>,
        <linux-kernel@vger.kernel.org>,
        "'Linux FS-devel Mailing List'" <linux-fsdevel@vger.kernel.org>,
        "'gregkh'" <gregkh@linuxfoundation.org>,
        "'Valdis Kletnieks'" <valdis.kletnieks@vt.edu>,
        <sj1557.seo@samsung.com>, <linkinjeon@gmail.com>,
        "'Christoph Hellwig'" <hch@lst.de>
In-Reply-To: <CAK8P3a0S6DBJqDMj4Oy9xeYVhW87HbBX2SqURFPKYT8K1z7fDw@mail.gmail.com>
Subject: RE: [PATCH v9 09/13] exfat: add misc operations
Date:   Fri, 10 Jan 2020 08:32:16 +0900
Message-ID: <001e01d5c745$0765ca80$16315f80$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQJSGi/S1M7UFBjz5N3SW71o+eawLwJob/ETArMVgR4BcbvZIAG7WpyVAtwAkTymkS7JAA==
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20200102082036.29643-1-namjae.jeon@samsung.com>
        <CGME20200102082406epcas1p268f260d90213bdaabee25a7518f86625@epcas1p2.samsung.com>
        <20200102082036.29643-10-namjae.jeon@samsung.com>
        <20200102091902.tk374bxohvj33prz@pali> <20200108180304.GE14650@lst.de>
        <CAK8P3a0S6DBJqDMj4Oy9xeYVhW87HbBX2SqURFPKYT8K1z7fDw@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> On Wed, Jan 8, 2020 at 7:03 PM Christoph Hellwig <hch=40lst.de> wrote:
> >
> > Arnd, can you review the exfat time handling, especially vs y2038
> > related issues?
>=20
> Sure, thanks for adding me to the loop
>=20
> > On Thu, Jan 02, 2020 at 10:19:02AM +0100, Pali Roh=C3=A1r=20wrote:=0D=
=0A>=20>=20>=20On=20Thursday=2002=20January=202020=2016:20:32=20Namjae=20Je=
on=20wrote:=0D=0A>=20>=20>=20>=20+=23define=20TIMEZONE_CUR_OFFSET()=20=20=
=20=20=20=20((sys_tz.tz_minuteswest=20/=20(-15))=0D=0A>=20&=200x7F)=0D=0A>=
=20>=20>=20>=20+/*=20Convert=20linear=20UNIX=20date=20to=20a=20FAT=20time/d=
ate=20pair.=20*/=20void=0D=0A>=20>=20>=20>=20+exfat_time_unix2fat(struct=20=
exfat_sb_info=20*sbi,=20struct=20timespec64=0D=0A>=20*ts,=0D=0A>=20>=20>=20=
>=20+=20=20=20=20=20=20=20=20=20=20=20struct=20exfat_date_time=20*tp)=20=7B=
=0D=0A>=20>=20>=20>=20+=20=20=20time_t=20second=20=3D=20ts->tv_sec;=0D=0A>=
=20>=20>=20>=20+=20=20=20time_t=20day,=20month,=20year;=0D=0A>=20>=20>=20>=
=20+=20=20=20time_t=20ld;=20/*=20leap=20day=20*/=0D=0A>=20>=20>=0D=0A>=20>=
=20>=20Question=20for=20other=20maintainers:=20Has=20kernel=20code=20alread=
y=20time_t=0D=0A>=20>=20>=20defined=20as=2064bit?=20Or=20it=20is=20still=20=
just=2032bit=20and=2032bit=20systems=20and=0D=0A>=20>=20>=20some=20time64_t=
=20needs=20to=20be=20used?=20I=20remember=20that=20there=20was=20discussion=
=0D=0A>=20>=20>=20about=20these=20problems,=20but=20do=20not=20know=20if=20=
it=20was=20changed/fixed=20or=0D=0A>=20>=20>=20not...=20Just=20a=20pointer=
=20for=20possible=20Y2038=20problem.=20As=20=22ts=22=20is=20of=20type=0D=0A=
>=20>=20>=20timespec64,=20but=20=22second=22=20of=20type=20time_t.=0D=0A>=
=20=0D=0A>=20I=20am=20actually=20very=20close=20to=20sending=20the=20patche=
s=20to=20remove=20the=20time_t=0D=0A>=20definition=20from=20the=20kernel,=
=20at=20least=20in=20yesterday's=20version=20there=20were=20no=0D=0A>=20use=
rs.=0D=0A>=20=0D=0A>=20exfat_time_unix2fat()=20seems=20to=20be=20a=20copy=
=20of=20the=20old=20fat_time_unix2fat()=0D=0A>=20that=20we=20fixed=20a=20wh=
ile=20ago,=20please=20have=20a=20look=20at=20that=20implementation=20based=
=0D=0A>=20on=20time64_to_tm(),=20which=20avoids=20time_t.=0D=0AOkay,=20Pali=
=20reported=20it=20and=20suggested=20to=20check=20your=20patch=20in=20stagi=
ng/exfat.=0D=0AI=20will=20fix=20it=20on=20v10.=0D=0A=0D=0AThanks=20for=20yo=
ur=20review=21=0D=0A>=20=0D=0A>=20=20=20=20=20=20=20Arnd=0D=0A=0D=0A