Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     "'Arnd Bergmann'" <arnd@arndb.de>
Cc:     <linux-kernel@vger.kernel.org>,
        "'Linux FS-devel Mailing List'" <linux-fsdevel@vger.kernel.org>,
        "'gregkh'" <gregkh@linuxfoundation.org>,
        "'Valdis Kletnieks'" <valdis.kletnieks@vt.edu>,
        "'Christoph Hellwig'" <hch@lst.de>, <sj1557.seo@samsung.com>,
        <linkinjeon@gmail.com>
In-Reply-To: <CAK8P3a1wcrKzhhODwoQTu=WHorkd+dQThk+G9w77QSgJ=LnR4A@mail.gmail.com>
Subject: RE: [PATCH v8 02/13] exfat: add super block operations
Date:   Fri, 10 Jan 2020 08:36:41 +0900
Message-ID: <002001d5c745$a57b4dd0$f071e970$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQEpoQLVeCzgpkP5O8EfgqcyF1wLQwHsN8nXAH0AW2oCoNSnnqkS+JFw
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20191220062733epcas1p31665a3ae968ab8c70d91a3cddf529e73@epcas1p3.samsung.com>
        <20191220062419.23516-1-namjae.jeon@samsung.com>
        <20191220062419.23516-3-namjae.jeon@samsung.com>
        <CAK8P3a1wcrKzhhODwoQTu=WHorkd+dQThk+G9w77QSgJ=LnR4A@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> > +static int exfat_fill_super(struct super_block *sb, struct fs_context
> > +*fc) =7B
> > +       struct exfat_sb_info *sbi =3D sb->s_fs_info;
> > +       struct exfat_mount_options *opts =3D &sbi->options;
> > +       struct inode *root_inode;
> > +       int err;
> > +
> > +       if (opts->allow_utime =3D=3D (unsigned short)-1)
> > +               opts->allow_utime =3D =7Eopts->fs_dmask & 0022;
> > +
> > +       if (opts->utf8 && strcmp(opts->iocharset,
> exfat_iocharset_with_utf8)) =7B
> > +               exfat_msg(sb, KERN_WARNING,
> > +                       =22utf8 enabled, =5C=22iocharset=3D%s=5C=22 is =
recommended=22,
> > +                       exfat_iocharset_with_utf8);
> > +       =7D
> > +
> > +       if (opts->discard) =7B
> > +               struct request_queue *q =3D bdev_get_queue(sb->s_bdev);
> > +
> > +               if (=21blk_queue_discard(q))
> > +                       exfat_msg(sb, KERN_WARNING,
> > +                               =22mounting with =5C=22discard=5C=22 op=
tion, but the
> device does not support discard=22);
> > +               opts->discard =3D 0;
> > +       =7D
> > +
> > +       sb->s_flags =7C=3D SB_NODIRATIME;
> > +       sb->s_magic =3D EXFAT_SUPER_MAGIC;
> > +       sb->s_op =3D &exfat_sops;
>=20
> I don't see you set up s_time_gran, s_time_min and s_time_max anywhere.
> Please fill those to get the correct behavior. That also lets you drop th=
e
> manual truncation of the values.
Okay=21

Thanks=21
>=20
>        Arnd