Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp173059ybl; Thu, 9 Jan 2020 19:26:04 -0800 (PST) X-Google-Smtp-Source: APXvYqxC844egahaaOYXkX9dvarQ8qzWckIPzoqLvVSTRxGnbTybi/SAfz/CDmEQw/H8KsPXmhFa X-Received: by 2002:aca:503:: with SMTP id 3mr582987oif.24.1578626764123; Thu, 09 Jan 2020 19:26:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578626764; cv=none; d=google.com; s=arc-20160816; b=VjGXVJelTuAW4jT+4XbzY/JH0sK6PFAnvNgeiqnZL5OIrA3busGKzWBLf9YynNhwkd +vD+WwyTVPIT9MTSpwRhOGDiiMV66zyV7p53+xcy3lQ+jm3KXRZrUeLNWs6XF8Q4jcPY 1u3fF1VT5B6eGz9Z2+sAIiCa5tQ97eGZlPl7FJq79b2qrzkxnGCQtvCmjE1aH/1ieyI8 SataZBMT8RCCsj0hD1y+CPo39mZarJTGM/oyyNyPaE/u9YfeNNUloIBSOOWImF9BuvJn yfR+WdX2wbn00H6xZqpx5g/Fqap+6ZEaL+0HSTHoPtQBsvoT/ceyAsXAbMgxoRHC2TyI WlrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=rLf/QjKzyFFss3Mf1qSUcXhqXJRt3WjVr1A+lKgOzEo=; b=k4ieiIES9dPTpRgpW+dZbHOLIgYm5cGmYt5IPT47t0QgHTgLvrFtooJMdQb1DnyzUT d3Kp1hMG03i73RgloOA5X3ru+kFf5IghDARlLmVl8xt7cVJBFmkf/bw1qVgvcfFXi7uq +6tZz8pMrl44fAlCZlt5DByxrNBQApRsITafCuYFPcxlEKWro1Crf2RFzyLo68bSFUec kxi/YeIZANYa6wW/1//SlA1sFdptojaH6vWtg01Zbz9vYUOr4poBs1IL9tSHXIeW+3Vk uHr8LaPxeZ4XGXmFn6hNnrF6E4guOy+zVxp4sekclNKYr6G7B95NG16/QvKcVrgQCa3o at7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=V3QsRsYT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a19si306728oic.77.2020.01.09.19.25.51; Thu, 09 Jan 2020 19:26:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=V3QsRsYT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731025AbgAJDYx (ORCPT + 99 others); Thu, 9 Jan 2020 22:24:53 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:8006 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730952AbgAJDYw (ORCPT ); Thu, 9 Jan 2020 22:24:52 -0500 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 09 Jan 2020 19:24:33 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 09 Jan 2020 19:24:51 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 09 Jan 2020 19:24:51 -0800 Received: from [10.2.166.245] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 10 Jan 2020 03:24:50 +0000 Subject: Re: [PATCH v7 00/21] Move PMC clocks into Tegra PMC driver From: Sowjanya Komatineni To: Dmitry Osipenko , , , , , , , , , , , CC: , , , , , , , , , , References: <1578457515-3477-1-git-send-email-skomatineni@nvidia.com> <4e9fab30-14b5-bf1f-dc91-fd57ef614503@gmail.com> <61a78ba8-4cc3-f6a6-513b-36daa9be32f0@nvidia.com> Message-ID: <37a9676b-e0e5-7e80-5ee4-abfca361dcf7@nvidia.com> Date: Thu, 9 Jan 2020 19:24:48 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <61a78ba8-4cc3-f6a6-513b-36daa9be32f0@nvidia.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1578626673; bh=rLf/QjKzyFFss3Mf1qSUcXhqXJRt3WjVr1A+lKgOzEo=; h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=V3QsRsYTaYw2LdB5vT5bnrqmRjR4ZzgotD2Bn9TQEaaoKX6sukwXVPIOJHloTDcEx OJ4gb0zknbiJ47LX6JCBiIVV3oOVUduvOene3zZdNEwsj3Ti8iaIpzWEhXLuDBxrRu dHCOj+L/TeaNg4qvopZcXUlNyqQP5WuYXzCt+5f4iks2QZW9DIB3AJHUgrHLmOKghU UIcq6/+mgE0MFiY8rpV3NVlQmmPZhn6HZOXvKYNi7wJF01wD1lLqgnjoeR2xWrzFCC SNIoQOF8U1gIohGO9XT0FphO7rPkzb29F4QqA8RaYExQQVFNOJwGt4yEv+/4S/sOV6 XXXmF1hoKfSlw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/9/20 5:39 PM, Sowjanya Komatineni wrote: > > On 1/9/20 11:44 AM, Dmitry Osipenko wrote: >> External email: Use caution opening links or attachments >> >> >> 08.01.2020 07:24, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> This patch series moves Tegra PMC clocks from clock driver to pmc=20 >>> driver >>> along with the device trees changes and audio driver which uses one of >>> the pmc clock for audio mclk. >>> >>> Tegra PMC has clk_out_1, clk_out_2, clk_out_3 and blink controls which >>> are currently registered by Tegra clock driver using clk_regiser_mux=20 >>> and >>> clk_register_gate which performs direct Tegra PMC register access. >>> >>> When Tegra PMC is in secure mode, any access from non-secure world will >>> not go through. >>> >>> This patch series adds these Tegra PMC clocks and blink controls to=20 >>> Tegra >>> PMC driver with PMC as clock provider and removes them from Tegra clock >>> driver. >>> >>> PMC clock clk_out_1 is dedicated for audio mclk from Tegra30 thru=20 >>> Tegra210 >>> and clock driver does inital parent configuration for it and enables=20 >>> them. >>> But this clock should be taken care by audio driver as there is no need >>> to have this clock pre enabled. >>> >>> So, this series also includes patch that updates ASoC driver to take >>> care of parent configuration for mclk if device tree don't specify >>> initial parent configuration using assigned-clock-parents and controls >>> audio mclk enable/disable during ASoC machine startup and shutdown. >>> >>> DTs are also updated to use clk_out_1 as audio mclk rather than=20 >>> extern1. >>> >>> This series also includes a patch for mclk fallback to extern1 when >>> retrieving mclk fails to have this backward compatible of new DT with >>> old kernels. >> Suspend-resume doesn't work anymore, reverting this series helps. I >> don't have any other information yet, please take a look. > Thanks Dmitry. Will test suspend resume and check.. I see if we leave audio mclk (cdev1) enabled during=20 tegra_asoc_utils_init, suspend resume works. Without audio mclk enabled during tegra_asoc_utils_init, somehow it=20 prevents entry to suspend on Tegra30 platform. Will look in detail..