Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp174095ybl; Thu, 9 Jan 2020 19:27:28 -0800 (PST) X-Google-Smtp-Source: APXvYqy2d0vX6ox1yDxjJFSuBfURk723gIZvlPbi6+JLm6VEJXE/ZtJQ5zE1sv+1CPNojncqHD7o X-Received: by 2002:aca:ec50:: with SMTP id k77mr631819oih.114.1578626848698; Thu, 09 Jan 2020 19:27:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578626848; cv=none; d=google.com; s=arc-20160816; b=OFqS2J1Ytf72BC7eSmTs2fspVF6ErX8mF2wN5+RU2HxIDMBIed0gNwQVbh/pGazojP 0MmLO/37V6JQtapavoAxqcLrliBTcx/vT3lDXllIycH1RENml9T8Tf5ofE1bAQKOhDiA O2cDijQIIyXbMAMiLiX7bv0nibi9WJoPfSo0xWdYofrOwxkpWT8RrlGWlEkv56ob491f teGrY4AN0pth50qPoYNTAYxAfNOoKMggy7MpNfF0L0NHOSXyNDH8nfHi182ZceBbjvv0 a8CqNxrmpILbX4eM+1XuUDemMgzhQ/Yv6aMp+1ZqM7zFqMNVlOWg0DW3BsxQI5L1P0MM B5pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=NGhT6IgGhW8oeZXm0Cl++4YLmHWZOTuv2/nBSle9aj8=; b=Vz3z70yOKosQ7han9mhsdIZkmS1nnw5OUZxLtuEuQuIw015T3AgF8hXFEEF9ROKyE3 XL00qpRIMMplKFexOK9VNdv3xT4DzgksXC0Ggi4ng2/n91zCs2Or+LBZuaV97Ar9R7ff 4y1OYHj4sHh9z7beGcDsdK5+2I+IWg7FKFplrAZcqPoEKieJZb2pY4nt/ztpZUy9Bjoz PBH4MgIvtwiM94jvtPXP/Ro/hFlnSIwdPXeUCIXVdQgyk5QTOI++tFcZuwY7ENTKzLfQ sb0ujbjvE/bEN9WEEXyrwpRr6RhP/HUOQZQ7rJ41nMgu3u2mdRmXwlf+DeOKApRCqP5J mQ0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b10si362250otp.124.2020.01.09.19.27.16; Thu, 09 Jan 2020 19:27:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731005AbgAJD0Y (ORCPT + 99 others); Thu, 9 Jan 2020 22:26:24 -0500 Received: from mga02.intel.com ([134.134.136.20]:54125 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730965AbgAJD0Y (ORCPT ); Thu, 9 Jan 2020 22:26:24 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 19:26:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,415,1571727600"; d="scan'208";a="212113181" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga007.jf.intel.com with ESMTP; 09 Jan 2020 19:26:22 -0800 From: Wei Yang To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kirill.shutemov@linux.intel.com, Wei Yang Subject: [PATCH 1/2] mm/huge_memory.c: use head to check huge zero page Date: Fri, 10 Jan 2020 11:26:09 +0800 Message-Id: <20200110032610.26499-1-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The page could be a tail page, if this is the case, this BUG_ON will never be triggered. Fixes: e9b61f19858a ("thp: reintroduce split_huge_page()") Signed-off-by: Wei Yang --- mm/huge_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 168d8a1a9bac..90165f68cf13 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2696,7 +2696,7 @@ int split_huge_page_to_list(struct page *page, struct list_head *list) unsigned long flags; pgoff_t end; - VM_BUG_ON_PAGE(is_huge_zero_page(page), page); + VM_BUG_ON_PAGE(is_huge_zero_page(head), head); VM_BUG_ON_PAGE(!PageLocked(page), page); VM_BUG_ON_PAGE(!PageCompound(page), page); -- 2.17.1