Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp235160ybl; Thu, 9 Jan 2020 20:50:21 -0800 (PST) X-Google-Smtp-Source: APXvYqz0TSmAYfGpiAz2w3Jb4QVmnPAn816io4fkXWyiEGnW6m1wW+puf2ImLUdR5cc+u3xDnukl X-Received: by 2002:a05:6830:1e46:: with SMTP id e6mr993346otj.245.1578631821585; Thu, 09 Jan 2020 20:50:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578631821; cv=none; d=google.com; s=arc-20160816; b=dbu8aywPKzqzgVywrCT3nB50pYigeCGsj7WSY4vAOCd5xd/m+3RjihfWzHgnMqHA1L xHi3T6+SWgA3Vw0m0aVeJNMVOPXUWMTJWuwwreC83+ySQKIv11npB6Hn9v/FU1xPETO0 GH4lYsfMjgKwo/GicmIsFwjPBdffft4+fcE9ecOXn150pLO3fiDTN8cSTlyaJsH1FU+Z e3wg7Wamlsd2eAujF1+Beh8VUFXSCeppJwEMalPrDGdbC6kF/lbI8EkmFSbqiM8/mOXv KBln/xIvpLo9xVSFa0ODJ186pOVvgEd7zZ7yQghcVXO7H2W6vwfj3Uiml38KvJtHM4Pl KKGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=8DfieqTKOGiQVIPKHn2zoBAN0ntzIjzZpTKsVakM0Co=; b=ldaAW/7kSTBaH/x2+oAr9QqDlR4k+OM6b7M14lR/O6D8ILTMBAXknbXAAv46yN0cmH CCl9lqYaYLjf3NaxSK4PPSxoeYLNLhggzPipkC6tXjb12oD/u5tQswCD2u2ONd1ldjmu P6R30pY3huAdrggLlsZmCv1DrgUCd60sxfW0qafFz4vs2qX1voFwfT1X7MxVTJ+OqSZO 6KyZAIROWBdCsHaqrG+eNUBxnJHLrlEpvkjzwLZRJMYJCpxgf75NTV5W0fO1obeB1ZNN 7+BgyNXluGbRDIeHNKD9nG6AT53tEoUmy6KeOYrt/jAYnYhfGcxbhjwg+RM7nHdwz4cm vcww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=T7w4glUW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n11si433986otk.290.2020.01.09.20.50.09; Thu, 09 Jan 2020 20:50:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=T7w4glUW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731369AbgAJEsD (ORCPT + 99 others); Thu, 9 Jan 2020 23:48:03 -0500 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:19726 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731312AbgAJEsD (ORCPT ); Thu, 9 Jan 2020 23:48:03 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 09 Jan 2020 20:47:12 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 09 Jan 2020 20:48:02 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 09 Jan 2020 20:48:02 -0800 Received: from [10.2.166.245] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 10 Jan 2020 04:48:01 +0000 Subject: Re: [PATCH v7 00/21] Move PMC clocks into Tegra PMC driver To: Sameer Pujar , Dmitry Osipenko , , , , , , , , , , , CC: , , , , , , , , , References: <1578457515-3477-1-git-send-email-skomatineni@nvidia.com> <4e9fab30-14b5-bf1f-dc91-fd57ef614503@gmail.com> <61a78ba8-4cc3-f6a6-513b-36daa9be32f0@nvidia.com> <37a9676b-e0e5-7e80-5ee4-abfca361dcf7@nvidia.com> <62751d2d-2b7d-509b-e236-363d2bb29b02@nvidia.com> <880b2e8a-aa55-40f3-7502-24392b88e53f@nvidia.com> <738f42e2-7135-b111-5863-1cb15aa96c18@nvidia.com> From: Sowjanya Komatineni Message-ID: Date: Thu, 9 Jan 2020 20:47:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <738f42e2-7135-b111-5863-1cb15aa96c18@nvidia.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1578631632; bh=8DfieqTKOGiQVIPKHn2zoBAN0ntzIjzZpTKsVakM0Co=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=T7w4glUW/ka4Ay99Yub6MFpdgQgnZ+6eSGbOaHbgPb7enuADk1MVFErMSmGxT8I4S ao64ZmxEznjCmdqZtnhq2osKEQJD01N2gxRWDzBbQFKIRsD0qD6vFjrH338+dHkKDk 4fPtRDpvQ4m9YOl1Fjb3wa84fT36nu0fBFv04LsQXFW3essmw2PyGgPmKeOSZ4gOIf D8NgY5fUlf+SFkDFfpHF3h+HxNFs+erSL1o9r1TqSQoA/Vx2XXKsY8s9Tbdp62REqw HzleM95At+/mSN3gawBkpxtprB7p6Y0e1u/ePSO/F743xIYt0F1grYu23f+5YMZ7sW UrOYdoo7E4+dQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/9/20 8:43 PM, Sameer Pujar wrote: > External email: Use caution opening links or attachments > > > On 1/10/2020 10:06 AM, Sowjanya Komatineni wrote: >> >> On 1/9/20 7:32 PM, Sowjanya Komatineni wrote: >>> >>> On 1/9/20 7:24 PM, Sowjanya Komatineni wrote: >>>> >>>> On 1/9/20 5:39 PM, Sowjanya Komatineni wrote: >>>>> >>>>> On 1/9/20 11:44 AM, Dmitry Osipenko wrote: >>>>>> External email: Use caution opening links or attachments >>>>>> >>>>>> >>>>>> 08.01.2020 07:24, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82= : >>>>>>> This patch series moves Tegra PMC clocks from clock driver to pmc >>>>>>> driver >>>>>>> along with the device trees changes and audio driver which uses >>>>>>> one of >>>>>>> the pmc clock for audio mclk. >>>>>>> >>>>>>> Tegra PMC has clk_out_1, clk_out_2, clk_out_3 and blink controls >>>>>>> which >>>>>>> are currently registered by Tegra clock driver using >>>>>>> clk_regiser_mux and >>>>>>> clk_register_gate which performs direct Tegra PMC register access. >>>>>>> >>>>>>> When Tegra PMC is in secure mode, any access from non-secure >>>>>>> world will >>>>>>> not go through. >>>>>>> >>>>>>> This patch series adds these Tegra PMC clocks and blink controls >>>>>>> to Tegra >>>>>>> PMC driver with PMC as clock provider and removes them from Tegra >>>>>>> clock >>>>>>> driver. >>>>>>> >>>>>>> PMC clock clk_out_1 is dedicated for audio mclk from Tegra30 thru >>>>>>> Tegra210 >>>>>>> and clock driver does inital parent configuration for it and >>>>>>> enables them. >>>>>>> But this clock should be taken care by audio driver as there is >>>>>>> no need >>>>>>> to have this clock pre enabled. >>>>>>> >>>>>>> So, this series also includes patch that updates ASoC driver to=20 >>>>>>> take >>>>>>> care of parent configuration for mclk if device tree don't specify >>>>>>> initial parent configuration using assigned-clock-parents and >>>>>>> controls >>>>>>> audio mclk enable/disable during ASoC machine startup and shutdown. >>>>>>> >>>>>>> DTs are also updated to use clk_out_1 as audio mclk rather than >>>>>>> extern1. >>>>>>> >>>>>>> This series also includes a patch for mclk fallback to extern1 when >>>>>>> retrieving mclk fails to have this backward compatible of new DT >>>>>>> with >>>>>>> old kernels. >>>>>> Suspend-resume doesn't work anymore, reverting this series helps. I >>>>>> don't have any other information yet, please take a look. >>>>> Thanks Dmitry. Will test suspend resume and check.. >>>> >>>> I see if we leave audio mclk (cdev1) enabled during >>>> tegra_asoc_utils_init, suspend resume works. >>>> >>>> Without audio mclk enabled during tegra_asoc_utils_init, somehow it >>>> prevents entry to suspend on Tegra30 platform. >>>> >>>> Will look in detail.. >>>> >>> audio mclk is only needed for audio and werid that having it not >>> enabled all the time like in current clock driver prevents suspend >>> entry on Tegra30 >>> >>> Looks like this issue is masked earlier with having mclk enabled all >>> the time by clock driver. >>> >> On linux-next without this patch series, I just disabled mclk to be >> enabled all the time (removed set_rate from utils_init) and also >> disabled default enable from clock driver. >> >> So somehow disabling mclk is preventing suspend entry. > > This is strange. > >> >> Probably debugging suspend issue on Tegra30 when audio mclk is >> disabled can be done separately and will keep audio mclk enabled in >> asoc_utils_init with comment mentioning this issue and fix as TBD to >> move on with PMC clock fixes. > > Sounds fine with me as the suspend/resume issue is not introduced in the > current series. It can be addressed separately. > >> Thanks Sameer. So, will keep mclk not enabled in clock driver but will=20 do mclk enable in asoc_utils_init and will remove machine startup and=20 shutdown. mclk dependency with suspend/resume and I2S and audio clocks proper=20 handling in audio driver can be taken care separately out of this series. Dimitry, I hope you too agree with this. >> >>