Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp310619ybl; Thu, 9 Jan 2020 22:26:47 -0800 (PST) X-Google-Smtp-Source: APXvYqzdvV3IfzX7YSH4NJSnY7023xvge9XjBgIRRSDTKKw+0B+Wst/HrPUloCxebC2KaNcFehna X-Received: by 2002:aca:5608:: with SMTP id k8mr1056835oib.88.1578637607798; Thu, 09 Jan 2020 22:26:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578637607; cv=none; d=google.com; s=arc-20160816; b=BEP6svL1bpu2UW1GngYcAYnNmE07yWlEhxTnUqSdzYq0TNxTKuiOYt+1gNLiMcWAvt UKtDs5TD694F3xgCtMRLoXaXlsLKKeS7UXXcXMbbk69uXdedn8zHGjJM4rpXH3yp3MAX XvIaXrtKy740KwhE0B6nEnme4nh2797EzpLL6xkkiFVkaF7yk2vAbeRPjtAx2RnlXl6n aNXMSTN8sx2bmu4VDiZ5oLOtK1AwSgF+0UnWt2y8riJEwb4pc5vr6lNI35IE5mKlhdiJ uMZADWpYe0rdf6czGS+DjdYHNj1RGvZdKwQA7tNeVfzFjx94qWcuVJh7puo2Qxh3Uamx pjZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=veoc8SAh5raYubqVF2DcuEKl3hDl1XkW9HHOfqTTJEk=; b=r1Ostel2oQwDTxajYxOA+sTcXj76CnS3IxL3VqHN+YItQN8Cz6gjtU2Upid4A+hTXx 5rXN13vtmkc5irl2cLnOufqYBhsimlrC+Q7KFJ4iJbQcHDDSjoPWESvo2v3F4UNkYNRL oArP9FBsJZc1+2MMDfqQVQK+JrLnpGUYvSPZMaIz3U3VPd1D/AiU1X0FLUDPn0x0ycD4 HsKQGOL9CbiYbbJhQtiiu13xQUluEKJ5Y7JGgUMupKVBoD44+9d8SjywMODumQxwZbiM 3Vh3OpKor/ZJ7q2b4iQiUx2VV++xSb8YWLlHk8ajxr2JNuVi4vzeJTIaVAcXrejANFBW DF9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=pYopxm+d; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w6si643956oti.4.2020.01.09.22.26.36; Thu, 09 Jan 2020 22:26:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=pYopxm+d; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731537AbgAJGZp (ORCPT + 99 others); Fri, 10 Jan 2020 01:25:45 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:37710 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731492AbgAJGZo (ORCPT ); Fri, 10 Jan 2020 01:25:44 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00A6NNub074168; Fri, 10 Jan 2020 06:25:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=veoc8SAh5raYubqVF2DcuEKl3hDl1XkW9HHOfqTTJEk=; b=pYopxm+dSg8/FOaCPFQiyESvQ2St+k9FEDnnfvOUWS2cc5lzd5MpqcZRq67Q1Xaxny21 fVKsT6HUQfdhDn3OEvP6TBjUZeHetCKqTKhn6aSQBjbFpejAMkUfXH+TdejRnAfoQ7a6 RQc+RkeYL4cfqsa+/z7Z6sZA5BTiXfL0I3JJfAsPPdOYGqTUA0Hi16wVUxPkfvCx6ssc hCo+0W09HlgBQVNlEssMUBdacd768jT59KxNqdf6dv657Q2NtHV0W5zSIh4131WgFfbm NHrxLVCcSOp7UC7lyQxw7viHTrgKetJQ1Onk6VbM3hN7qICyfPGPOAXigtFK5x+1NNKw GQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2xajnqfxk8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 10 Jan 2020 06:25:26 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00A6Ntpi161701; Fri, 10 Jan 2020 06:25:25 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 2xekku9auh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 10 Jan 2020 06:25:25 +0000 Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 00A6PN9o002659; Fri, 10 Jan 2020 06:25:23 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 09 Jan 2020 22:25:23 -0800 To: Stanley Chu Cc: , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 1/2] scsi: ufs: pass device information to apply_dev_quirks From: "Martin K. Petersen" Organization: Oracle Corporation References: <1578270431-9873-1-git-send-email-stanley.chu@mediatek.com> <1578270431-9873-2-git-send-email-stanley.chu@mediatek.com> Date: Fri, 10 Jan 2020 01:25:19 -0500 In-Reply-To: <1578270431-9873-2-git-send-email-stanley.chu@mediatek.com> (Stanley Chu's message of "Mon, 6 Jan 2020 08:27:10 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9495 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001100053 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9495 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001100053 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stanley, > Pass UFS device information to vendor-specific variant callback > "apply_dev_quirks" because some platform vendors need to know such > information to apply special handlings or quirks in specific devices. This doesn't compile. You missed adding the additional argument to one caller of ufshcd_tune_unipro_params(). -- Martin K. Petersen Oracle Linux Engineering