Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp386217ybl; Fri, 10 Jan 2020 00:04:50 -0800 (PST) X-Google-Smtp-Source: APXvYqy+ryHFUGikpjgE0614hp95rCdeji2oeuU0tfdHRqW2f38jWXgmdF3csTul9knWMweL3S1R X-Received: by 2002:a05:6808:10d:: with SMTP id b13mr1291215oie.69.1578643490419; Fri, 10 Jan 2020 00:04:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578643490; cv=none; d=google.com; s=arc-20160816; b=ysG0IrOloES5G6WCVRSpVi8h9LRUMrvjowmXYdsbCTrh0SHUMT4UU0Z6Aguqn6jlw9 eHKmBTssvbwqAB+rSrYh+ZxtRkyO+/Y2alYzSRkHKqIni2HwztpWxaVVpnqIWKlmWV/k p9KBJm35Jtxjm6n9IH+KdS/T42mT0EDguUzMZyQJl6EMcvK1zFvlzSUB8//fvL+2tdnb UF5gpJjW1tM6dyEhq/Xg6BczyBDZrFfIVlc6bHLS5I0CABRyNi40KwtCEwi3jwUeiowo HRT/PmDjWDlxElWqWH4qc1DiFri5L5fYiNuL8nH4tv/fF308rlBm8/yjUYxa2igEb3vu cOzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=5qp4CHhlcOp/knCNQWkGJpGnkD8MjSD6GIAPzB1bDyI=; b=ilIK1vJuwGpvjBYWHcNeCEferhfNoypMCe19HU3Ql1cYYcuGIbL8faI4VTfd5Ci17B Gxa7uTzP0i7UUECfTqIWgqeGRNv5Sbik3p3NGJrndnJwiQWINkv9ystQn5fZmBXW0H7T 1wrJkrVh8RJAjOIrQ9g4sxZWZGeAy3E+2eh42ZL+JX9mUxceeO5hYJ2M23YDCDRVpbKr wKbatSTbNmCtVdSryZeT85y8LwNIOm7AkJASrYxlT1yneL/Bx+TAx0dene55JUwrj/Ao mYH8vD2qho2k+QTyvGV7emHzGnmbuSGJrb+GTI51ymsvVBPN32PILYqJXnHCJf+iH/G9 Aieg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i5si635157oif.211.2020.01.10.00.04.39; Fri, 10 Jan 2020 00:04:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbgAJICY (ORCPT + 99 others); Fri, 10 Jan 2020 03:02:24 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:42382 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726401AbgAJICX (ORCPT ); Fri, 10 Jan 2020 03:02:23 -0500 Received: from 61-220-137-37.hinet-ip.hinet.net ([61.220.137.37] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ippFL-0003l1-Md; Fri, 10 Jan 2020 08:02:20 +0000 From: Kai-Heng Feng To: mathias.nyman@intel.com, gregkh@linuxfoundation.org, stern@rowland.harvard.edu Cc: acelan.kao@canonical.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kai-Heng Feng Subject: [PATCH v2 3/3] USB: Disable LPM on WD19's Realtek Hub Date: Fri, 10 Jan 2020 16:02:11 +0800 Message-Id: <20200110080211.22626-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200103084008.3579-3-kai.heng.feng@canonical.com> References: <20200103084008.3579-3-kai.heng.feng@canonical.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Realtek Hub (0bda:0x0487) used in Dell Dock WD19 sometimes drops off the bus when bringing underlying ports from U3 to U0. Disabling LPM on the hub during setting link state is not enough, so let's disable LPM completely for this hub. Signed-off-by: Kai-Heng Feng --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 6b6413073584..2fb7c1602280 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -371,6 +371,9 @@ static const struct usb_device_id usb_quirk_list[] = { { USB_DEVICE(0x0b05, 0x17e0), .driver_info = USB_QUIRK_IGNORE_REMOTE_WAKEUP }, + /* Realtek hub in Dell WD19 (Type-C) */ + { USB_DEVICE(0x0bda, 0x0487), .driver_info = USB_QUIRK_NO_LPM }, + /* Action Semiconductor flash disk */ { USB_DEVICE(0x10d6, 0x2200), .driver_info = USB_QUIRK_STRING_FETCH_255 }, -- 2.17.1