Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp420427ybl; Fri, 10 Jan 2020 00:43:45 -0800 (PST) X-Google-Smtp-Source: APXvYqyt9XFTUaf0FXSZi3caBf0Q8Am7nZ08BqZQrV1/oqCaB1aSTJMeuRVXWgQc1MYpbbTSuCa+ X-Received: by 2002:a9d:5c1:: with SMTP id 59mr1706620otd.192.1578645825716; Fri, 10 Jan 2020 00:43:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578645825; cv=none; d=google.com; s=arc-20160816; b=zg3zHdRpfjkCgWTL8gqYtmqsNKE1GSKJncAEIgFuLWXw/wd2k3YqppzJ35bagCykRC HW9KKVSZ7VIWTeeyIO72GchiILAz3o8BASq8biAv63xhYgKntWrvMWJmQYF3AluZpUMp 01Sd4gkhrZ9vAUQVDEZiOmgjTBPDhoQ+uM4Uf+rT/07PXXoArI0G6bpLdGLdQRd/TLbA NcYH9PTCtNjpaHEqpUshlZWKprchl9RrVTKrUpAl4dGoH73W43nY5v6hSFwT9pIkyNv1 oC+gdD4kwWv4rwzPbjYqhZMAV+pGez9TfP284e6TgYVv8bT9/QCmnJ+Xq6GkdMrp5LIs jQqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :dkim-signature; bh=gQqfqC2etu189jenNZ6smo7ZdLJyVqWwLgkcGWY8zXo=; b=TNvm4/mo9ETx12utGiyLpx9lksyOFnkDSGAPQyMa52ROb+D2gkUJ25hKM2OPJsSsqQ iPaSqsJ0wTqz3brUetmnkqMDJXHrcRnR52zQ3fyBWYPPwTBlhwt/skY2rSy0Eq4+XGg+ jD3EpN3Oxr+pRRHSNNu9dJfXqa3ZHxeq0bH850xu+Jd7x3P14ar92KL1x56eBI33ezAK bGLXfGLtCQUNvmcd7nMS5iqCz9PfayE9GG6a+o5DW4fnSrZ6i4LRpn2umuV4w7NRNn/Z HvhM7wQ8OVgl3MeTfs8idp3jf9Em8qKRGzShC9wonBbfuTPoeddhEF9UfUIDPiF3gp4l u46w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=efWQ3Uvl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k7si834897otp.22.2020.01.10.00.43.33; Fri, 10 Jan 2020 00:43:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=efWQ3Uvl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727110AbgAJImg (ORCPT + 99 others); Fri, 10 Jan 2020 03:42:36 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:41400 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727082AbgAJImg (ORCPT ); Fri, 10 Jan 2020 03:42:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578645754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gQqfqC2etu189jenNZ6smo7ZdLJyVqWwLgkcGWY8zXo=; b=efWQ3UvlSLS48WQivW2D2EjIxkFeo7B/FsNBQDs4cDlIO2dXZKOBB2hW0egByW+pDZPDJi ZUtrhIp7Ra/Pp26N0fcgfybk/2gv2h5ZqZKHhkvcq1/syw/E8w7u3gfgDQtw0XrjJHelnl V07d4A4hNWn4BUwBIXuha+9e0fZI5O4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-430-pBp6NOorPlatpy93jjo-Ig-1; Fri, 10 Jan 2020 03:42:31 -0500 X-MC-Unique: pBp6NOorPlatpy93jjo-Ig-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9B06E64A80; Fri, 10 Jan 2020 08:42:27 +0000 (UTC) Received: from [10.36.117.139] (ovpn-117-139.ams2.redhat.com [10.36.117.139]) by smtp.corp.redhat.com (Postfix) with ESMTP id CC32760C88; Fri, 10 Jan 2020 08:42:22 +0000 (UTC) Subject: Re: [PATCH V11 1/5] mm/hotplug: Introduce arch callback validating the hot remove range To: Anshuman Khandual , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, catalin.marinas@arm.com, will@kernel.org Cc: mark.rutland@arm.com, cai@lca.pw, logang@deltatee.com, cpandya@codeaurora.org, arunks@codeaurora.org, dan.j.williams@intel.com, mgorman@techsingularity.net, osalvador@suse.de, ard.biesheuvel@arm.com, steve.capper@arm.com, broonie@kernel.org, valentin.schneider@arm.com, Robin.Murphy@arm.com, steven.price@arm.com, suzuki.poulose@arm.com, ira.weiny@intel.com References: <1578625755-11792-1-git-send-email-anshuman.khandual@arm.com> <1578625755-11792-2-git-send-email-anshuman.khandual@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMFCQlmAYAGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl3pImkCGQEACgkQTd4Q 9wD/g1o+VA//SFvIHUAvul05u6wKv/pIR6aICPdpF9EIgEU448g+7FfDgQwcEny1pbEzAmiw zAXIQ9H0NZh96lcq+yDLtONnXk/bEYWHHUA014A1wqcYNRY8RvY1+eVHb0uu0KYQoXkzvu+s Dncuguk470XPnscL27hs8PgOP6QjG4jt75K2LfZ0eAqTOUCZTJxA8A7E9+XTYuU0hs7QVrWJ jQdFxQbRMrYz7uP8KmTK9/Cnvqehgl4EzyRaZppshruKMeyheBgvgJd5On1wWq4ZUV5PFM4x II3QbD3EJfWbaJMR55jI9dMFa+vK7MFz3rhWOkEx/QR959lfdRSTXdxs8V3zDvChcmRVGN8U Vo93d1YNtWnA9w6oCW1dnDZ4kgQZZSBIjp6iHcA08apzh7DPi08jL7M9UQByeYGr8KuR4i6e RZI6xhlZerUScVzn35ONwOC91VdYiQgjemiVLq1WDDZ3B7DIzUZ4RQTOaIWdtXBWb8zWakt/ ztGhsx0e39Gvt3391O1PgcA7ilhvqrBPemJrlb9xSPPRbaNAW39P8ws/UJnzSJqnHMVxbRZC Am4add/SM+OCP0w3xYss1jy9T+XdZa0lhUvJfLy7tNcjVG/sxkBXOaSC24MFPuwnoC9WvCVQ ZBxouph3kqc4Dt5X1EeXVLeba+466P1fe1rC8MbcwDkoUo65Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAiUEGAECAA8FAlXLn5ECGwwFCQlmAYAACgkQTd4Q 9wD/g1qA6w/+M+ggFv+JdVsz5+ZIc6MSyGUozASX+bmIuPeIecc9UsFRatc91LuJCKMkD9Uv GOcWSeFpLrSGRQ1Z7EMzFVU//qVs6uzhsNk0RYMyS0B6oloW3FpyQ+zOVylFWQCzoyyf227y GW8HnXunJSC+4PtlL2AY4yZjAVAPLK2l6mhgClVXTQ/S7cBoTQKP+jvVJOoYkpnFxWE9pn4t H5QIFk7Ip8TKr5k3fXVWk4lnUi9MTF/5L/mWqdyIO1s7cjharQCstfWCzWrVeVctpVoDfJWp 4LwTuQ5yEM2KcPeElLg5fR7WB2zH97oI6/Ko2DlovmfQqXh9xWozQt0iGy5tWzh6I0JrlcxJ ileZWLccC4XKD1037Hy2FLAjzfoWgwBLA6ULu0exOOdIa58H4PsXtkFPrUF980EEibUp0zFz GotRVekFAceUaRvAj7dh76cToeZkfsjAvBVb4COXuhgX6N4pofgNkW2AtgYu1nUsPAo+NftU CxrhjHtLn4QEBpkbErnXQyMjHpIatlYGutVMS91XTQXYydCh5crMPs7hYVsvnmGHIaB9ZMfB njnuI31KBiLUks+paRkHQlFcgS2N3gkRBzH7xSZ+t7Re3jvXdXEzKBbQ+dC3lpJB0wPnyMcX FOTT3aZT7IgePkt5iC/BKBk3hqKteTnJFeVIT7EC+a6YUFg= Organization: Red Hat GmbH Message-ID: <80ab5f55-77ef-4719-52fc-2b23c0ecb866@redhat.com> Date: Fri, 10 Jan 2020 09:42:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <1578625755-11792-2-git-send-email-anshuman.khandual@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.01.20 04:09, Anshuman Khandual wrote: > Currently there are two interfaces to initiate memory range hot removal= i.e > remove_memory() and __remove_memory() which then calls try_remove_memor= y(). > Platform gets called with arch_remove_memory() to tear down required ke= rnel > page tables and other arch specific procedures. But there are platforms > like arm64 which might want to prevent removal of certain specific memo= ry > ranges irrespective of their present usage or movability properties. Why? Is this only relevant for boot memory? I hope so, otherwise the arch code needs fixing IMHO. If it's only boot memory, we should disallow offlining instead via a memory notifier - much cleaner. >=20 > Current arch call back arch_remove_memory() is too late in the process = to > abort memory hot removal as memory block devices and firmware memory ma= p > entries would have already been removed. Platforms should be able to ab= ort > the process before taking the mem_hotplug_lock with mem_hotplug_begin()= . > This essentially requires a new arch callback for memory range validati= on. I somewhat dislike this very much. Memory removal should never fail if used sanely. See e.g., __remove_memory(), it will BUG() whenever something like that would strike. >=20 > This differentiates memory range validation between memory hot add and = hot > remove paths before carving out a new helper check_hotremove_memory_ran= ge() > which incorporates a new arch callback. This call back provides platfor= ms > an opportunity to refuse memory removal at the very onset. In future th= e > same principle can be extended for memory hot add path if required. >=20 > Platforms can choose to override this callback in order to reject speci= fic > memory ranges from removal or can just fallback to a default implementa= tion > which allows removal of all memory ranges. I suspect we want really want to disallow offlining instead. E.g., I remember s390x does that with certain areas needed for dumping/kexec. Somebody who added memory via add_memory() should always be able to remove the memory via remove_memory() again. Only boot memory can be treated in a special way, but boot memory is initially always online. --=20 Thanks, David / dhildenb