Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp484180ybl; Fri, 10 Jan 2020 01:54:30 -0800 (PST) X-Google-Smtp-Source: APXvYqy2765AjqX9+9dKEhC60gduCM9wuDGp94WeVBmZhOGvVRDzvGLbPtssMPVyrVoXq745ElaW X-Received: by 2002:a9d:6396:: with SMTP id w22mr1896339otk.364.1578650070435; Fri, 10 Jan 2020 01:54:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578650070; cv=none; d=google.com; s=arc-20160816; b=uEvGRGiO8B778dyk04veJJNlYVsA6nBBxdMMzPtwBuuhKwK9DzYNskpGyDIeOnxdv9 R5xjw/K9lELs5+4Dt4sKqer/gBM75peIXabQlWmfrc8+ok/sJEkrR3zUSON2/Kpi2hzn ieexsmdOKJ8vPKjfqBxceqoEE/ZIAgWdlX1c7lCTqEBWVG0xuG8Pn+jB1bCH5l42imoS 5rOgWDwZ535K7cl/YJGg23hjMbAwIHlVpft14ZlridsHBoBCxtZXhbaiBxDYIP7WPJOk gI+CyBB2u1DxQ3A5vBvR60WE+BOto2fwlFS0WGfzWPttR2zOO5ZwZWXbDhz56wPX0JTp m1Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5epvbT5Q+4YBNi/Ruaz9zmEaYwVUahV3ncN16fuSWvw=; b=QGpFQyN2/+aGs5QPnH662VMoL91ATjtWCbkRRLf9UqH3AA/9CJE1F1Dt6dU0iSFCQe TbCJLtFXizD4dkIrdcZPhd52fpf43pcn0sLONb953uGi6R6RD+fDwoyJZohPRpx35GJR xBwya1B6a/ze6VzWVIQ/2CblQuWDNharCZYFTOY40Mpp0Y0FTWgnaCGXpieQE7r4do+O TVHnG+z66/2OTTAv2tB7weVHPlxYp900F1V3qxEZxxlfJaPPklmSC9Eh+tvUQFUQCWZX nlJnBu4FF4K09xoFFiWI94q2Y48PAh+zeavQWvc9SqxitY/zqh/Pccalqf26DPg8szuA qS+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=iZW6arOx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6si914401otq.41.2020.01.10.01.54.18; Fri, 10 Jan 2020 01:54:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=iZW6arOx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727415AbgAJJwr (ORCPT + 99 others); Fri, 10 Jan 2020 04:52:47 -0500 Received: from mail.skyhub.de ([5.9.137.197]:33866 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727169AbgAJJwr (ORCPT ); Fri, 10 Jan 2020 04:52:47 -0500 Received: from zn.tnic (p200300EC2F0ACA0024F85FB92EE88C9E.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:ca00:24f8:5fb9:2ee8:8c9e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 53CDB1EC0CAD; Fri, 10 Jan 2020 10:52:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1578649966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=5epvbT5Q+4YBNi/Ruaz9zmEaYwVUahV3ncN16fuSWvw=; b=iZW6arOxsEahhXS7L0+rc1bHejr5o7mneglg4DIhJUw0XHb+j+g6lJ+5mIfqzY0YQFdWJQ lFaXS2LMFTfqJg6dvxIgDlJOonwWTOZF6wubQ7nkabAZ7sJfN6JjIaTCm5wLJYGZ186yI3 j7L5VU3qdJYEzCSTc0xocL+LX+jmI+U= Date: Fri, 10 Jan 2020 10:52:43 +0100 From: Borislav Petkov To: Zhenzhong Duan Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Dave Hansen , "Rafael J. Wysocki" Subject: Re: [PATCH] x86/boot/KASLR: Fix unused variable warning Message-ID: <20200110095243.GE19453@zn.tnic> References: <20200110094304.446-1-zhenzhong.duan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200110094304.446-1-zhenzhong.duan@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 10, 2020 at 05:43:04PM +0800, Zhenzhong Duan wrote: > Local variable 'i' is referenced only when CONFIG_MEMORY_HOTREMOVE and > CONFIG_ACPI are defined, but definition of variable 'i' is out of guard. > If any of the two macros is undefined, below warning triggers during > build with 'make EXTRA_CFLAGS=-Wall binrpm-pkg', fix it by moving 'i' > in the guard. Maybe I wasn't clear: save this patch for when it triggers in the normal build, without additional build flags. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette