Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp571423ybl; Fri, 10 Jan 2020 03:18:50 -0800 (PST) X-Google-Smtp-Source: APXvYqwyBsu46Cuil4sDVyniHtKsWFR/ZI86CkruFYaHjRQXUqrFgdE8cI2TcuaHEQRHyKKCHlp8 X-Received: by 2002:a05:6830:1e99:: with SMTP id n25mr2182910otr.67.1578655130321; Fri, 10 Jan 2020 03:18:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578655130; cv=none; d=google.com; s=arc-20160816; b=d1BMsgP8lvUa/I5Wp4foymgU3+gbk8V/QRh/CP+2NOtj/20JmcBf1V1vxuMc5KzMQW XWoWO7LoPPJM/f9zT6w1gNiLA2+uwvW5GDPUegFuCOFNP5M/PAbEEi9EajkjLdkKsR67 FdOhKCApYOBRoDsyB5RKHoykEmQorDfH7/DtGc2tdHyUc6l+vHfMg8ERTesN5EY6tyVz HWFf93M4YeFIGuy56eHrpihjFRVh+rrZ/4/Huxat5jaKpTnOR71LTblv2FPB5UkGkLXO Vy0kzI170z8dhhy7+DxxAUp7PVbztfCMAXLcM2cBsTK/qg9xEfwWJhsdTMEYW1w5HBAg SJ9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=2pD/+t4gsb8w9/wpd9kQfrpe5ditT5Y25LnUcUtMfwE=; b=dS6V0s518bwQy2OqDi5/0NFmH1qx6ytMYx6FeogD+NOkziPs8SowRU5n6f4TOgm7aW dE9L/dLMoHLEgcwcVL9bO1ZvhroBPKAXKY0h5MfpRigWdLweZ0sUCJbFnISGltwMXPXL n5CsHkOmt5UYlrTWieABPJ4SZ6rJU9AsI2QY0zynjntmmFb0ACOZg47OLqDZY3fi7R4X /ZD7TQ8xFPd8dwiE5hK0AaOJzfwJ9eAqPu/q7xCzyxu5PtjZxIgry6KwkqVCwo4rq/Zy fTo8wz8SFp5H+cHQWtAHdkzPukVF3n1deJGprV4ZLu4mJHNWFrXzodfKZ8Aly3OeEUSj A5oQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6si1109352oth.26.2020.01.10.03.18.39; Fri, 10 Jan 2020 03:18:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727842AbgAJLQc (ORCPT + 99 others); Fri, 10 Jan 2020 06:16:32 -0500 Received: from foss.arm.com ([217.140.110.172]:42580 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727836AbgAJLQ3 (ORCPT ); Fri, 10 Jan 2020 06:16:29 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8AF8D328; Fri, 10 Jan 2020 03:16:28 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A5BD53F703; Fri, 10 Jan 2020 03:16:27 -0800 (PST) Date: Fri, 10 Jan 2020 11:16:22 +0000 From: Sudeep Holla To: "Zengtao (B)" Cc: Linuxarm , Greg Kroah-Hartman , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Sudeep Holla Subject: Re: [PATCH] cpu-topology: Skip the exist but not possible cpu nodes Message-ID: <20200110111622.GA39451@bogus> References: <1577935489-25245-1-git-send-email-prime.zeng@hisilicon.com> <20200107144940.GA47473@bogus> <678F3D1BB717D949B966B68EAEB446ED340B8545@dggemm526-mbx.china.huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <678F3D1BB717D949B966B68EAEB446ED340B8545@dggemm526-mbx.china.huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 08, 2020 at 01:57:34AM +0000, Zengtao (B) wrote: [...] > I have the same concern, I have tried to find out some other return values > But seems not good enough. > Maybe it's better to introduce a new function to replace of_cpu_node_to_id > Any good suggestion? > No I don't have any. So please drop the extra logic, add a comment on -ENODEV return value and use it as needed. -- Regards, Sudeep