Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp599744ybl; Fri, 10 Jan 2020 03:49:07 -0800 (PST) X-Google-Smtp-Source: APXvYqwYTuqh/IuRZ1neVVlcMxBRh+q4oUpLDJk5Pkkij2qvOP6IIgIGAl9UwBO7JFm6BX87hOdF X-Received: by 2002:a05:6808:315:: with SMTP id i21mr1782801oie.139.1578656947198; Fri, 10 Jan 2020 03:49:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578656947; cv=none; d=google.com; s=arc-20160816; b=bJg4kPsiWgUSAFBPBvB8W8qwknzTGenkqGNnnfJXIiKCXpTRiATifTzujOwaRyD+uS xTPXM5Mw9QvaFwXRNNI2SeCrl8NJd5j8doVAAvbgkc3Ein4uOKGoO65hpYdwPSo7ZLKw KW3AFxos6teM1YDN3awx6s7L6B+W/bXzu1FX3uYKYPuKyxLWYb1zYY605harrkDXoMp6 PJ2txGdDFvs6erTsKWElkkj4FCaYLkHx7TyYQG6wQhH1lviKo8tphGfaWkjb+bQ+96zV A1Fe2fGkbNNbiJSPjB0WBLk6snSDeJPCx1poXigNlUv+xCYtSQEq6tm7rFOZ5Ck4p/5x vhRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:ironport-sdr :dkim-signature; bh=AvqWbnDxt2gASFgpZVTbGM5YgLVciDGpIY4x1sP+PPo=; b=BpCFBHWsAIyI3z5byPOjWwgeC4T2QrePaIfSk0Cs291t6yP7I43ZBMBlSK3vQpm216 wH6eIWsYnOM5JcORMT2ogs9JWuGy3iATNH1ECb7ltD8OTsCwnwX2xhbzzRGYHcYpO+p9 io4PNc17TrXly9Zu03r4v84YpaJOSnf5d/Pe+ZBGjyAqsAlKRTXzRWWWTMg2fzlpqxFU 7yZDjIzZi12xGkWugEaUlhnHRqwEGYgIOws8q9i1U4+lUW4vilEzSvOlbVoWpqFSnwNZ lRIo5JkmoeHxmJOm4eUWeongNGGIox8+VFfmAOlLHYiUJWtFHOK+NlAZfBJAFSWNZ/gO klzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@citrix.com header.s=securemail header.b=FvOAMMR5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=citrix.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u21si1090245otq.137.2020.01.10.03.48.55; Fri, 10 Jan 2020 03:49:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@citrix.com header.s=securemail header.b=FvOAMMR5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=citrix.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727864AbgAJLqv (ORCPT + 99 others); Fri, 10 Jan 2020 06:46:51 -0500 Received: from esa1.hc3370-68.iphmx.com ([216.71.145.142]:47619 "EHLO esa1.hc3370-68.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727457AbgAJLqu (ORCPT ); Fri, 10 Jan 2020 06:46:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1578656810; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=y9AKCGeI0refv9ETLVVTW4z3Pz3rtt3THeDYBOo2/wE=; b=FvOAMMR5f8eLTK3NxxHyu/8PopHfon3iP+5TLAgHD+W4aGusuwvSy5Wz qaj2W1BPChAdQRL0z+XPCG/N30rX0nSvmlio7RXCYD1CqbxKdYCqCWZWy WD+wxl66p38dHr72C8rBv88qv2HnQ/Lq5R+LtCA5JGdWn9qruGwNuTQAX M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=sergey.dyasli@citrix.com; spf=Pass smtp.mailfrom=sergey.dyasli@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of sergey.dyasli@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="sergey.dyasli@citrix.com"; x-sender="sergey.dyasli@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of sergey.dyasli@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="sergey.dyasli@citrix.com"; x-sender="sergey.dyasli@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="sergey.dyasli@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: uyM5kwOdR2boap5K896BuZM84UBNSBDkO98FNlQkAu1Pj8mEBmSHIJetocQa4TMSHZ5FlS1ZZ8 LQ7Ezx4Cyu7dTOA9vnCIENf0//Jq9LBonK00mllB4r9zO85tePdpm8VKBNWPtqdtrz95uK2CSm 4wNwJiYw4IV9dZU+CcLCtIYauqxKnZ2eXkLY9MyWOibSjc/+GtY9Jab+ag3z78vT2azmeSx9BQ LtSAC1vlJ2gPOsHdFGAd4MyoA0rR+e5lIIYaoRs30pVRHB2FiFLgC8bvfSky/1sdJYTgceZCE1 xzI= X-SBRS: 2.7 X-MesageID: 10896649 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,416,1571716800"; d="scan'208";a="10896649" Subject: Re: [PATCH v1 2/4] x86/xen: add basic KASAN support for PV kernel To: Boris Ostrovsky , , , , CC: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Juergen Gross , Stefano Stabellini , George Dunlap , Ross Lagerwall , Andrew Morton , "sergey.dyasli@citrix.com >> Sergey Dyasli" References: <20200108152100.7630-1-sergey.dyasli@citrix.com> <20200108152100.7630-3-sergey.dyasli@citrix.com> <5214cb54-1719-f93b-130f-90c5da31e22a@oracle.com> From: Sergey Dyasli Autocrypt: addr=sergey.dyasli@citrix.com; keydata= xsFNBFtMVHEBEADc/hZcLexrB6vGTdGqEUsYZkFGQh6Z1OO7bCtM1go1RugSMeq9tkFHQSOc 9c7W9NVQqLgn8eefikIHxgic6tGgKoIQKcPuSsnqGao2YabsTSSoeatvmO5HkR0xGaUd+M6j iqv3cD7/WL602NhphT4ucKXCz93w0TeoJ3gleLuILxmzg1gDhKtMdkZv6TngWpKgIMRfoyHQ jsVzPbTTjJl/a9Cw99vuhFuEJfzbLA80hCwhoPM+ZQGFDcG4c25GQGQFFatpbQUhNirWW5b1 r2yVOziSJsvfTLnyzEizCvU+r/Ek2Kh0eAsRFr35m2X+X3CfxKrZcePxzAf273p4nc3YIK9h cwa4ZpDksun0E2l0pIxg/pPBXTNbH+OX1I+BfWDZWlPiPxgkiKdgYPS2qv53dJ+k9x6HkuCy i61IcjXRtVgL5nPGakyOFQ+07S4HIJlw98a6NrptWOFkxDt38x87mSM7aSWp1kjyGqQTGoKB VEx5BdRS5gFdYGCQFc8KVGEWPPGdeYx9Pj2wTaweKV0qZT69lmf/P5149Pc81SRhuc0hUX9K DnYBa1iSHaDjifMsNXKzj8Y8zVm+J6DZo/D10IUxMuExvbPa/8nsertWxoDSbWcF1cyvZp9X tUEukuPoTKO4Vzg7xVNj9pbK9GPxSYcafJUgDeKEIlkn3iVIPwARAQABzShTZXJnZXkgRHlh c2xpIDxzZXJnZXkuZHlhc2xpQGNpdHJpeC5jb20+wsGlBBMBCgA4FiEEkI7HMI5EbM2FLA1L Aa+w5JvbyusFAltMVHECGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AAIQkQAa+w5JvbyusW IQSQjscwjkRszYUsDUsBr7Dkm9vK65AkEACvL+hErqbQj5yTVNqvP1rVGsXvevViglSTkHD4 9LGwEk4+ne8N4DPcqrDnyqYFd42UxTjVyoDEXEIIoy0RHWCmaspYEDX8fVmgFG3OFoeA9NAv JHssHU6B2mDAQ6M3VDmAwTw+TbXL/c1wblgGAP9kdurydZL8bevTTUh7edfnm5pwaT9HLXvl xLjz5qyt6tKEowM0xPVzCKaj3Mf/cuZFOlaWiHZ0biOPC0JeoHuz4UQTnBBUKk+n2nnn72k9 37cNeaxARwn/bxcej9QlbrrdaNGVFzjCA/CIL0KjUepowpLN0+lmYjkPgeLNYfyMXumlSNag 9qnCTh0QDsCXS/HUHPeBskAvwNpGBCkfiP/XqJ+V618ZQ1sclHa9aWNnlIR/a8xVx25t/14V R8EX/045HUpyPU8hI/yw+Fw/ugJ8W0dFzFeHU5K2tEW2W0m3ZWWWgpcBSCB17DDLIPjGX1Qc J8jiVJ7E4rfvA1JBg9BxVw5LVuXg2FB6bqnDYALfY2ydATk+ZzMUAMMilaE7/5a2RMV4TYcd 8Cf77LdgO0pB3vF6z1QmNA2IbOICtJOXpmvHj+dKFUt5hFVbvqXbuAjlrwFktbAFVGxaeIYz nQ44lQu9JqDuSH5yOytdek24Dit8SgEHGvumyj17liCG6kNzxd+2xh3uaUCA5MIALy5mZ87B TQRbTFRxARAAwqL3u/cPDA+BhU9ghtAkC+gyC5smWUL1FwTQ9CwTqcQpKt85PoaHn8sc5ctt Aj2fNT/F2vqQx/BthVOdkhj9LCwuslqBIqbri3XUyMLVV/Tf+ydzHW2AjufCowwgBguxedD1 f9Snkv+As7ZgMg/GtDqDiCWBFg9PneKvr+FPPd2WmrI8Kium4X5Zjs/a6OGUWVcIBoPpu088 z/0tlKYjTFLhoIEsf6ll4KvRQZIyGxclg3RBEuN+wgMbKppdUf2DBXYeCyrrPx809CUFzcik O99drWti2CV1gF8bnbUvfCewxwqgVKtHl2kfsm2+/lgG4CTyvnvWqUyHICZUqISdz5GidaXn TcPlsAeo2YU2NXbjwnmxzJEP/4FxgsjYIUbbxdmsK+PGre7HmGmaDZ8K77L3yHr/K7AH8mFs WUM5KiW4SnKyIQvdHkZMpvE4XrrirlZ+JI5vE043GzzpS2CGo0NFQmDJLRbpN/KQY6dkNVgA L0aDxJtAO1rXKYDSrvpL80bYyskQ4ivUa06v9SM2/bHi9bnp3Nf/fK6ErWKWmDOHWrnTgRML oQpcxoVPxw2CwyWT1069Y/CWwgnbj34+LMwMUYhPEZMitABpQE74dEtIFh0c2scm3K2QGhOP KQK3szqmXuX6MViMZLDh/B7FXLQyqwMBnZygfzZFM9vpDskAEQEAAcLBjQQYAQoAIBYhBJCO xzCORGzNhSwNSwGvsOSb28rrBQJbTFRxAhsMACEJEAGvsOSb28rrFiEEkI7HMI5EbM2FLA1L Aa+w5Jvbyuvvbg//S3d1+XL568K5BTHXaYxSqCeMqYbV9rPhEHyk+rzKtwNXSbSO8x0xZutL gYV+nkW0KMPH5Bz3I1xiRKAkiX/JLcMfx2HAXJ1Cv2rpR6bxyCGBJmuwR68uMS/gKe6AWwTY q2kt1rtZPjGl9OwVoWGJKbu2pFBLWmLAnHlXOL6WDSE1Mz2Ah3jMHOaSyAgPu1XSNa600gMJ QrSxgbe7bW72gCjeHcrIjfv+uh5cZ5/J/edpWXRuE4Tz82nxudBIHE2vnQEoJrXOh2kAJiYs G+IllDqFKDPrnS0R3DenBNG0Ir8h9W6heETnhQUc9NDFCSr81Mp0fROdBfYZnQzgSZMjN2eY pkNEWshJER4ZYY+7hAmqI51HnsKuM46QINh00jJHRMykW3TBMlwnUFxZ0gplAecjCFC7g2zj g1qNxLnxMS4wCsyEVhCkPyYnS8zuoa4ZUH37CezD01Ph4O1saln5+M4blHCEAUpZIkTGpUoi SEwtoxu6EEUYfbcjWgzJCs023hbRykZlFALoRNCwVz/FnPuVu291jn9kjvCTEeE6g2dCtOrO ukuXzk1tIeeoggsU7AJ0bzP7QOEhEckaBbP4k6ic26LJGWNMinllePyEMXzsgmMHVN//8wDT NWaanhP/JZ1v5Mfn8s1chIqC0sJIw73RvvuBkOa+jx0OwW3RFoQ= Message-ID: <76cf8b94-6f71-9f8c-0fc9-07ad4aded3be@citrix.com> Date: Fri, 10 Jan 2020 11:46:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <5214cb54-1719-f93b-130f-90c5da31e22a@oracle.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/01/2020 23:27, Boris Ostrovsky wrote: > > > On 1/8/20 10:20 AM, Sergey Dyasli wrote: >> @@ -1943,6 +1973,15 @@ void __init xen_setup_kernel_pagetable(pgd_t *pgd, unsigned long max_pfn) >>       if (i && i < pgd_index(__START_KERNEL_map)) >>           init_top_pgt[i] = ((pgd_t *)xen_start_info->pt_base)[i]; >>   +#ifdef CONFIG_KASAN >> +    /* >> +     * Copy KASAN mappings >> +     * ffffec0000000000 - fffffbffffffffff (=44 bits) kasan shadow memory (16TB) >> +     */ >> +    for (i = 0xec0 >> 3; i < 0xfc0 >> 3; i++) > > Are you referring here to  KASAN_SHADOW_START and KASAN_SHADOW_END? If so, can you use them instead? Indeed, the following macros make the code neater: #ifdef CONFIG_KASAN /* Copy KASAN mappings */ for (i = pgd_index(KASAN_SHADOW_START); i < pgd_index(KASAN_SHADOW_END); i++) init_top_pgt[i] = ((pgd_t *)xen_start_info->pt_base)[i]; #endif /* ifdef CONFIG_KASAN */ -- Thanks, Sergey