Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
To:     Vineet Gupta <Vineet.Gupta1@synopsys.com>,
        "linux-snps-arc@lists.infradead.org" 
        <linux-snps-arc@lists.infradead.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Alexey Brodkin" <Alexey.Brodkin@synopsys.com>
Subject: Re: [PATCH 3/5] ARC: handle DSP presence in HW
Thread-Topic: [PATCH 3/5] ARC: handle DSP presence in HW
Thread-Index: AQHVvOAPYx4rnqnFdEKpMFBzanlxBKfecrQAgAWYjls=
Date:   Fri, 10 Jan 2020 14:54:37 +0000
Message-ID: <BY5PR12MB403418CCC56FE9E2EA3232D2DE380@BY5PR12MB4034.namprd12.prod.outlook.com>
References: <20191227180347.3579-1-Eugeniy.Paltsev@synopsys.com>
 <20191227180347.3579-4-Eugeniy.Paltsev@synopsys.com>,<6b80df9d-d0f2-d1e1-8e4b-b65531b938d9@synopsys.com>
In-Reply-To: <6b80df9d-d0f2-d1e1-8e4b-b65531b938d9@synopsys.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: synopsys.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8458fbcd-7033-4629-937e-08d795dd03aa
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2020 14:54:37.6811
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1SalSqSMhdVr0KQ9TH7YV2WBkbN29cY5yXg9vwVwra4x80xDcO8JnE813JMvFjEsZUp+1FclQreQ5MiFHxBfKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3924
X-OriginatorOrg: synopsys.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vineet,=0A=
=0A=
>From: Vineet Gupta <vgupta@synopsys.com>=0A=
>Sent: Tuesday, January 7, 2020 04:03=0A=
>To: Eugeniy Paltsev; linux-snps-arc@lists.infradead.org=0A=
>Cc: linux-kernel@vger.kernel.org; Alexey Brodkin=0A=
>Subject: Re: [PATCH 3/5] ARC: handle DSP presence in HW=0A=
>[snip]=0A=
>> +static inline bool dsp_exist(void)=0A=
>> +{=0A=
>> +     struct bcr_generic bcr;=0A=
>> +=0A=
>> +     READ_BCR(ARC_AUX_DSP_BUILD, bcr);=0A=
>> +     return !!bcr.ver;=0A=
>=0A=
>open code these use once / one liners in the call site itself.=0A=
>=0A=
>>=0A=
>> @@ -444,6 +445,9 @@ static void arc_chk_core_config(void)=0A=
>>               /* Accumulator Low:High pair (r58:59) present if DSP MPY o=
r FPU */=0A=
>>               present =3D cpu->extn_mpy.dsp | cpu->extn.fpu_sp | cpu->ex=
tn.fpu_dp;=0A=
>>               CHK_OPT_STRICT(CONFIG_ARC_HAS_ACCL_REGS, present);=0A=
>> +=0A=
>> +             present =3D dsp_exist();=0A=
>=0A=
>Open code as suggested above.=0A=
>=0A=
>> +             CHK_OPT_STRICT(CONFIG_ARC_DSP_KERNEL, present);=0A=
>>       }=0A=
=0A=
My idea here is to encapsulate implementation of everything dsp-related in =
the=0A=
file with dsp code. So I'm even thinking about moving the config check itse=
lf=0A=
to some function like=0A=
'arc_chk_dsp_config' which will be located in dsp.x file=0A=
and call it from arc_chk_core_config in setup.c=0A=
=0A=
This requires to move config check helpers to separate file/header from the=
 setup.c=0A=
However this allows encapsulate all DSP code (and some new subsystems code =
later on) in its files instead of spread it across the arc code.=0A=
=0A=
What do you think about it? If you really dislike this idea I can drop it.=
=0A=
---=0A=
 Eugeniy Paltsev=0A=