Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191224100328.13608-1-brgl@bgdev.pl> <20191224100328.13608-2-brgl@bgdev.pl>
 <c6b69cb6-b784-0d6c-efaf-87926c20db16@linaro.org>
In-Reply-To: <c6b69cb6-b784-0d6c-efaf-87926c20db16@linaro.org>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Fri, 10 Jan 2020 18:05:14 +0100
Message-ID: <CAMpxmJWscNUgot8OuxbheSJa=GZA4q-b0JAhATBy9uqYR6EGug@mail.gmail.com>
Subject: Re: [PATCH v2 1/3] clocksource: davinci: only enable tim34 in
 periodic mode once it's initialized
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     Bartosz Golaszewski <brgl@bgdev.pl>, Sekhar Nori <nsekhar@ti.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        David Lechner <david@lechnology.com>,
        Kevin Hilman <khilman@kernel.org>,
        arm-soc <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

pt., 10 sty 2020 o 00:12 Daniel Lezcano <daniel.lezcano@linaro.org> napisa=
=C5=82(a):
>
> On 24/12/2019 11:03, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > The DM365 platform has a strange quirk (only present when using ancient
> > u-boot - mainline u-boot v2013.01 and later works fine) where if we
> > enable the second half of the timer in periodic mode before we do its
> > initialization - the time won't start flowing and we can't boot.
> >
> > When using more recent u-boot, we can enable the timer, then reinitiali=
ze
> > it and all works fine.
> >
> > I've been unable to figure out why that is, but a workaround for this
> > is straightforward - don't enable the tim34 timer in periodic mode unti=
l
> > it's properly initialized.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Why not move clockevents_config_and_register() after
> davinci_clocksource_init_tim34() is called ?

Ha! Yes, that works too. I'll send a v3 shortly.

Bart