Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp967045ybl; Fri, 10 Jan 2020 09:41:44 -0800 (PST) X-Google-Smtp-Source: APXvYqyxM2t+9A5be0aTv7VnAo87zPH0/k2npmdDMz4VeLqNu+qkF5cGbTSW7NqmhBF1qR1lY0V1 X-Received: by 2002:a9d:7a97:: with SMTP id l23mr3720588otn.34.1578678104788; Fri, 10 Jan 2020 09:41:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578678104; cv=none; d=google.com; s=arc-20160816; b=bhXX7uC8MJwYSNVmbyWESw3VtUN8DhVDvKLZejxzlxTMfwB3hPBrVMAGfPkz3OwHGi zI5U0sFm+/CDVQYfR5oEW/XrThXJznXsX60GJ2gxFdSnWjhIoOQTJBXVLh+uB9SXlIbo 8ZmXY3+/j8xa4CbT3hhLyF+lsXK/G8wWZarYr8wo/Im8fj/LG6D/ksUKpjApVqbUxnaC 8EpkyzOqwTSApWSqkabpBz/ACoXGYrpiSH0u9B5+mF4Jydxge5xaraWGrUcvohcmQpfH RQdj13qzp15VbVX7LJt9I6vyzHnE86nnHnbgZBBSGqwnhgIlplkK7JAW3e/7SwVNQp3M mrtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ISiSufKLrvrjOgdPdOXxueKY38lYSP4JkF9m8v2MCLU=; b=rgEEe/DQcHi8O+G+5rn/hT1e6WIP9OP3DLCqF8JFSfXLeyAfAjQECDNirU2cuhJO+D yVHaYQa8qfl4zhpH9F98p4eHOpPK90kqmARFU7DW+z7zcE3qQJ1DTyVOh4BCTyDICJgb HjFML+JL9MUjkt9n1wQZLg4kq92ITRXen0sVgeySxBU7XyhxZsiAli+AAm5sOqNuosgZ WAqPeIbBpP3CxzzKQhyEh5qoJ669Az7eOMKF5BUT6SaiBtfVJTHbjhG3jGldRk9oGNvP WXXdAbkuA0jq82NNc3G1g3lfHV3dxDOwQzR8w8qqt7m2fBVKB9nKQ4THPXhw5ZMjao4J wqzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1si1755384otq.322.2020.01.10.09.41.32; Fri, 10 Jan 2020 09:41:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728215AbgAJRk2 (ORCPT + 99 others); Fri, 10 Jan 2020 12:40:28 -0500 Received: from mga17.intel.com ([192.55.52.151]:47386 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727181AbgAJRk1 (ORCPT ); Fri, 10 Jan 2020 12:40:27 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2020 09:40:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,417,1571727600"; d="scan'208";a="422189094" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.202]) by fmsmga005.fm.intel.com with ESMTP; 10 Jan 2020 09:40:27 -0800 Date: Fri, 10 Jan 2020 09:40:27 -0800 From: Sean Christopherson To: Yang Weijiang Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com, jmattson@google.com, yu.c.zhang@linux.intel.com, alazar@bitdefender.com, edwin.zhai@intel.com Subject: Re: [RESEND PATCH v10 03/10] mmu: spp: Add SPP Table setup functions Message-ID: <20200110174026.GE21485@linux.intel.com> References: <20200102061319.10077-1-weijiang.yang@intel.com> <20200102061319.10077-4-weijiang.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200102061319.10077-4-weijiang.yang@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 02, 2020 at 02:13:12PM +0800, Yang Weijiang wrote: > SPPT is a 4-level paging structure similar to EPT, when SPP is > armed for target physical page, bit 61 of the corresponding > EPT entry is flaged, then SPPT is traversed with the gfn, > the leaf entry of SPPT contains the access bitmap of subpages > inside the target 4KB physical page, one bit per 128-byte subpage. > > Co-developed-by: He Chen > Signed-off-by: He Chen > Co-developed-by: Zhang Yi > Signed-off-by: Zhang Yi > Signed-off-by: Yang Weijiang > --- > arch/x86/include/asm/kvm_host.h | 5 +- > arch/x86/kvm/mmu/spp.c | 228 ++++++++++++++++++++++++++++++++ > arch/x86/kvm/mmu/spp.h | 10 ++ This patch is completely untesteable. It adds spp.c but doesn't compile it. Actually, everything up until patch 06 is untestable.