Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1013928ybl; Fri, 10 Jan 2020 10:30:38 -0800 (PST) X-Google-Smtp-Source: APXvYqxEdanJnG7rK6+FG6m3mt/bqMjHrQHUcmfEFUNAPs9YPKGWmBgruvmCB9kDQ8rEcR+YtqBN X-Received: by 2002:a9d:2de5:: with SMTP id g92mr3693767otb.217.1578681038884; Fri, 10 Jan 2020 10:30:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578681038; cv=none; d=google.com; s=arc-20160816; b=tKp5K/JaoTMRoaBmfmFZ3RA90JcUAziZ+O41ifO7LGnDjW3AED10m2PGEjfou7SEW1 1Nccw4Ri4UcDZGxqyFMWNRe8KA1HSXF1A5U3/HwTW0cakw97qENIB+bb4/ZqK6+oHInx quxFyaThAIe82blvu7omfIoSTGehynjrvcU1bHjLk8lUuKIzA4dvXRNcDa97zdXyMuqs B5oxhSN6JQ6oCMPIfRG+/wnVjRatCQfoL6mDSr7dbG/Z3gu2fVIrMaiK1cnnaBnKhIvk 1pxi4Pb2BoBH2AwurRFQLf2X/2gpy6GOWl58MnF8EE6VWjil71LysFwQUf3hPJW9hS38 tsZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=KbEDiH8hw/bHUAi5rhJ0oLprkytfVJzWkYavBlzaJSg=; b=tgJTnrA6BRLroHO+Mmv8IWSW9OiXQ/t0fDSdSBQ1KkLo308GSDvmCOWQLjJZ1dQvDD BYy1IvD8qZwPy5jvo8BGx20Tn97pFsv/yI7gxyGEWQ6iMHMsFMh/o+QFv4vwgeJGgVcO r3z6JPf8S7Cfdpstrb1i/u/gjfo6w2SZMi5Z8NP9VWC2QflmQKLHgmnDhkbTqBv6EIjy /+VcY+qwi9br7ZcALQiSyOdxbtuaAhcBcAs+B+pug9X1RIgHZbFp7YlwUWStaT6/0VFo Xy9DfEq77GAD9ZjtonUTl0139PBT4EhCmh4XqoRaEIFZjLTxsW/iKGTcrWcpaSkQGgDZ 70/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w81si1555767oig.107.2020.01.10.10.30.26; Fri, 10 Jan 2020 10:30:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728508AbgAJS3b (ORCPT + 99 others); Fri, 10 Jan 2020 13:29:31 -0500 Received: from mga04.intel.com ([192.55.52.120]:61558 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726346AbgAJS3b (ORCPT ); Fri, 10 Jan 2020 13:29:31 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2020 10:29:30 -0800 X-IronPort-AV: E=Sophos;i="5.69,418,1571727600"; d="scan'208";a="218732927" Received: from agluck-desk2.amr.corp.intel.com ([10.3.52.68]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2020 10:29:30 -0800 Date: Fri, 10 Jan 2020 10:29:29 -0800 From: "Luck, Tony" To: Chuansheng Liu Cc: linux-kernel@vger.kernel.org, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com Subject: Re: [PATCH v2] x86/mce/therm_throt: Fix the access of uninitialized therm_work Message-ID: <20200110182929.GA20511@agluck-desk2.amr.corp.intel.com> References: <20200107004116.59353-1-chuansheng.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200107004116.59353-1-chuansheng.liu@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 07, 2020 at 12:41:16AM +0000, Chuansheng Liu wrote: > In my ICL platform, it can be reproduced in several times > of reboot stress. With this fix, the system keeps alive > for more than 200 times of reboot stress. > > V2: Boris shares a good suggestion that we can moving the > interrupt unmasking at the end of therm_work initialization. > > Signed-off-by: Chuansheng Liu Looks good to me: Acked-by: Tony Luck