Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1066872ybl; Fri, 10 Jan 2020 11:28:50 -0800 (PST) X-Google-Smtp-Source: APXvYqx4xG7Ez7mR354qhtrXKkvCoyMdQmyfdRHVtHviZRF9x2Z8thcKG0BsKoj5HVxeQP44w8df X-Received: by 2002:a9d:3e16:: with SMTP id a22mr4148609otd.259.1578684530071; Fri, 10 Jan 2020 11:28:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578684530; cv=none; d=google.com; s=arc-20160816; b=Zo2T1tjvFCp3JLr/xAFXwnw4E5HeED5408cn16iKRmMGq+YSi8lwQmjIyoEDg4tgYU Bp3y2QBKfLrWN/Z70mACXsH/hNr236zpP3T+8gorMVmPTZ5zwg4YvwrlYvogC/hgHGgS wp08f5qK6z1D3x3Bn437DCW0wyb5m7qGeZe8tBF7HgOqayYMdFQJAL9gCkJCeN2hjniq WOMxNJdX2VO23kAxxJ0SQp8XKeHEQ8a+QzAPqU74sXSNO4TX0WOuRZCfSzC9b9xF+B9W ED+N9NSjceHFiLhqU6i3TcHTjm1Wgeoxxhr9su5AN6OFxMxqP69SxfXrU8lkvZxrj08b 5v5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=sae75ZyK3e+2whlKAR0Lb92A06GjomPF+U0WNJV2XUU=; b=alyQo00RcJPeKZW2lbXj9IHl+uZw12nOuj5O2ifCYW/VZs99PvmFhcyHsusIWQXeVk 31qilS/MCoN3SB+ycySqHMyVV9n+PPRKkK24A4tyX0l3HRvidPMjwW3b49/JL3gG3CPj BS0agKPyX3L7Dv/Omc1kk4SQmwz+xlE7RjugL4q/dPEDkU7HAjz+fxjkC0hJ0zp3FQcp uj/wi9GFkRqo2Jm9ksKUiFuGqli41crRLEPmEaxsQF6qauM2MaILrDXvRGsxSdh+Za7N FV6Q3SlbRgaI+JTWZPK1nNWyvFiTKxndUXbTMhigJ6Z5pf8C54faWZl11XLm6Kz+dVLz 6HnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w68si1570167oia.223.2020.01.10.11.28.38; Fri, 10 Jan 2020 11:28:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728695AbgAJT1i (ORCPT + 99 others); Fri, 10 Jan 2020 14:27:38 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:39924 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728336AbgAJT1i (ORCPT ); Fri, 10 Jan 2020 14:27:38 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0EA861577F516; Fri, 10 Jan 2020 11:27:37 -0800 (PST) Date: Fri, 10 Jan 2020 11:27:36 -0800 (PST) Message-Id: <20200110.112736.1849382588448237535.davem@davemloft.net> To: nikolay@cumulusnetworks.com Cc: horatiu.vultur@microchip.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, roopa@cumulusnetworks.com, jakub.kicinski@netronome.com, vivien.didelot@gmail.com, andrew@lunn.ch, jeffrey.t.kirsher@intel.com, olteanv@gmail.com, anirudh.venkataramanan@intel.com, dsahern@gmail.com, jiri@mellanox.com, UNGLinuxDriver@microchip.com Subject: Re: [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP) From: David Miller In-Reply-To: <6f1936e9-97e5-9502-f062-f2925c9652c9@cumulusnetworks.com> References: <20200109150640.532-1-horatiu.vultur@microchip.com> <6f1936e9-97e5-9502-f062-f2925c9652c9@cumulusnetworks.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 10 Jan 2020 11:27:37 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nikolay Aleksandrov Date: Fri, 10 Jan 2020 16:13:36 +0200 > I agree with Stephen here, IMO you have to take note of how STP has progressed > and that bringing it in the kernel was a mistake, these days mstpd has an active > community and much better support which is being extended. This looks best implemented > in user-space in my opinion with minimal kernel changes to support it. You could simply > open a packet socket with a filter and work through that, you don't need new netlink > sockets. I'm not familiar with the protocol so can't really be the judge of that, if > you present a good argument for needing a new netlink socket for these packets - then > sure, ok. With a userland implementation, what approach do you suggest for DSA/switchdev offload of this stuff?