Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1150728ybl; Fri, 10 Jan 2020 13:03:48 -0800 (PST) X-Google-Smtp-Source: APXvYqzqXS9/49Py56jb0alFrPhKIsTguZaMeX1YG4aAW7ZXpCBUm6JpWIXeZiL49gXLFY0zl/VB X-Received: by 2002:aca:110a:: with SMTP id 10mr3919328oir.130.1578690228403; Fri, 10 Jan 2020 13:03:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578690228; cv=none; d=google.com; s=arc-20160816; b=LvfOaDiwmKS/yWUf6TEpgKwCGQOogv+3NThHwO+rjJiB7YtnP1E9wtiCwAYZSfo+Nb +/aOt6lV/m62ANKWeajGfgYwqv1llrxT6k7tj70iCBbpPHtgrVOH5Tdt8sxgwoVhrv+G rVLR9yvOPV4C8YM7v+982aB0a5OncxNNaQvQKY/LFoEjGSG+OA5j3UeD5R9HGMu/qg9y fXoK2tkPPSERG2oHeFQphIrxDnWVSUF2d8wEIuaXkSzJy7q3vgUPXNlNQIYONuEXwOae L5vPk2Y8CtKzMDvl5ESiIVeICOvsD1svhkg/rhjriYzV4W2gzwU+6tWuAPSnAwcoFZ6/ Q3sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=DscpuWHCpmPvr4rJjWCNU0C+wW4iWR7q6WdgIPGNWp8=; b=JGXlM8nPh2hLRfkTHF5F5o5+7eh1XJdSoThxqCtIe0ujMGPVahZtkNfISBLalVvMqE 4VBBTGEhUYRF1M2kP/WasOz/WIMXFzmi3giIM753F++hj3ZmQKDHY7FPBry4WbxwJGZ8 g5FSE4DzxIxv/LbIQeaDS3a6dxpk/L/KNqQoqB0C/sBxarWqZPgeDiXRJDpx/mqa9Mzd 8VtGvavUTU/YLFkM0OUR4Xw3ZaYtH4I96qZLiAYq8JdqnSme5iNu0cfv6vaI7sJXgFoY lX0jHDPYDQ4Fckk7e5sprtbCttgXLgHHAK2eC8Lk8IBIqd8sQOM2vY/AAErUoKekTsWc ZUmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DZNIJtWD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t2si1986849otq.196.2020.01.10.13.03.36; Fri, 10 Jan 2020 13:03:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DZNIJtWD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726945AbgAJVCa (ORCPT + 99 others); Fri, 10 Jan 2020 16:02:30 -0500 Received: from mail-io1-f68.google.com ([209.85.166.68]:41345 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726836AbgAJVC3 (ORCPT ); Fri, 10 Jan 2020 16:02:29 -0500 Received: by mail-io1-f68.google.com with SMTP id c16so3542081ioo.8 for ; Fri, 10 Jan 2020 13:02:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DscpuWHCpmPvr4rJjWCNU0C+wW4iWR7q6WdgIPGNWp8=; b=DZNIJtWDxi/IFi9rezbRRGdt2PNteEKMx12hwXSahx8QOiYfv5QyoZqEUO/h6dY2nG HtYbN0XKSDT8rKy8m4E9XUoK3k8d4QEoCk51sSf7ZKTPnsGDS8Mif3kgP9ZNFg1K+qXk LcEY3UPe1tYogE1FsCAoO5Iz+UIzPdbrwyXfEXyetei5BsL/kj6kUWYl5fVf78wUEPDh 4mJsUUuDU2lH5qsgNRd1M2hov480V52g3r3NyOi1eRaf3yeQ6XpzBmDLzBJ7v9pT5Idt PxQfxFN8fEkEWRabStaLVCog4wNnxT8rHfjnwqaWisU+oY0x0ulS0d4iVIad737zTc4U mMbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DscpuWHCpmPvr4rJjWCNU0C+wW4iWR7q6WdgIPGNWp8=; b=c+7vm8ZWu0z5LOhh9bCMFMVIkw6L34yw1OHLFbRlVRqe+flGjXjZrKxjWstXsXEpUg gWM3WPCGZAvq6e/flRvJccDmub/fLM42YM8u3dvXlbXb/FmdtO56RWF1FUjLpz5KWTFN 1hfOuz9Ev58Fys3FP3fFE+vMZIe9vakTIP+JGisxUG+GuX8Sgw1tCD77W/6zLNN6bXCx +A9dPUSmT43qOXb5A/qbA694l4spi8MlgQzBPr9A2MBRyFkG0x2fMB5tldyimCYiEblN 3MH42+923lAF2L3f2GJRjnbv1DmwXOOA6QY3Yoyucxtjil4+IUzydW5eFqlAL2HCKs+I TDgg== X-Gm-Message-State: APjAAAXsnswSAAi0quuNPXysRjxlhKIzyhBa2owj7xT4F2hCWgLEY9J8 al04SWmxTD6LAWxaROmj2TCrzWTSkq+QXhxRqqo= X-Received: by 2002:a5d:8b96:: with SMTP id p22mr4006771iol.93.1578690149027; Fri, 10 Jan 2020 13:02:29 -0800 (PST) MIME-Version: 1.0 References: <20200110094535.23472-1-kraxel@redhat.com> In-Reply-To: From: Chia-I Wu Date: Fri, 10 Jan 2020 13:02:17 -0800 Message-ID: Subject: Re: [PATCH] drm/virtio: add missing virtio_gpu_array_lock_resv call To: Jann Horn Cc: Gerd Hoffmann , ML dri-devel , Gurchetan Singh , David Airlie , Daniel Vetter , "open list:VIRTIO GPU DRIVER" , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 10, 2020 at 6:27 AM Jann Horn wrote: > > On Fri, Jan 10, 2020 at 10:45 AM Gerd Hoffmann wrote: > > When submitting a fenced command we must lock the object reservations > > because virtio_gpu_queue_fenced_ctrl_buffer() unlocks after adding the > > fence. > > Thanks a lot! With this patch applied, my VM doesn't throw lockdep > warnings anymore. If you want, you can add: > > Tested-by: Jann Horn > > > Reported-by: Jann Horn > > Signed-off-by: Gerd Hoffmann Reviewed-by: Chia-I Wu > > --- > > drivers/gpu/drm/virtio/virtgpu_plane.c | 1 + > > 1 file changed, 1 insertion(+)