Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 11 Jan 2020 00:17:23 +0000
From:   Changbin Du <changbin.du@gmail.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     Changbin Du <changbin.du@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, hpa@zytor.com, x86@kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/nmi: remove the irqwork from long duration nmi
 handler
Message-ID: <20200111001723.4ygbhfcza2ifrpzn@mail.google.com>
References: <20200101072017.82990-1-changbin.du@gmail.com>
 <877e20bb8o.fsf@nanos.tec.linutronix.de>
 <20200109210225.GK5603@zn.tnic>
 <20200110140549.xqjhrdpxllkvqbuk@mail.google.com>
 <20200110151329.GF19453@zn.tnic>
 <20200110173449.rhr5p4lal3aul43g@mail.google.com>
 <20200110195837.GJ19453@zn.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200110195837.GJ19453@zn.tnic>
User-Agent: NeoMutt/20180716-508-7c9a6d
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jan 10, 2020 at 08:58:37PM +0100, Borislav Petkov wrote:
> On Fri, Jan 10, 2020 at 05:34:50PM +0000, Changbin Du wrote:
> > Just to move all the check code together and be a standalone function.
> > yes, this somewhat does code refining after the irqwork is removed but
> > I think it is normal.
> 
> But it makes review harder because your patch is removing irq_work,
> *nothing* in the commit message is talking about *why* you're doing
> that additional change. I'd imagine at the end of the commit message
> something like:
> 
> "While at it, repurpose the IRQ work callback into a function which
> concentrates the NMI duration checking."
> 
> This lets a reader know know why that additional change is done instead
> of going back'n'forth and having to ask you why you're doing this.
> 
> Ok?
> 
sure, and thanks for your suggestion. I will send v2 later.

> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette

-- 
Cheers,
Changbin Du