Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1329655ybl; Fri, 10 Jan 2020 16:28:01 -0800 (PST) X-Google-Smtp-Source: APXvYqz1GRQFoveFKNynA5o5VOL3VoQGMnTHOWtOCJF6Xh4pq4omgBYf+N7mXhLnRUtsqI9GXbiu X-Received: by 2002:aca:b183:: with SMTP id a125mr4570227oif.83.1578702480972; Fri, 10 Jan 2020 16:28:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578702480; cv=none; d=google.com; s=arc-20160816; b=w1Bgb/fTN+6vYRk27B/CVbBC9uUlAw16iLdul4zV8c5f7hjLBZfUVscVknmByU/Yml +T3WuJ6vGcOZQ7UlO6LujshZlBYpzIJU1iQYH0P2n907UYQNVKru73T5Rh67caMejbKf tT1dKGYkiwTEfeXwOqbz3BTlH3TaQ946V0hK5g2f7Su65yh+ZpZbnNcOu0fT04aQ3lbs cDj3RngcXV+EtJfHpjjcIHlCyZIMC50+BQcyvzjoHCdruoWldo8Aegtn0xN9GIqMMnSh t8c5hpa5R5dfprnxMtGY50Hlaw5IGgVQLoBOHyDxOIVMr/+LXkE+1DcHJ3JWXTmGwWke DL4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=UxcaaY2Ke+Y4K42xMdZnlgLPDpsSzCqwnxKiJt3NP5k=; b=aFrW+nke1fflomq2KZCIWIqeijOI331V/71DovlHLj2JgcQs8+0giwgf7FtAR8gePx jIWwTE7uKFjX1Wq3fQ7iJ8ImSYbWRMD2Zu84DL7GzGOHUGKy9pvC66T4adKd4oy4S4E9 ygjfeyIuvJRkiccKHfu1ye+9lIZLYEqEZUEM0QOWtmpQVcm/kLNU07E+iX5oAz8cjDjf uj2NlwuV2s05tPC2oIPYcWNCUH5IcPKIo4xHEsDCwb0fG0Eu2Qht4yT0oR66udWtWC7h AtkiKbzwEq7v+U14SdZiMEG12u1sUO2tL/YgMoiSGYyG1kwTMuRnSVG85eVtheNNuU1s b/6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=cQIH8N+y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o15si2350186otp.314.2020.01.10.16.27.49; Fri, 10 Jan 2020 16:28:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=cQIH8N+y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727755AbgAKAZq (ORCPT + 99 others); Fri, 10 Jan 2020 19:25:46 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:37961 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727499AbgAKAZq (ORCPT ); Fri, 10 Jan 2020 19:25:46 -0500 Received: by mail-oi1-f195.google.com with SMTP id l9so3491412oii.5 for ; Fri, 10 Jan 2020 16:25:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UxcaaY2Ke+Y4K42xMdZnlgLPDpsSzCqwnxKiJt3NP5k=; b=cQIH8N+ywBxIddBxvZs+WWxAty36Gs4wW7iMq4oORsYC2kzPJMYX5M2z/Rz2R4MJQU zRFpxqSKmsnGmfNaGHv5bNvoeJ16VLgXRLMzQX64/7Jqvwquv0fArDs+RefOp1UhUNJH mUrB/M5hAT+SOR3/G9qf8niSCFptFVUjN0PJgPzWzPoVNYyMgLHDMIm372iPTNxiZSDD awTRGdOChHnBnTec34VteGJ6RYjJh6iZf6xksgzWMA10mIebD7PrqSyRnCXR2TDGsIIM HDGQdsyZWMoSRyWtbVO/KS/G9/CnA/FFJD6KaYa2T+58s9Fo+tBYIS/Sk7sK47486Unt b8/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UxcaaY2Ke+Y4K42xMdZnlgLPDpsSzCqwnxKiJt3NP5k=; b=G/dJbhMvrRoKl2csIGoyXgeAU3Ar/vAM/cH7dDqtsj7kKWhRMkN+p5JeKStmNV7v7k DgksXB1AEaXRvAw6Tklb8HHEm3b3ViDY2J+VmM30vq5IqeFobWc9yITnzhZGj/FwYlo1 lWxiIf6C5Unqb1CUBTiD638d4zZFDc4yo3Gyy0rNlTocg5yVQzzGXaGnOKalM5wgTtHw CIpHn0mh65wEN9m4e+A16FeDwdytwG6/Av8rc+qIBiah8j9XJ+Wc+hlo9gBLatzSfnPY C4FCS5sDoGPTUvq9SZAPFMqlKEiHjfQsbxdYpV+Zoupy4+53Dm+tjIbtduw81kxlMD3n 79FQ== X-Gm-Message-State: APjAAAVFEtz615BzyhiqzMeksoDsFWTHtKKN2u/pfbdxnj4GFyzQ/j9k +iqPmMbTCz2xo1i6wXT6R2V8hnXL2nxG0YoY9AvCgg== X-Received: by 2002:a05:6808:10d:: with SMTP id b13mr4623826oie.69.1578702345240; Fri, 10 Jan 2020 16:25:45 -0800 (PST) MIME-Version: 1.0 References: <20200109202659.752357-1-guro@fb.com> <20200109202659.752357-4-guro@fb.com> In-Reply-To: <20200109202659.752357-4-guro@fb.com> From: Shakeel Butt Date: Fri, 10 Jan 2020 16:25:33 -0800 Message-ID: Subject: Re: [PATCH v2 3/6] mm: kmem: rename memcg_kmem_(un)charge() into memcg_kmem_(un)charge_page() To: Roman Gushchin Cc: Linux MM , Andrew Morton , Michal Hocko , Johannes Weiner , Vladimir Davydov , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 9, 2020 at 12:27 PM Roman Gushchin wrote: > > Rename (__)memcg_kmem_(un)charge() into (__)memcg_kmem_(un)charge_page() > to better reflect what they are actually doing: > 1) call __memcg_kmem_(un)charge_memcg() to actually charge or > uncharge the current memcg > 2) set or clear the PageKmemcg flag > > Signed-off-by: Roman Gushchin Reviewed-by: Shakeel Butt