Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 11 Jan 2020 08:30:28 GMT
From:   George Spelvin <lkml@sdf.org>
Message-Id: <202001110830.00B8USV0024843@sdf.org>
To:     samitolvanen@google.com
Subject: Re: [PATCH] lib/list_sort: fix function type mismatches
Cc:     akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com,
        keescook@chromium.org, linux-kernel@vger.kernel.org,
        linux@rasmusvillemoes.dk, lkml@sdf.org, mchehab+samsung@kernel.org,
        st5pub@yandex.ru
In-Reply-To: <20200110225602.91663-1-samitolvanen@google.com>
References: <20200110225602.91663-1-samitolvanen@google.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

>  typedef int __attribute__((nonnull(2,3))) (*cmp_func)(void *,
> -		struct list_head const *, struct list_head const *);
> +		struct list_head *, struct list_head *);

I'd prefer to leave the const there for documentation.
Does anyone object to fixing it in the other direction by *adding*
const to all the call sites?

Andy Shevchenko posted a patch last 7 October that did that.
<20191007135656.37734-1-andriy.shevchenko@linux.intel.com>

(You could also try taking a second look at why __pure doesn't work,
per AKPM's message of 16 April
<20190416154522.65aaa348161fc581181b56d9@linux-foundation.org>)