Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1741901ybl; Sat, 11 Jan 2020 01:53:48 -0800 (PST) X-Google-Smtp-Source: APXvYqwAu5rT2lv/HTT0CgQ6uH8cHrE90vMLV33MJOM+uZsUj6vxp325u9ZP6Urr+TbHmufzeZp5 X-Received: by 2002:aca:f5c1:: with SMTP id t184mr5950275oih.23.1578736428649; Sat, 11 Jan 2020 01:53:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578736428; cv=none; d=google.com; s=arc-20160816; b=cB+10tEb7wVsNDk0Hv8qCEkbpSDbM7BQepy7sqMVsq0j0z6uK6JEOPQJO7YYOqqeJG kgLZAph+nSag6+9sg9gmSbBpfmcRpIF/LWzyLqeklq8jKhd2UoSzw+Nb6YY3GTFqUdfx XBJTlYKGOy8Djd8J+yEudTT4QvlT8XF+QHKIMcEtClXs3ZAxRAifzyl7sfHIJkK3qc2j Bs0aaGGX7g/bCCaGRyVuQd2OaESRxZ/N3hBakJXkXETJ7RrrWnQ9G3F0MyI8rU2WZ/0A InK0n9ne8pF96q90M3nulaSY1fG6bKVZ0vtj2LRVN4t8++kgMn3iRA2/OeE+/QeD3+7B R9Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2B5e3GUMT9f4N0R8DLhETqdWLxD5lDk2e8ihjGeg3sI=; b=FzIaxzHGWxWZTplph3IYqPk/6L7m4AY+SX1YkmjkfnNHgxwUtnSC9ZV1iEkYzRbepe twTK2QmC1t6ZOUvoJPQi28lIJNsqJ/azdquInj0S/gSu/2eGXzwuzecAqV5vzakLJxhn Ajl3UicRlt1Iwe5xbfKzV5PVTsAX1wrzfQo7KsWNyti2RiuzYyUecpl4PEclrqLEho2C q/LPptgoBNnBkqYeR4PKDY4Iam1GF5BQsaFDS/x//tqFZHNbe8+V1HHgCHGYJwqv1CNx l+40UbfqO4ckNeEYcRvJ7IyaddD5dp3oNQEFVJeW0SyJLpiL0xmlMp2E9JPU18BTvo5r VMoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JyTMZnF5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6si3799781otj.24.2020.01.11.01.53.37; Sat, 11 Jan 2020 01:53:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JyTMZnF5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728927AbgAKJv1 (ORCPT + 99 others); Sat, 11 Jan 2020 04:51:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:34928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728818AbgAKJv0 (ORCPT ); Sat, 11 Jan 2020 04:51:26 -0500 Received: from localhost (unknown [62.119.166.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 339092082E; Sat, 11 Jan 2020 09:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578736286; bh=IUY4U44esFWbfleDsjrVa7BP0ZvlKMaCIMck05qsgsw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JyTMZnF5otCDhMUA+KG0+IUABGabiPzQ4KiCWw1DFZRuHSqDmKAncDccH2szodJmR er9w03zFpMpZOvYu+iKZIJFAp3gtZGyLyfhAbzRv2v1VRwx3kZlVYEKhGukUSVEyoD 8ZzxRtemCY+NNcRPBLucHdZGsoGzWEKDiABK9CM4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.4 05/59] scsi: iscsi: qla4xxx: fix double free in probe Date: Sat, 11 Jan 2020 10:49:14 +0100 Message-Id: <20200111094837.616117360@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200111094835.417654274@linuxfoundation.org> References: <20200111094835.417654274@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit fee92f25777789d73e1936b91472e9c4644457c8 ] On this error path we call qla4xxx_mem_free() and then the caller also calls qla4xxx_free_adapter() which calls qla4xxx_mem_free(). It leads to a couple double frees: drivers/scsi/qla4xxx/ql4_os.c:8856 qla4xxx_probe_adapter() warn: 'ha->chap_dma_pool' double freed drivers/scsi/qla4xxx/ql4_os.c:8856 qla4xxx_probe_adapter() warn: 'ha->fw_ddb_dma_pool' double freed Fixes: afaf5a2d341d ("[SCSI] Initial Commit of qla4xxx") Link: https://lore.kernel.org/r/20191203094421.hw7ex7qr3j2rbsmx@kili.mountain Signed-off-by: Dan Carpenter Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla4xxx/ql4_os.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index d220b4f691c7..f714d5f917d1 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -4285,7 +4285,6 @@ static int qla4xxx_mem_alloc(struct scsi_qla_host *ha) return QLA_SUCCESS; mem_alloc_error_exit: - qla4xxx_mem_free(ha); return QLA_ERROR; } -- 2.20.1