Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1749317ybl; Sat, 11 Jan 2020 02:03:21 -0800 (PST) X-Google-Smtp-Source: APXvYqwC1gNPeEsTmQ0oGSKqZyh24de0awKeDBnh6fH6HsfLS0XE8pzhpSnumWt59QmOXB/mZPlZ X-Received: by 2002:aca:6042:: with SMTP id u63mr5934479oib.76.1578737001745; Sat, 11 Jan 2020 02:03:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578737001; cv=none; d=google.com; s=arc-20160816; b=C5aBOCwPK6UDu2ZAOLp/hdYcoHRUvWiX24/C+52lYtRGuHiTBCKmKXDREoYy3I+3dV 1WrhnnR+aqn2PKgs544gAFdMF8QA/7a4t9w/z8KftkrsPaZBSOoNJokmGhzKaLCDF1yz fEEwftk2sb/7ykAH29xOwDoB9IkijNU79ODDuATXvQt67XAKAJpyjSxC0ShHS1Mr9ouz vhg4nrx8lWY4NhKt/miykSXnvRvGzQW2LrAcdveYgwkC8EIkNQ+9uazTYRkbMuIfuvTC oY3wPW/nuk4brbu6m8mm7xSaaPiukbZbVLTbdsnwfHij71Zmb6wr4xeCXksxE76JvRLZ SCsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GuqWO0hDG4yK5rrbmahD2jAivF2RL80VpVkvnld1oKY=; b=AL44I+gYM41SO18HDk875pPcazr3rns71gC2ilhaY8QNQitiWH9Ch40OwiVghtVYId s05l4dvQUlGi74tOxAu3sl1N1XFL1WrYF5+AJgo3MxhCCbLJdTFQjpfCdQnjin6e6mgO xKdZSqeJKO7NulG5VKy4NzAMBHwGhOzSPW2PDbAXtYp6MIW03zb8iREuXuSM++ZzYjMW /Bn5Y8nbaJ0OycyELAgLPbUCYuto78vhQ9jNHlFlmDGp1yul5G7xt7sVGiKd3Mq6Bxel IFG89mqnyMNp4dhx2BOt42JGz5lPfLSCY/jBcZQX0Zd5Xu/3jBox2wno1tQRGDdcBvPV RmTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xExCdzAI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w26si3425180otp.239.2020.01.11.02.03.10; Sat, 11 Jan 2020 02:03:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xExCdzAI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729011AbgAKKCV (ORCPT + 99 others); Sat, 11 Jan 2020 05:02:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:60692 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728888AbgAKKCV (ORCPT ); Sat, 11 Jan 2020 05:02:21 -0500 Received: from localhost (unknown [62.119.166.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9279620842; Sat, 11 Jan 2020 10:02:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578736940; bh=KFUxjOKDDuEoX/HZBQoELlfUW0gsxH8DtfLuAzv8vGc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xExCdzAIv5a+WzNvcujdQzuEYIR7/g18fRkaoiY7+0WTOVA6bSWXSgzawWBnANic1 L4caefLE6lNuoKfxv6TC5HlnjWbGnVqcanrVTQqeraXgxi90HYuhIW6osBhUc08qoC oyrf2z+6IBKTvhOg62wu1GfEwx9RMr+8ALcM4dmc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Leonard Crestez , Matthias Kaehlcke , Chanwoo Choi Subject: [PATCH 4.9 34/91] PM / devfreq: Check NULL governor in available_governors_show Date: Sat, 11 Jan 2020 10:49:27 +0100 Message-Id: <20200111094857.826488674@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200111094844.748507863@linuxfoundation.org> References: <20200111094844.748507863@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Leonard Crestez commit d68adc8f85cd757bd33c8d7b2660ad6f16f7f3dc upstream. The governor is initialized after sysfs attributes become visible so in theory the governor field can be NULL here. Fixes: bcf23c79c4e46 ("PM / devfreq: Fix available_governor sysfs") Signed-off-by: Leonard Crestez Reviewed-by: Matthias Kaehlcke Reviewed-by: Chanwoo Choi Signed-off-by: Chanwoo Choi Signed-off-by: Greg Kroah-Hartman --- drivers/devfreq/devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -982,7 +982,7 @@ static ssize_t available_governors_show( * The devfreq with immutable governor (e.g., passive) shows * only own governor. */ - if (df->governor->immutable) { + if (df->governor && df->governor->immutable) { count = scnprintf(&buf[count], DEVFREQ_NAME_LEN, "%s ", df->governor_name); /*