Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1824929ybl; Sat, 11 Jan 2020 03:36:20 -0800 (PST) X-Google-Smtp-Source: APXvYqwMVAsRGrPW/N8rPVzHc6r+Tumz9Fz1iJx56P1IfBPB6zWrISId+IUo6aZqdn57n2GfowVh X-Received: by 2002:a05:6808:1c6:: with SMTP id x6mr6067491oic.49.1578742579974; Sat, 11 Jan 2020 03:36:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578742579; cv=none; d=google.com; s=arc-20160816; b=DW2CcH6Mwtb6+wKNcCguo7bCu+ag/jXmg0x2Tc3xymI0I49rNow0XtnzeNzgoCHkIu yimfY1tc+xkA3TlIX0HwD2lnS/eIYx+CBX3cSoq8uQPS3SwV5AnKm5PT999JiKyWWrcx rVXkQVol0vWYCmE7ZHCTON5+cpf2rOWxcJF8qlZ95zXZDEqDJ/GZF40//66bv6uZ6XZz 6A7LLS4T2aiASK2t7NwcbmAvjeohNovySKlVBCL0WwXTWhXfR2NHrc9Fa31cvAtZrby2 Up0QAJ6IQTroFVnJL68Q5yRqc0NXNkW7M3cL0DZMfovM1A78gZK6WlPjHzthxSljXIpI JqZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ObJEzVqWOx+J5ZePMtw750klk+Ck7KaBPN5zQLHBW3g=; b=J77Jo8+DaC8MekX+hOI5YP4eysKVqI2eMsb3QOmac5VBXcvTVJI1vorFlioGkBn0mb YlUpWDbsSrL92Ykh7pXgGsWmRPfzX35aMudRNbRaAbDDZUml0EGxCl8mV8s02OKehuBQ ArxTLF8wDIE/MD5QMZYngEMiP8QwtYs6A/vmwkaHp9CEl2R+nkrkevv+y7b26GcfP7r8 8GQ/AHtYyLDK4bV22DPNJ3qhJ2MP/kRTJ2jMEHN1sEnQi7XRcY3N1xdD2p6474W6eS31 HkmB299edKEazG/fxMWNkzR/CMlyDleweXEIGGArsK0WBkMK+2+HxBfqVFTDLu7dTECX gMQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w1si3168000oia.169.2020.01.11.03.36.08; Sat, 11 Jan 2020 03:36:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729606AbgAKLeT (ORCPT + 99 others); Sat, 11 Jan 2020 06:34:19 -0500 Received: from gate.crashing.org ([63.228.1.57]:50325 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729006AbgAKLeS (ORCPT ); Sat, 11 Jan 2020 06:34:18 -0500 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 00BBXTQb023225; Sat, 11 Jan 2020 05:33:29 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 00BBXSxW023224; Sat, 11 Jan 2020 05:33:28 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Sat, 11 Jan 2020 05:33:28 -0600 From: Segher Boessenkool To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , arnd@arndb.de, tglx@linutronix.de, vincenzo.frascino@arm.com, luto@kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org Subject: Re: Surprising code generated for vdso_read_begin() Message-ID: <20200111113328.GX3191@gate.crashing.org> References: <20200109200733.GS3191@gate.crashing.org> <77a8bf25-6615-6c0a-56d4-eae7aa8a8f09@c-s.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <77a8bf25-6615-6c0a-56d4-eae7aa8a8f09@c-s.fr> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 10, 2020 at 07:45:44AM +0100, Christophe Leroy wrote: > Le 09/01/2020 ? 21:07, Segher Boessenkool a ?crit?: > >It looks like the compiler did loop peeling. What GCC version is this? > >Please try current trunk (to become GCC 10), or at least GCC 9? > > It is with GCC 5.5 > > https://mirrors.edge.kernel.org/pub/tools/crosstool/ doesn't have more > recent than 8.1 Arnd, can you update the tools? We are at 8.3 and 9.2 now :-) Or is this hard and/or painful to do? > With 8.1, the problem doesn't show up. Good to hear that. Hrm, I wonder when it was fixed... Segher