Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 11 Jan 2020 16:07:35 +0100
From:   =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= <mirq-linux@rere.qmqm.pl>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: imu/mpu6050: support dual-edge IRQ
Message-ID: <20200111150735.GA16291@qmqm.qmqm.pl>
References: <MN2PR12MB33737F067F25B2F7477C4FE5C43C0@MN2PR12MB3373.namprd12.prod.outlook.com>
 <e5b39c16dc6dcb25324f6e8389cc0d0f895c1cbd.1578309319.git.mirq-linux@rere.qmqm.pl>
 <20200111121047.79e16365@archlinux>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200111121047.79e16365@archlinux>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Jan 11, 2020 at 12:10:47PM +0000, Jonathan Cameron wrote:
> On Mon, 06 Jan 2020 12:17:54 +0100
> Micha? Miros?aw <mirq-linux@rere.qmqm.pl> wrote:
> 
> > Make mpu6050 usable on platforms which provide only any-edge interrupts.
> > This also covers shared interrupt case.
> 
> So this had me confused for a bit because I assumed we were trying to make
> a level interrupt providing device work with edge interrupts.  Seems
> device supports a pulsed  mode and the driver supports this.
> 
> Why do we want to detect on both edges?  Do you have a crazy board
> with this shared and some devices using the rising edge and some the falling one?
> 
> For shared case it should return that it did not handle the interrupt
> to allow spurious interrupt detection to work...

Hmm. The shared interrupt is a red herring. I'll remove the sentence
from commitmsg as it looks like the driver needs a few more fixups
to be able to share the interrupt line.

The patch is required on platforms that support only dual-edge
interrupts, like eg. AT91SAM9G45-based one I have.

Best Regards,
Micha? Miros?aw