Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2072163ybl; Sat, 11 Jan 2020 08:31:02 -0800 (PST) X-Google-Smtp-Source: APXvYqzSUCbNOaiw8lmcpo7ObEkjOAamoAqnhJBxI41BL/uSJZ9wcrBfJM15FCximz4H1C2kzkAq X-Received: by 2002:a05:6830:20d3:: with SMTP id z19mr6703444otq.330.1578760262498; Sat, 11 Jan 2020 08:31:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578760262; cv=none; d=google.com; s=arc-20160816; b=pGfok5DOTaFrJ20Wj8QcURXLY75UViZ43gjnQURCQJCpIeWB13/2CBmk8xVvn8ldP4 ECEf6M11t2exp+bcwB2w/yniOzLfNmyF+Vq+mA2aur1CtqePWWmVtf/A6yvGlZ1s+qe3 Blw3yaA2kGqmC/hhVQrOeKxOVjdEvgDn3Pg6Y8CvErcsrIoNyEqhKs+LrogTUCz5D8Dt zSoxFFg4SKFkDu5osBzsPa47Phe+SiI5qFdyFO54d5EnNi6TNBVlqqSzlv9s1WOw6s7Q EnpTk0ZS7mol8GWXNCsdxi5VMKkYBLXaiGAVf4rbSb4mcvk1bpB47DQ4Pb9w9orapkCx z2MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=rre87uc28Cyxs8MDTNj0q6kcCS2wOJq/2DgrFm1A0Gk=; b=RtD/YXvc3NmVuPw9mATTWyppCHpzq5eMhKkUsHAsQ9jdFnXXV4umEn/bMyu26zbfkn r7hDQ8JBCAPZhIh6/f1Fl1jLM0B1+DLXvZWQgV66XwSsD1E3caK4KbRyNnTri5cTlGQ8 7Vh4RpH/Yk5bOP3In5zno01KHQq5Njz/y24F+VvQj3ba+/XkL+RwLbOIoRv+O2ppx1I7 5T31IzKIDkzEAw0StapAdyKd6H2fuTNP8jzWKbdspva9jIqTNwJJ3r/GA/wPjfTAXPeo r3GgpuxmZfM0f1jQ3mRO4r0Wtso4mt+PwneBroLf160ouma5juJajRRu/gx26CuKHf3x mhsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="fmhf/bzI"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d9si1022012otf.81.2020.01.11.08.30.50; Sat, 11 Jan 2020 08:31:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="fmhf/bzI"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730337AbgAKQ37 (ORCPT + 99 others); Sat, 11 Jan 2020 11:29:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:49438 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730198AbgAKQ37 (ORCPT ); Sat, 11 Jan 2020 11:29:59 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3DF0F2072E; Sat, 11 Jan 2020 16:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578760198; bh=/wlKCThrzNJPzZekL3yESpjJlP5RxW4MwHyG6+SnY1o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fmhf/bzIdrvM3mWAMr0lt5BRE0JT4yQNn34Yqr5VNyOHa0cHOHoClVhmddExtTFak 0Vuq/UahvfhT8PUf50VWKT5hIY6tjvsbEbzM5iglCRVDxF3BK7L3XfDToEyurfPNyM B0yF3W4MCZSgbjR5a7DEL0XZ/h9Vdgb6Yz1/n9UI= Date: Sat, 11 Jan 2020 11:29:57 -0500 From: Sasha Levin To: Dexuan Cui Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, b.zolnierkie@samsung.com, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, mikelley@microsoft.com, Alexander.Levin@microsoft.co, weh@microsoft.com Subject: Re: [PATCH][RESEND] video: hyperv_fb: Fix hibernation for the deferred IO feature Message-ID: <20200111162957.GK1706@sasha-vm> References: <1578350511-130150-1-git-send-email-decui@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1578350511-130150-1-git-send-email-decui@microsoft.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 06, 2020 at 02:41:51PM -0800, Dexuan Cui wrote: >fb_deferred_io_work() can access the vmbus ringbuffer by calling >fbdefio->deferred_io() -> synthvid_deferred_io() -> synthvid_update(). > >Because the vmbus ringbuffer is inaccessible between hvfb_suspend() >and hvfb_resume(), we must cancel info->deferred_work before calling >vmbus_close() and then reschedule it after we reopen the channel >in hvfb_resume(). > >Fixes: a4ddb11d297e ("video: hyperv: hyperv_fb: Support deferred IO for Hyper-V frame buffer driver") >Fixes: 824946a8b6fb ("video: hyperv_fb: Add the support of hibernation") >Signed-off-by: Dexuan Cui >Reviewed-by: Wei Hu >--- > >This is a RESEND of https://lkml.org/lkml/2019/11/20/73 . > >The only change is the addition of Wei's Review-ed-by. > >Please review. > >If it looks good, Sasha Levin, can you please pick it up via the >hyperv/linux.git tree, as you did last time for this driver? Like with the input driver, if the relevant maintainers here are okay with this type of patches going through the hyperv tree I'll be happy to do it, otherwise I need an explicit ack from them on this patch. -- Thanks, Sasha