Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200110202349.1881840-1-nivedita@alum.mit.edu>
 <20200110203828.GK19453@zn.tnic> <202001101255.3F360ED562@keescook> <CAEQFVGa4fksPRtiLtBckSgbJY_JSHr07hoy5+5w-pAYym16YVg@mail.gmail.com>
In-Reply-To: <CAEQFVGa4fksPRtiLtBckSgbJY_JSHr07hoy5+5w-pAYym16YVg@mail.gmail.com>
From:   Mauro Rossi <issor.oruam@gmail.com>
Date:   Sat, 11 Jan 2020 20:40:01 +0100
Message-ID: <CAEQFVGbWKf2ksMrMmtymewArSF=ztNgeuieEQ3wvKrX1r759Aw@mail.gmail.com>
Subject: Fwd: [PATCH] x86/tools/relocs: Add _etext and __end_of_kernel_reserve
 to S_REL
To:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Message resent as plain text to linux-kernel@vger.kernel.org
because of rejection of previous message

---------- Forwarded message ---------
From: Mauro Rossi <issor.oruam@gmail.com>
Date: Sat, Jan 11, 2020 at 8:36 PM
Subject: Re: [PATCH] x86/tools/relocs: Add _etext and
__end_of_kernel_reserve to S_REL
To: Kees Cook <keescook@chromium.org>
Cc: Borislav Petkov <bp@alien8.de>, Arvind Sankar
<nivedita@alum.mit.edu>, Thomas Gleixner <tglx@linutronix.de>, Ingo
Molnar <mingo@redhat.com>, H. Peter Anvin <hpa@zytor.com>,
<x86@kernel.org>, Linux Kernel Mailing List
<linux-kernel@vger.kernel.org>, Thomas Lendacky
<Thomas.Lendacky@amd.com>


Hello Kees,

On Fri, Jan 10, 2020 at 9:56 PM Kees Cook <keescook@chromium.org> wrote:
>
> On Fri, Jan 10, 2020 at 09:38:28PM +0100, Borislav Petkov wrote:
> > On Fri, Jan 10, 2020 at 03:23:49PM -0500, Arvind Sankar wrote:
> > > Pre-2.23 binutils makes symbols defined outside sections absolute, so
> > > these two symbols break the build on old linkers.
> >
> > -ENOTENOUGHINFO
> >
> > Which old linkers, how exactly do they break the build, etc etc?
> >
> > Please give exact reproduction steps.
>
> Mauro (now CCed) ran into this too, but on 32-bit builds only with older
> binutils. I hadn't set up an environment to try to reproduce it yet, but
> it seems like this patch would fix it. Mauro can you test this? Does it
> fix it for you too?
>
> https://lore.kernel.org/lkml/20200110202349.1881840-1-nivedita@alum.mit.edu/
>
> -Kees


The patch solves the issue with Android build of 32bit kernel,
I don't see 'Invalid absolute R_386_32 relocation' errors anymore.

Thanks a lot!

Mauro