Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2228629ybl; Sat, 11 Jan 2020 12:04:04 -0800 (PST) X-Google-Smtp-Source: APXvYqxld1aLexKUxwhA5P6jvIvqbUCqv9Exghgq/lZoULM7ECW8kYec+wNfWi642s9vU39XhE/Y X-Received: by 2002:aca:45c1:: with SMTP id s184mr7429451oia.158.1578773044039; Sat, 11 Jan 2020 12:04:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578773044; cv=none; d=google.com; s=arc-20160816; b=gu+EDyuxbnsboSEjf1hGOnzH51QM39UfxR1bypejNBDH8DCb62bllnUynHHoqQxyT8 Dc+s+EEKPKmbGzdCH05mxbXJ07qpYbu1vVHuAybRcdhLJooSKxTCCusRPB5F1XCQTQqG sxhqkD9BbdPmomGBJu1h159hiO52O5y61BwxnTamWOeyPLMt0ORK9/1kMGqqsJj8n1PZ zpqMWYgqlFJl9XxlrEx87X6tjrBcDM78N95isGhjqOgOgKOQl0bb96Gim90SWhfl7K/K OHl3CHIot4p48QpBC/pPULzGDFSqEtB4DuZlROsRPFDqrAWZpGMIi1y/CKBTvo/nU1w6 50Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=sLXpRcz3xkqubFH3Q1blu41zWW59hXJOxLW7WxMqdfs=; b=KTDSXCWyAro+l9y8qNWJn186zm0/xavb+aBiZEhimlLJk2YoEC19xqUozNdfTHg2r1 802YME+P53wE7F2VF7i9o3FPxjqtMZ+XJ38irA58Ao1csQTBDSsra5jbg4xnBCdLjgaY vEb5to7Crsp5ksSqjzt2n+zeW2Hm+jXegOWc9fMutzNcYIkp0JNeFRJtKNXl6kQumCsm 6qVdWMa9dSDBNXG5SSeeq7YjcObpQX+NPCboOubXpBZ/1gWKUoy7VUhgsngfAo+Qnm0d HU9xPf9UD+lCdwrhytEaM1hOnyXZM7cjEtibSbq9WL2Mzs/ore2Lq4FC/Sd3vJMay48Y NTpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bynPxBRX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s6si3876922otp.126.2020.01.11.12.03.39; Sat, 11 Jan 2020 12:04:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bynPxBRX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731046AbgAKUBt (ORCPT + 99 others); Sat, 11 Jan 2020 15:01:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:55566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731003AbgAKUBt (ORCPT ); Sat, 11 Jan 2020 15:01:49 -0500 Received: from localhost (unknown [62.119.166.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 21DCE2082E; Sat, 11 Jan 2020 20:01:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578772908; bh=5cQ3N/xRnFT6rIm/nGBRfofSS9aP6lkjO+HDHEkZnGE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bynPxBRXW5sXd95VvECqw+6vC4DWlMAiSdCDiSW86hGjttZudYWnrvEQmqDkLN3uu qXjUz1wMI59w1Zbm0x74GoA4IaKNbgCe/oLQ8hMuVV256z5Ln3/gGypUNOH4q2k3wy bEYu1706F5V+Dom2Xiu8rVsLBWASfsK3se0kfSA0= Date: Sat, 11 Jan 2020 20:23:53 +0100 From: Greg KH To: Kai-Heng Feng Cc: mathias.nyman@intel.com, stern@rowland.harvard.edu, acelan.kao@canonical.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] USB: Disable LPM on WD19's Realtek Hub Message-ID: <20200111192353.GA435222@kroah.com> References: <20200103084008.3579-3-kai.heng.feng@canonical.com> <20200110080211.22626-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200110080211.22626-1-kai.heng.feng@canonical.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 10, 2020 at 04:02:11PM +0800, Kai-Heng Feng wrote: > Realtek Hub (0bda:0x0487) used in Dell Dock WD19 sometimes drops off the > bus when bringing underlying ports from U3 to U0. > > Disabling LPM on the hub during setting link state is not enough, so > let's disable LPM completely for this hub. > > Signed-off-by: Kai-Heng Feng > --- > drivers/usb/core/quirks.c | 3 +++ > 1 file changed, 3 insertions(+) What changed from v1? Always put that below the --- line. Also I only see 1 patch here, what happened to the first two? Please resend the whole series, and properly document what went on, you know this... thanks, greg k-h