Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 13 Jan 2020 11:40:30 +0800
User-Agent: K-9 Mail for Android
In-Reply-To: <CAAhV-H5QpJcC-iwjmY0Xgdeugsf8FK+ZxgpU=TkcJttW30=mew@mail.gmail.com>
References: <20200112081416.722218-1-jiaxun.yang@flygoat.com> <20200112081416.722218-4-jiaxun.yang@flygoat.com> <CAAhV-H5QpJcC-iwjmY0Xgdeugsf8FK+ZxgpU=TkcJttW30=mew@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v3 03/10] dt-bindings: interrupt-controller: Add Loongson IOINTC
To:     Huacai Chen <chenhc@lemote.com>
CC:     "open list:MIPS" <linux-mips@vger.kernel.org>,
        Paul Burton <paul.burton@mips.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <maz@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.co>, devicetree@vger.kernel.org,
        Rob Herring <robh@kernel.org>
From:   Jiaxun Yang <jiaxun.yang@flygoat.com>
Message-ID: <516A456F-29BA-4DA2-B22B-574AC4044249@flygoat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


=E4=BA=8E 2020=E5=B9=B41=E6=9C=8813=E6=97=A5 GMT+08:00 =E4=B8=8A=E5=8D=881=
1:44:10, Huacai Chen <chenhc@lemote=2Ecom> =E5=86=99=E5=88=B0:
>Hi, Jiaxun,
>
>On Sun, Jan 12, 2020 at 4:21 PM Jiaxun Yang <jiaxun=2Eyang@flygoat=2Ecom>
>wrote:
>>
>> Document Loongson I/O Interrupt controller=2E
>>
>> Signed-off-by: Jiaxun Yang <jiaxun=2Eyang@flygoat=2Ecom>
>> Reviewed-by: Rob Herring <robh@kernel=2Eorg>
>> ---
>>  =2E=2E=2E/interrupt-controller/loongson,iointc=2Eyaml | 92
>+++++++++++++++++++
>>  1 file changed, 92 insertions(+)
>>  create mode 100644
>Documentation/devicetree/bindings/interrupt-controller/loongson,iointc=2E=
yaml
>>
>> diff --git
>a/Documentation/devicetree/bindings/interrupt-controller/loongson,iointc=
=2Eyaml
>b/Documentation/devicetree/bindings/interrupt-controller/loongson,iointc=
=2Eyaml
>> new file mode 100644
>> index 000000000000=2E=2Eb0fe6c551362
>> --- /dev/null
>> +++
>b/Documentation/devicetree/bindings/interrupt-controller/loongson,iointc=
=2Eyaml
>> @@ -0,0 +1,92 @@
>> +# SPDX-License-Identifier: (GPL-2=2E0-only OR BSD-2-Clause)
>> +%YAML 1=2E2
>> +---
>> +$id:
>"http://devicetree=2Eorg/schemas/interrupt-controller/loongson,iointc=2Ey=
aml#"
>> +$schema: "http://devicetree=2Eorg/meta-schemas/core=2Eyaml#"
>> +
>> +title: Loongson I/O Interrupt Controller
>> +
>> +maintainers:
>> +  - Jiaxun Yang <jiaxun=2Eyang@flygoat=2Ecom>
>> +
>> +description: |
>> +  This interrupt controller is found in the Loongson-3 family of
>chips as the primary
>> +  package interrupt source which can route interrupt to interrupt
>line of cores=2E
>> +
>> +allOf:
>> +  - $ref: /schemas/interrupt-controller=2Eyaml#
>> +
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - const: loongson,iointc-1=2E0
>> +      - const: loongson,iointc-1=2E0a
>As our early discussion, we should use liointc for the legacy Loongson
>irq-controller ans use eiointc for the new irq-controller in

Will do, thanks=2E

>Loongson-3A4000=2E Moreover, could you please describe the difference
>between 1=2E0 and 1=2E0a?

1=2E0a appears in Loongson-3A4000 doesn't have LPC spurious interrupt issu=
e=2E

>
>Huacai
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupt-controller: true
>> +
>> +  interrupts:
>> +    description:
>> +      Interrupt source of the CPU interrupts=2E
>> +    minItems: 1
>> +    maxItems: 4
>> +
>> +  interrupt-names:
>> +    description: List of names for the parent interrupts=2E
>> +    oneOf:
>> +      - items:
>> +          - const: int0
>> +          - const: int1
>> +          - const: int2
>> +          - const: int3
>> +    minItems: 1
>> +    maxItems: 4
>> +
>> +  '#interrupt-cells':
>> +    const: 2
>> +
>> +  'loongson,parent_int_map':
>> +    description: |
>> +      This property points the accept range of children interrupts
>> +      that parents will recieve=2E Each cell refers to a parent
>interrupt line
>> +      and each bit in the cell refers to a children interrupt=2E If a
>parent
>> +      did not connected, than keep it's cell with zero=2E
>> +    allOf:
>> +      - $ref: /schemas/types=2Eyaml#/definitions/uint32-array
>> +      - items:
>> +          minItems: 4
>> +          maxItems: 4
>> +
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - interrupt-controller
>> +  - '#interrupt-cells'
>> +  - 'loongson,parent_int_map'
>> +
>> +
>> +examples:
>> +  - |
>> +    iointc: interrupt-controller@3ff01400 {
>> +      compatible =3D "loongson,iointc-1=2E0";
>> +      reg =3D <0 0x3ff01400 0x64>;
>> +
>> +      interrupt-controller;
>> +      #interrupt-cells =3D <2>;
>> +
>> +      interrupt-parent =3D <&cpuintc>;
>> +      interrupts =3D <2>, <3>;
>> +      interrupt-names =3D "int0", "int1";
>> +
>> +      loongson,parent_int_map =3D <0xf0ffffff>, /* int0 */
>> +                                <0x0f000000>, /* int1 */
>> +                                <0x00000000>, /* int2 */
>> +                                <0x00000000>; /* int3 */
>> +
>> +    };
>> +
>> +=2E=2E=2E
>> --
>> 2=2E24=2E1
>>

--=20
Jiaxun Yang