Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V11 1/5] mm/hotplug: Introduce arch callback validating
 the hot remove range
To:     kbuild test robot <lkp@intel.com>
Cc:     mark.rutland@arm.com, david@redhat.com, catalin.marinas@arm.com,
        linux-mm@kvack.org, arunks@codeaurora.org, cpandya@codeaurora.org,
        will@kernel.org, ira.weiny@intel.com, steven.price@arm.com,
        valentin.schneider@arm.com, suzuki.poulose@arm.com,
        Robin.Murphy@arm.com, broonie@kernel.org, cai@lca.pw,
        ard.biesheuvel@arm.com, dan.j.williams@intel.com,
        linux-arm-kernel@lists.infradead.org, osalvador@suse.de,
        kbuild-all@lists.01.org, steve.capper@arm.com, logang@deltatee.com,
        linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        mgorman@techsingularity.net
References: <1578625755-11792-2-git-send-email-anshuman.khandual@arm.com>
 <202001112247.k6CzgJBj%lkp@intel.com>
From:   Anshuman Khandual <anshuman.khandual@arm.com>
Message-ID: <bf4362af-2ba0-9099-985a-7b32fdbc6871@arm.com>
Date:   Mon, 13 Jan 2020 09:36:17 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <202001112247.k6CzgJBj%lkp@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 01/11/2020 07:41 PM, kbuild test robot wrote:
>    mm/memory_hotplug.c: In function 'check_hotremove_memory_range':
>>> mm/memory_hotplug.c:1027:7: error: implicit declaration of function 'arch_memory_removable'; did you mean 'add_memory_resource'? [-Werror=implicit-function-declaration]
>      rc = arch_memory_removable(start, size);
>           ^~~~~~~~~~~~~~~~~~~~~
>           add_memory_resource
>    At top level:
>    mm/memory_hotplug.c:1017:12: warning: 'check_hotremove_memory_range' defined but not used [-Wunused-function]
>     static int check_hotremove_memory_range(u64 start, u64 size)
>                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    cc1: some warnings being treated as errors
> 
> vim +1027 mm/memory_hotplug.c
> 
>   1016	
>   1017	static int check_hotremove_memory_range(u64 start, u64 size)
>   1018	{
>   1019		int rc;
>   1020	
>   1021		BUG_ON(check_hotplug_memory_range(start, size));
>   1022	
>   1023		/*
>   1024		 * First check if the platform is willing to have this
>   1025		 * memory range removed else just abort.
>   1026		 */
>> 1027		rc = arch_memory_removable(start, size);
>   1028		if (!rc)
>   1029			return -EINVAL;
>   1030	
>   1031		return 0;
>   1032	}
>   1033	


Both the build failures reported here could be solved by moving
check_hotremove_memory_range() inside CONFIG_MEMORY_HOTREMOVE
wrappers, will fix it.

- Anshuman