Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Radhey Shyam Pandey <radheys@xilinx.com>
To:     Andre Przywara <andre.przywara@arm.com>,
        "David S . Miller" <davem@davemloft.net>
CC:     Michal Simek <michals@xilinx.com>,
        Robert Hancock <hancock@sedsystems.ca>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 08/14] net: axienet: Drop MDIO interrupt registers from
 ethtools dump
Thread-Topic: [PATCH 08/14] net: axienet: Drop MDIO interrupt registers from
 ethtools dump
Thread-Index: AQHVx6y7Cl3Mr7YIzE6y4oKaxbl9yafoHX0A
Date:   Mon, 13 Jan 2020 06:02:06 +0000
Message-ID: <CH2PR02MB7000F73F928C719596BF3611C7350@CH2PR02MB7000.namprd02.prod.outlook.com>
References: <20200110115415.75683-1-andre.przywara@arm.com>
 <20200110115415.75683-9-andre.przywara@arm.com>
In-Reply-To: <20200110115415.75683-9-andre.przywara@arm.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: xilinx.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e0d130ff-50ad-4d42-726a-08d797ee1e93
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2020 06:02:06.5472
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Wl2DZcKfWSYLjtZYQ2XCaOPVX5NZEOLnDIRXyofENuncxC57l30QEm4WZ5gmmYftMipq6zJN8tJFvI5YL/fF1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6151
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Andre Przywara <andre.przywara@arm.com>
> Sent: Friday, January 10, 2020 5:24 PM
> To: David S . Miller <davem@davemloft.net>; Radhey Shyam Pandey
> <radheys@xilinx.com>
> Cc: Michal Simek <michals@xilinx.com>; Robert Hancock
> <hancock@sedsystems.ca>; netdev@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: [PATCH 08/14] net: axienet: Drop MDIO interrupt registers from
> ethtools dump
>=20
> Newer revisions of the IP don't have these registers. Since we don't
> really use them, just drop them from the ethtools dump.
>=20
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 4 ----
>  1 file changed, 4 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index e83c7b005f50..7a747345e98e 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -1239,10 +1239,6 @@ static void axienet_ethtools_get_regs(struct
> net_device *ndev,
>  	data[20] =3D axienet_ior(lp, XAE_MDIO_MCR_OFFSET);
>  	data[21] =3D axienet_ior(lp, XAE_MDIO_MWD_OFFSET);
>  	data[22] =3D axienet_ior(lp, XAE_MDIO_MRD_OFFSET);
> -	data[23] =3D axienet_ior(lp, XAE_MDIO_MIS_OFFSET);
> -	data[24] =3D axienet_ior(lp, XAE_MDIO_MIP_OFFSET);
> -	data[25] =3D axienet_ior(lp, XAE_MDIO_MIE_OFFSET);
> -	data[26] =3D axienet_ior(lp, XAE_MDIO_MIC_OFFSET);

We can also remove these #defines from the header.
Alternatively, we can cherry-pick commit f5b9e58 " net: xilinx: axiethernet=
:
Fix axiethernet register description" from xilinx tree and include it in th=
is
series.
>  	data[27] =3D axienet_ior(lp, XAE_UAW0_OFFSET);
>  	data[28] =3D axienet_ior(lp, XAE_UAW1_OFFSET);
>  	data[29] =3D axienet_ior(lp, XAE_FMI_OFFSET);
> --
> 2.17.1