Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3626303ybl; Sun, 12 Jan 2020 23:05:11 -0800 (PST) X-Google-Smtp-Source: APXvYqzCTa+Tm/XswyxcTVqk195Cmr9zrKbQXEvbqGP7i8AVEjJPLu1lU/X1/+EXysgQqflvmsmQ X-Received: by 2002:aca:1a06:: with SMTP id a6mr11113620oia.148.1578899111397; Sun, 12 Jan 2020 23:05:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578899111; cv=none; d=google.com; s=arc-20160816; b=wexMO3xVK6BiG6lTCvrO/v2TMtQiILfGI7tfVkEWvcMBnr0a1p9stwrUVdHW4afrTz bj25t+RxZeCkuq5kuV2bfb3zFLY7AKi4M48lZDZHDfXKgAqEXiLsw79QwkP/uKJu0ny2 QbdGrRmwVDUNYAJzNt/dX7Fqv1DLn5KPiABLRPDsx/IDjej86rPkGVrPeK7p5Fj52l2p QLND0P2SgNaPb3RQOx0xXoqw38RGsaUi83gvaZ2Z/iUFM4Xv3k3EsUwaNAOtKxOak7JM uNfimo+DI13XODxw6VKH1aCFJq7BKTC6NqwpcavB5g5LF4tD1LdQOTFDFFOrwDfQdAwp +YhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=ryLUfBMJXBlW95TOo7K5NnTYa/sPJbK2W2JHRwWmOQo=; b=A9g34BBeZU4Gi2YwkWSeQwk2hVD7ofgJhDL3WBpwZAbyz06Xe2GI5/DxYgE/yhIZVH IXFYOlg4T20KF9SL9I5/zlN+LMig5ynhxmcEljD1qzSTzL53/W4lp9wiw0C7EibeeBdJ J5+sfVpcChGLmZo8jiM7/JDEiRDG8HdAVQ1UJR+iDlXXSdMd8sgGsPOXzRL9qb3pJthu 2+UFd2S/t381nnSgQFmHbhajZpDOUJwy1cWlc2wWALVJ+TNE1YgOEjFVCGpPX3vQnVVh aaRCOHhzuzmUqUHF1lAllcX5nSlvdgaR3haVpIdUkj4+DS8wKFOzud0F8aj9/eJX+KOM On/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a7si156324oti.135.2020.01.12.23.04.59; Sun, 12 Jan 2020 23:05:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728524AbgAMHD7 (ORCPT + 99 others); Mon, 13 Jan 2020 02:03:59 -0500 Received: from mga07.intel.com ([134.134.136.100]:40143 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725954AbgAMHD7 (ORCPT ); Mon, 13 Jan 2020 02:03:59 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2020 23:03:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,428,1571727600"; d="scan'208";a="247622717" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga004.fm.intel.com with ESMTP; 12 Jan 2020 23:03:57 -0800 From: Wei Yang To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wei Yang Subject: [PATCH] mm/gup.c: use is_vm_hugetlb_page() to check whether to follow huge Date: Mon, 13 Jan 2020 15:03:22 +0800 Message-Id: <20200113070322.26627-1-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No functional change, just leverage the helper function to improve readability as others. Signed-off-by: Wei Yang --- mm/gup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 7646bf993b25..7705929cc920 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma, pmdval = READ_ONCE(*pmd); if (pmd_none(pmdval)) return no_page_table(vma, flags); - if (pmd_huge(pmdval) && vma->vm_flags & VM_HUGETLB) { + if (pmd_huge(pmdval) && is_vm_hugetlb_page(vma)) { page = follow_huge_pmd(mm, address, pmd, flags); if (page) return page; @@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma, pud = pud_offset(p4dp, address); if (pud_none(*pud)) return no_page_table(vma, flags); - if (pud_huge(*pud) && vma->vm_flags & VM_HUGETLB) { + if (pud_huge(*pud) && is_vm_hugetlb_page(vma)) { page = follow_huge_pud(mm, address, pud, flags); if (page) return page; -- 2.17.1