From: Ingo Oeser <ioe-lkml@rameria.de>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata queue updated
Date: Sun, 29 Jan 2006 17:11:42 +0100
User-Agent: KMail/1.7.2
Cc: Jeff Garzik <jgarzik@pobox.com>, linux-ide@vger.kernel.org
References: <20060128182522.GA31458@havoc.gtf.org>
In-Reply-To: <20060128182522.GA31458@havoc.gtf.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200601291711.43426.ioe-lkml@rameria.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 860
Lines: 34

Hi Jeff,


On Saturday 28 January 2006 19:25, Jeff Garzik wrote:
> Testing and merge point in Tejun's flood of patches :)  The patch
> below is against current linux-2.6.git.

These "function(unsigned int *classes)" style functions in 
"libata-core.c" worry me somewhat.  Esp. that sometimes you have one class,
sometimes two.
This looks like a bug waiting to happen for me.

Could we somehow get a 

struct ata_classes {
	unsigned int master;
	unsigned int slave;
}

here (or similiar), before this is in used everywhere?

Usage would be function(struct ata_classes *classes) then.


Thanks & Regards

Ingo Oeser


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/