Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 13 Jan 2020 09:40:38 +0100
Message-ID: <s5htv4zkaux.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Jia-Ju Bai <baijiaju1990@gmail.com>
Cc:     perex@perex.cz, tiwai@suse.com, rfontana@redhat.com,
        tglx@linutronix.de, allison@lohutok.net,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: cmipci: Fix possible a data race in snd_cmipci_interrupt()
In-Reply-To: <de859611-4bd0-647f-61e9-7138425ed736@gmail.com>
References: <20200111163027.27135-1-baijiaju1990@gmail.com>
        <s5h5zhhkrwe.wl-tiwai@suse.de>
        <de859611-4bd0-647f-61e9-7138425ed736@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 13 Jan 2020 09:20:37 +0100,
Jia-Ju Bai wrote:
> 
> 
> 
> On 2020/1/12 16:20, Takashi Iwai wrote:
> > On Sat, 11 Jan 2020 17:30:27 +0100,
> > Jia-Ju Bai wrote:
> >> The functions snd_cmipci_interrupt() and snd_cmipci_capture_trigger()
> >> may be concurrently executed.
> >>
> >> The function snd_cmipci_capture_trigger() calls
> >> snd_cmipci_pcm_trigger(). In snd_cmipci_pcm_trigger(), the variable
> >> rec->running is written with holding a spinlock cm->reg_lock. But in
> >> snd_cmipci_interrupt(), the identical variable cm->channel[0].running
> >> or cm->channel[1].running is read without holding this spinlock. Thus,
> >> a possible data race may occur.
> >>
> >> To fix this data race, in snd_cmipci_interrupt(), the variables
> >> cm->channel[0].running and cm->channel[1].running are read with holding
> >> the spinlock cm->reg_lock.
> >>
> >> This data race is found by the runtime testing of our tool DILP-2.
> >>
> >> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> > Thanks for the patch.
> >
> > That's indeed a kind of race, but this change won't fix anything in
> > practice, though.  The inconsistent running flag between those places,
> > there are two cases:
> >
> > - running became 0 to 1; this cannot happen, as the irq isn't issued
> >    before the stream gets started
> >
> > - running became 1 to 0; this means that the stream gets stopped
> >    between two points, and it's not better to call
> >    snd_pcm_period_elapsed() for an already stopped stream.
> 
> Thanks for the reply :)
> 
> I am not sure to understand your words.
> 
> Do you mean that this code should be also protected by the spinlock?
>     if (cm->pcm) {
>         if ((status & CM_CHINT0) && cm->channel[0].running)
>             snd_pcm_period_elapsed(cm->channel[0].substream);
>         if ((status & CM_CHINT1) && cm->channel[1].running)
>             snd_pcm_period_elapsed(cm->channel[1].substream);
>     }

No, it can't be protected as it would lead to ABBA deadlock.
That said, it's rather safe to leave the code as is.


thanks,

Takashi