Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3714456ybl; Mon, 13 Jan 2020 01:06:28 -0800 (PST) X-Google-Smtp-Source: APXvYqxdkgP0BL/PIJbPnhCT2DWOh+wg3ImrjkCI/8IkN2mD5SnR3bntNb/Y6huYQ8W3sCE5NYAd X-Received: by 2002:a05:6808:291:: with SMTP id z17mr11516690oic.94.1578906388435; Mon, 13 Jan 2020 01:06:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578906388; cv=none; d=google.com; s=arc-20160816; b=Gacl41UWNEIh/eZPUIDIUhpwUmuaD2gaQ7SBEkrp3b54d3/wLXo5aYEITzowoguiZR 8Sv+RlB9f4thO1mbCC28YjgAkta2XX4O+Ht+QaZa2LihdR5hBs1YJUBnEU3imHlzWUFa yduxAMDn5vo5/gI2c2pPbqQ7JUlZH0jagl/LYcWbt1wksYhOZ/X4KbRYY3zwIbg0HWbT WhBW9/1I4Rqq0kX44KQ0zrAJbQaoJzVuIQbXHWd2gXRqCFBLbU8kuU/bOTrVscE6T2fY 7ssW3aSbcFCmS6khqyh9FUporZioOYCL0FryWwdK4kB4CeoIW7fMpfU+X4h3gE9obSHl ypVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=dKbaCfSlA3zMZXVOUhal7rgsI6faHR3J0+QS6uAvZG8=; b=VJ14msOSfNIm8/VsXPDd8RGxIEjF6qAXkU4RGgu5cJI+IxL900gSSP1lto+H/5pElm SzeLD8ShlPqcs0DVzQ+AUkp/qxLV0RS6ENk+omXB9NSGYX+hS8nttC5otAuVDImw6ak6 bGfq1OOQwUYhLcUVeBBEwcMQTbSPu7bNZqMmPfc2nOLJbjJnyP0LT2QTcXCwL+KlFmtg CVBH2eoAK2JA4m4aGEZDmLhQDc2Ci8KuYifpuvRDaE4F2zyzYL/XiyenhcP9n5mGAhwp MsM5PI9kV0O3G+JDCngdlIYmXwiXX6rPSoAv4CcAjsDtMSMUa/gEVqRADhiEjVUW7uz9 dnpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=iHyodrnj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d22si6777385oti.316.2020.01.13.01.06.15; Mon, 13 Jan 2020 01:06:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=iHyodrnj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725992AbgAMJFT (ORCPT + 99 others); Mon, 13 Jan 2020 04:05:19 -0500 Received: from mail.skyhub.de ([5.9.137.197]:53300 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725268AbgAMJFT (ORCPT ); Mon, 13 Jan 2020 04:05:19 -0500 Received: from zn.tnic (p200300EC2F05D300845C97C8540218FC.dip0.t-ipconnect.de [IPv6:2003:ec:2f05:d300:845c:97c8:5402:18fc]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BB8791EC0CBD; Mon, 13 Jan 2020 10:05:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1578906317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=dKbaCfSlA3zMZXVOUhal7rgsI6faHR3J0+QS6uAvZG8=; b=iHyodrnjURcmi71GzArtn72rgcjvUjXpWX9f6ImlJyI/v0HOpoKpyqLGOy2KcFDL71+AxE p56+jVTXYz8LjKpndchdbjkyzTJVsrD+cGnh2Eh72F5KcQ3LNyWjSCnrfiWA86qrjV6xKI ZUCIY5t4ejxDMe5uPAU/ZY1E0bOdnls= Date: Mon, 13 Jan 2020 10:05:09 +0100 From: Borislav Petkov To: "Luck, Tony" Cc: Chuansheng Liu , linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com Subject: Re: [PATCH v2] x86/mce/therm_throt: Fix the access of uninitialized therm_work Message-ID: <20200113090509.GC13310@zn.tnic> References: <20200107004116.59353-1-chuansheng.liu@intel.com> <20200110182929.GA20511@agluck-desk2.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200110182929.GA20511@agluck-desk2.amr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 10, 2020 at 10:29:29AM -0800, Luck, Tony wrote: > On Tue, Jan 07, 2020 at 12:41:16AM +0000, Chuansheng Liu wrote: > > In my ICL platform, it can be reproduced in several times > > of reboot stress. With this fix, the system keeps alive > > for more than 200 times of reboot stress. > > > > V2: Boris shares a good suggestion that we can moving the > > interrupt unmasking at the end of therm_work initialization. > > > > Signed-off-by: Chuansheng Liu > > Looks good to me: > > Acked-by: Tony Luck Thx. This "ICL platform" - whatever that is - is this shipping already so that this qualifies for stable@ or can it go the normal path? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette