Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3732494ybl; Mon, 13 Jan 2020 01:30:32 -0800 (PST) X-Google-Smtp-Source: APXvYqx/wVg57AyAvaJwQnAMrN6r6dNwD7+rF3dbWhR0mxy6M2AnQQzVVsiWyEh+elPTL1kVPXnu X-Received: by 2002:a9d:3e43:: with SMTP id h3mr11877963otg.84.1578907832650; Mon, 13 Jan 2020 01:30:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1578907832; cv=pass; d=google.com; s=arc-20160816; b=K8F+5MslojRw3L+RCXmm5SG/ot7ivEb4JABeWXBBhlwukXzragjc+/IuGq8BlDAfsi On2DFMH1YuKHbcXij2EW8R3A2nRVt2d/w5nYyozAz5q5wRjtN9iGCQvz6OHxJbk2yoNr nRCxnfDqTvfOxLj6H2VJ9+cdC7nOXZnjDQ14KpVbFnnN4kxu7eLfUzsuxvc7aXrO4EyX Bmanna95GoapkeLMwNl+M32MbZeBkAH1A4Z6WYte+UmYYiwBNCrlCq+gQwfQLhiWwvKV zKYAkzBk3nhQ5/0VMQxvxj/Celvu9uEQb1Gk8j4m6AeK3+Ij20Sgq2kC+UCIj+GXKeij elsQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=Vrn2vrA6QdFtV7H0v9twX9CkrTKujOjP92xTsjpqw6U=; b=PSVGsJk+MtO3DA6gza1nFGUAjXYJ2XiDC5qnLb/3qDRqxRpDa3VVsfB8BFiBWTESkh wkvxUMV7ydpE8VXRiReZRwD9vBWkdNZ9i8jVIZTvojwYF9porjh8wxqlvEb/2kPFLHDV KjmYL1Fnghp5gPe4XZnj/NKZkTCOV3Ajy2AMXG+ZlxH0nkJA40MRbY2YL/ai/28qtZHy lNldox1pPr27TmLlkZtF14+l5PvknJemwbSr9V21oIoWp3iuFnN5sBLhilK/s6YrUryR HlJacZF0Fwoei+WFw4S/JR/EiWVhAaW1ZfUS0MF/2Dgtj5av3q+ExTwTWc4J3aQvD5ja aPwg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@micron.com header.s=selector2 header.b=er1ahzjB; arc=pass (i=1 spf=pass spfdomain=micron.com dkim=pass dkdomain=micron.com dmarc=pass fromdomain=micron.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=micron.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m85si5730407oig.158.2020.01.13.01.30.20; Mon, 13 Jan 2020 01:30:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@micron.com header.s=selector2 header.b=er1ahzjB; arc=pass (i=1 spf=pass spfdomain=micron.com dkim=pass dkdomain=micron.com dmarc=pass fromdomain=micron.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=micron.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728646AbgAMJ2y (ORCPT + 99 others); Mon, 13 Jan 2020 04:28:54 -0500 Received: from mail-co1nam11on2066.outbound.protection.outlook.com ([40.107.220.66]:26916 "EHLO NAM11-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727494AbgAMJ2x (ORCPT ); Mon, 13 Jan 2020 04:28:53 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VvScej00ZsoW47UGrwSkryP1bOjCZyNXw6sxvIQ3NIdihys4mrbbKjZo7d3rX+aLAZl2OkiF009a+MpMPNN7fRGXTFxfqONrZYl4mh7eYAVZN+5ofu3tKukGtSpaTD9dqdRv2RSGOXk6Fe6xTfigQWD7peqK/NLYJxwVqt7klVGdiPu3r89oO4iwx5MqSDLRn5eRQqYqBnSU8LhhIXvO0/N7Uag9xhKck+lP0XqfTwkRDv372Qmf9KblwjbVJoRwa37wpEIfTfj2t71aal4FkLgyZ5Na6eFmV7NEy7+qF7RnIrugeVMOgassqV3EuA6r7+CwRbv9uiYjskVbMyq1iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vrn2vrA6QdFtV7H0v9twX9CkrTKujOjP92xTsjpqw6U=; b=GD5tBedt7vEqRxa0htp8rklm4Ittp8EOxelOz1JqSjwA55PgbI759csYXh/jJvxLLWNt8xdLs3/ipcr3dL50jtij7BhJyzGxAivPbBctu3LLgNUBYL04n9bZvXdXEO6UV7blnP7XvdtUqfNXEPgiZ1Ezv2Y8HltA0WWs9WiMtjYCkwI3i9dkz68XAgi1ykcHW8eDPkmBDXqrhfFFutIs44zbcfKzX0US3gjSR8vPoSfCEaJ9r95kJWowo7HHvzvs4fMEnRrBc2IDS3kbmwh30nXHOE3kLHLB7R2obVoKGszxjOrBtEUERL9Db+3VoM8T+Nifykq0bnUGd++x8rYa6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=micron.com; dmarc=pass action=none header.from=micron.com; dkim=pass header.d=micron.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=micron.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vrn2vrA6QdFtV7H0v9twX9CkrTKujOjP92xTsjpqw6U=; b=er1ahzjB9BeCXcLMnOLyVcCMb+4j4XjlhIBpHhgEvqR6xjlfJmuGk+kEhAhEBXNXvdE3kxG2eMNHWLn4d8DmObEvAB8Kg4ohMH9ZeKtv8poTe9bPaDy1tsYFscFDEd+ix4oQiJXcHPYqQe4eG1ChT2+nPiDhRIWDR1qX+WICSK0= Received: from BN7PR08MB5684.namprd08.prod.outlook.com (20.176.179.87) by BN7PR08MB5602.namprd08.prod.outlook.com (20.176.28.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.10; Mon, 13 Jan 2020 09:28:49 +0000 Received: from BN7PR08MB5684.namprd08.prod.outlook.com ([fe80::981f:90d7:d45f:fd11]) by BN7PR08MB5684.namprd08.prod.outlook.com ([fe80::981f:90d7:d45f:fd11%7]) with mapi id 15.20.2623.015; Mon, 13 Jan 2020 09:28:49 +0000 From: "Bean Huo (beanhuo)" To: Stanley Chu , "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "avri.altman@wdc.com" , "alim.akhtar@samsung.com" , "jejb@linux.ibm.com" CC: "asutoshd@codeaurora.org" , "cang@codeaurora.org" , "matthias.bgg@gmail.com" , "bvanassche@acm.org" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kuohong.wang@mediatek.com" , "peter.wang@mediatek.com" , "chun-hung.wu@mediatek.com" , "andy.teng@mediatek.com" Subject: RE: [EXT] [PATCH v1 1/3] scsi: ufs: fix empty check of error history Thread-Topic: [EXT] [PATCH v1 1/3] scsi: ufs: fix empty check of error history Thread-Index: AQHVwwrtYdyISOHmvEWfKtFqbPPmzqfoX2LQ Date: Mon, 13 Jan 2020 09:28:48 +0000 Message-ID: References: <1578147968-30938-1-git-send-email-stanley.chu@mediatek.com> <1578147968-30938-2-git-send-email-stanley.chu@mediatek.com> In-Reply-To: <1578147968-30938-2-git-send-email-stanley.chu@mediatek.com> Accept-Language: en-150, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYmVhbmh1b1xhcHBkYXRhXHJvYW1pbmdcMDlkODQ5YjYtMzJkMy00YTQwLTg1ZWUtNmI4NGJhMjllMzViXG1zZ3NcbXNnLTE2NGQ2YTRlLTM1ZTctMTFlYS04Yjg4LWRjNzE5NjFmOWRkM1xhbWUtdGVzdFwxNjRkNmE0Zi0zNWU3LTExZWEtOGI4OC1kYzcxOTYxZjlkZDNib2R5LnR4dCIgc3o9IjcyMSIgdD0iMTMyMjMzODEzMjI2NTMwODEyIiBoPSJmZnZXcE9SaG8vbE5UaGdMZU80a2liVkkyTTQ9IiBpZD0iIiBibD0iMCIgYm89IjEiLz48L21ldGE+ x-dg-rorf: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=beanhuo@micron.com; x-originating-ip: [195.89.176.137] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: de57875e-49f9-416f-f4d8-08d7980aff06 x-ms-traffictypediagnostic: BN7PR08MB5602:|BN7PR08MB5602:|BN7PR08MB5602: x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 028166BF91 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(376002)(366004)(396003)(346002)(39860400002)(136003)(199004)(189003)(110136005)(76116006)(54906003)(5660300002)(71200400001)(316002)(55016002)(8936002)(2906002)(4744005)(66476007)(66556008)(66946007)(52536014)(64756008)(66446008)(9686003)(6506007)(26005)(33656002)(7696005)(186003)(4326008)(86362001)(81166006)(81156014)(8676002)(478600001)(7416002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN7PR08MB5602;H:BN7PR08MB5684.namprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: micron.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: l3bQM7C/Wey/RyCIbhg+2MGMwXmUci9+lHKnf781iXlLvpOW2Yu+aGXQVWtVGGUBe5lv+RfhPuYMxRmsbXmSzkIoIS9o2afpy0N/dnyXbHlrBjdCfHwrMT/GTOI9xPLjE2dvAED1iFwUlqdR66JfPvEx5WCHvXWHiZqSzB6C5mS/gDDqtBQrZ8fVqbpgxNNGioNLgNYXX6iq2+phh02qyCwbyCuAACdimPtrmVwmXxZVmt0Q71of6UBlXONnSAYhMrp6NwhPSu4dQE7082g2XvmlhoKx1Z1U5TdiD4fwjOEGxF6wR7QxH6pElQHBMNwNLcpWG1xmo8bDNs8cenWwnmcZF6oxmvGgVLQUzbzgaoYMHMPcSOFMMPAidxbtWoadvsrPj9ThW1OZvP8Dd2Uz19YJnvXLg1+EvOdxaocIo9EpQNjF396sjWA+YpxuRJ4i Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: micron.com X-MS-Exchange-CrossTenant-Network-Message-Id: de57875e-49f9-416f-f4d8-08d7980aff06 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2020 09:28:48.9509 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f38a5ecd-2813-4862-b11b-ac1d563c806f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t+kPiOd+knDwDKxxYxfX3vzXUCuMtWhy8NduW08tBNl1ROqCKQgNcL0uVN7LdVUvnHE7aLk5OwOZrMu3J1AvmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR08MB5602 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Stanley >=20 > Currently checking if an error history element is empty or not is by its = "value". In > most cases, value is error code. >=20 > However this checking is not correct because some errors or events do not > specify any values in error history so values remain as 0, and this will = lead to > incorrect empty checking. >=20 Do you think this is a bug of UFS host controller? According to the UFS hos= t Spec,=20 If there had error detected in each layer, at least bit31 in its error code= register Should be set to 1. Why there was an error happening, but host didn't set this bit31? Thanks. //Bean