Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3767764ybl; Mon, 13 Jan 2020 02:14:23 -0800 (PST) X-Google-Smtp-Source: APXvYqwz/+fgH84DSw6iny1ShxSDzZBO70nZCCE3KlD78dHUS0+ASjasuxD8oDNhLpIDnr0KU9Pb X-Received: by 2002:aca:4a08:: with SMTP id x8mr12301574oia.39.1578910463398; Mon, 13 Jan 2020 02:14:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578910463; cv=none; d=google.com; s=arc-20160816; b=QFhoNLP3yRlSFEGk8X1lu8LXrnFbfLcWbKqbOLIsQYap3xzR7sRc0Bw25YQu1smCqL jPLIRkgRS8ny8XL3kLEnSApN04VahIOLbQN7R1V3Ce8RAEUvM3dUXOizakWseDxUdCut D2gZwvMZie6xOV+POoXFsNClehyyMneVPb3AqP8+RiUqWnJeQOhKymDH7fzIsCMADtRG i1GDm4QpgQuee2ePrEyTBEdMYwLF3QUZHFCUq6gPhQ7lgw7yggsY1nPNTEtbO8WW7qL0 wYQMjBaNh/o20NzYkxOYxtOo6cABhe6sgTKWdW6bvwg5L5oP2tyho8PoUCgxumKdv1hx 9gQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=W0LouJHxhJ8X0NqqqQzaJDVH6qHFyXTB5zG8KPXgID4=; b=jEb+vlICh0NVSeI4D/blH7Zpu4NmXivfdqi7a2rfyliulNkKQsr7/eeJQTQUUsR6n5 ClBkJkHw14qn9pPFJJ6Zj9bwz0TISCDHHtdnejcKx5ybNhovYt/OpNh8mzMVA6IAq7u+ wZDnEgo6/KpX0Hsij8otuZJqQ3a95cBVxsWKdQDiHnbU7brQT1Sp4T0DSShlEQ94FYIY pnkOtb95F2b1/8nl9vrX1XD+Hq8QmQwxW128p2p6wRqLdyBGSeikvv2aceKw6J3f4lYt +oVpw7vbIvce5hQ51P1myc4TtumhXy9jSaqDxtOPiqB9AAgFLSLlo7slwSmPrxLyu0M3 U91A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@flygoat.com header.s=mail header.b=K4EqHH7F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=flygoat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p22si6250428ota.43.2020.01.13.02.14.11; Mon, 13 Jan 2020 02:14:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@flygoat.com header.s=mail header.b=K4EqHH7F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=flygoat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726934AbgAMKNR (ORCPT + 99 others); Mon, 13 Jan 2020 05:13:17 -0500 Received: from forward103j.mail.yandex.net ([5.45.198.246]:42177 "EHLO forward103j.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbgAMKNR (ORCPT ); Mon, 13 Jan 2020 05:13:17 -0500 Received: from forward102q.mail.yandex.net (forward102q.mail.yandex.net [IPv6:2a02:6b8:c0e:1ba:0:640:516:4e7d]) by forward103j.mail.yandex.net (Yandex) with ESMTP id D3D456741291; Mon, 13 Jan 2020 13:13:13 +0300 (MSK) Received: from mxback3q.mail.yandex.net (mxback3q.mail.yandex.net [IPv6:2a02:6b8:c0e:39:0:640:4545:437c]) by forward102q.mail.yandex.net (Yandex) with ESMTP id CF6D97F2001F; Mon, 13 Jan 2020 13:13:13 +0300 (MSK) Received: from vla3-4c649d03f525.qloud-c.yandex.net (vla3-4c649d03f525.qloud-c.yandex.net [2a02:6b8:c15:2584:0:640:4c64:9d03]) by mxback3q.mail.yandex.net (mxback/Yandex) with ESMTP id MlyymQRMBT-DDkChGdu; Mon, 13 Jan 2020 13:13:13 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; s=mail; t=1578910393; bh=W0LouJHxhJ8X0NqqqQzaJDVH6qHFyXTB5zG8KPXgID4=; h=Subject:To:From:Cc:Date:Message-Id; b=K4EqHH7FRdthdu1mQFTuNH0tqlMArF4/YrXBetuY56mT5APBCkP3cufdKPCDNUDE5 ttURaS/F0BmJC1ZKF40w5QlJVfDL18FRuLLHHiWDepTdga0CSp/77C0mf8licrE8vy OUSrbrYe1g62TO0yyBxjRBaVrR7ataPr7/wPHeSw= Authentication-Results: mxback3q.mail.yandex.net; dkim=pass header.i=@flygoat.com Received: by vla3-4c649d03f525.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id ATtQsIjGG0-D4VCMcx1; Mon, 13 Jan 2020 13:13:11 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) From: Jiaxun Yang To: linux-mips@vger.kernel.org Cc: chenhc@lemote.com, paul.burton@mips.com, tglx@linutronix.de, jason@lakedaemon.net, maz@kernel.org, linux-kernel@vger.kernel.org, Jiaxun Yang Subject: [PATCH] irqchip: mips-cpu: Remove eoi operation Date: Mon, 13 Jan 2020 18:12:51 +0800 Message-Id: <20200113101251.37471-1-jiaxun.yang@flygoat.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The eoi opreation in mips_cpu_irq_controller caused chained_irq_enter falsely consider CPU IP interrupt as a FastEOI type IRQ. So the interrupt won't be masked during in handler. Which might lead to spurious interrupt. Thus we simply remove eoi operation for mips_cpu_irq_controller, Signed-off-by: Jiaxun Yang --- drivers/irqchip/irq-mips-cpu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/irqchip/irq-mips-cpu.c b/drivers/irqchip/irq-mips-cpu.c index 95d4fd8f7a96..0ad7f1f9a58b 100644 --- a/drivers/irqchip/irq-mips-cpu.c +++ b/drivers/irqchip/irq-mips-cpu.c @@ -55,7 +55,6 @@ static struct irq_chip mips_cpu_irq_controller = { .irq_mask = mask_mips_irq, .irq_mask_ack = mask_mips_irq, .irq_unmask = unmask_mips_irq, - .irq_eoi = unmask_mips_irq, .irq_disable = mask_mips_irq, .irq_enable = unmask_mips_irq, }; -- 2.24.1