Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 13 Jan 2020 14:18:17 +0000
From:   Russell King - ARM Linux admin <linux@armlinux.org.uk>
To:     Jose Abreu <Jose.Abreu@synopsys.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Joao Pinto <Joao.Pinto@synopsys.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC net-next] net: phy: Add basic support for Synopsys XPCS
 using a PHY driver
Message-ID: <20200113141817.GN25745@shell.armlinux.org.uk>
References: <4953fc69a26bee930bccdeb612f1ce740a4294df.1578921062.git.Jose.Abreu@synopsys.com>
 <20200113133845.GD11788@lunn.ch>
 <BN8PR12MB32666F34D45D7881BDD4CAB3D3350@BN8PR12MB3266.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BN8PR12MB32666F34D45D7881BDD4CAB3D3350@BN8PR12MB3266.namprd12.prod.outlook.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jan 13, 2020 at 01:54:28PM +0000, Jose Abreu wrote:
> From: Andrew Lunn <andrew@lunn.ch>
> Date: Jan/13/2020, 13:38:45 (UTC+00:00)
> 
> > On Mon, Jan 13, 2020 at 02:11:08PM +0100, Jose Abreu wrote:
> > > Adds the basic support for XPCS including support for USXGMII.
> > 
> > Hi Jose
> > 
> > Please could you describe the 'big picture'. What comes after the
> > XPCS? An SFP? A copper PHY? How in Linux do you combine this PHY and
> > whatever comes next using PHYLINK?
> > 
> > Or do only support backplane with this, and the next thing in the line
> > is the peers XPCS?
> 
> My current setup is this:
> 
> Host PC x86 -> PCI -> XGMAC -> XPCS -> SERDES 10G-BASE-R -> QSFP+
> 
> The only piece that needs configuration besides XGMAC is the XPCS hereby 
> I "called" it a PHY ... Anyway, this is an RFC because I'm not entirely 
> sure about the approach. Hmm ?

I don't seem to have been copied on the original mail, so I'm jumping
in blind here.

In phylink, the mac_pcs_get_state() method is supposed to read from
the PCS - in your case, the XPCS.  This wasn't obvious when phylink
was first submitted, especially as mvneta and mvpp2 don't offer
802.3 MDIO compliant PCS interfaces.  Hence the recent change in
naming of that method.

I've recently suggested a patch to phylink to add a generic helper to
read the state from a generic 802.3 clause 37 PCS, but I guess that
won't be sufficient for an XPCS.  However, it should give some clues
if you're intending to use phylink.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up