Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jose Abreu <Jose.Abreu@synopsys.com>
To:     Russell King - ARM Linux admin <linux@armlinux.org.uk>
CC:     Andrew Lunn <andrew@lunn.ch>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Joao Pinto <Joao.Pinto@synopsys.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC net-next] net: phy: Add basic support for Synopsys XPCS
 using a PHY driver
Thread-Topic: [RFC net-next] net: phy: Add basic support for Synopsys XPCS
 using a PHY driver
Thread-Index: AQHVyhMHPh1TkUf6pU+JUVzLFdFzk6fomWeAgAAAjSCAAAp/gIAAAN2w
Date:   Mon, 13 Jan 2020 14:27:56 +0000
Message-ID: <BN8PR12MB326690820A7619664F7CC257D3350@BN8PR12MB3266.namprd12.prod.outlook.com>
References: <4953fc69a26bee930bccdeb612f1ce740a4294df.1578921062.git.Jose.Abreu@synopsys.com>
 <20200113133845.GD11788@lunn.ch>
 <BN8PR12MB32666F34D45D7881BDD4CAB3D3350@BN8PR12MB3266.namprd12.prod.outlook.com>
 <20200113141817.GN25745@shell.armlinux.org.uk>
In-Reply-To: <20200113141817.GN25745@shell.armlinux.org.uk>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: synopsys.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e261460-03e6-476a-80a0-08d79834c8ab
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2020 14:27:56.7119
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9VJMr1urxeoWMWjxcjI9pJJHAOpFncGI/Dp95nev9bTl1Hn/iHVAPp0hHHhkBEnd7otEQ8mpDsVqhLqMG8D64A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB2978
X-OriginatorOrg: synopsys.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: Jan/13/2020, 14:18:17 (UTC+00:00)

> On Mon, Jan 13, 2020 at 01:54:28PM +0000, Jose Abreu wrote:
> > From: Andrew Lunn <andrew@lunn.ch>
> > Date: Jan/13/2020, 13:38:45 (UTC+00:00)
> >=20
> > > On Mon, Jan 13, 2020 at 02:11:08PM +0100, Jose Abreu wrote:
> > > > Adds the basic support for XPCS including support for USXGMII.
> > >=20
> > > Hi Jose
> > >=20
> > > Please could you describe the 'big picture'. What comes after the
> > > XPCS? An SFP? A copper PHY? How in Linux do you combine this PHY and
> > > whatever comes next using PHYLINK?
> > >=20
> > > Or do only support backplane with this, and the next thing in the lin=
e
> > > is the peers XPCS?
> >=20
> > My current setup is this:
> >=20
> > Host PC x86 -> PCI -> XGMAC -> XPCS -> SERDES 10G-BASE-R -> QSFP+
> >=20
> > The only piece that needs configuration besides XGMAC is the XPCS hereb=
y=20
> > I "called" it a PHY ... Anyway, this is an RFC because I'm not entirely=
=20
> > sure about the approach. Hmm ?
>=20
> I don't seem to have been copied on the original mail, so I'm jumping
> in blind here.

Thanks for the comments. I'll add you in next versions, you can find=20
original posting at:
- https://patchwork.ozlabs.org/patch/1222133/

> In phylink, the=20
mac_pcs_get_state() method is supposed to read from
> the PCS - in your case, the XPCS.  This wasn't obvious when phylink
> was first submitted, especially as mvneta and mvpp2 don't offer
> 802.3 MDIO compliant PCS interfaces.  Hence the recent change in
> naming of that method.

Yes I saw that. The thing is that this is a different and stand-alone=20
IP. Maybe I can add it into some sort of module library in PHY folder ?

> I've recently suggested a patch to phylink to add a generic helper to
> read the state from a generic 802.3 clause 37 PCS, but I guess that
> won't be sufficient for an XPCS.  However, it should give some clues
> if you're intending to use phylink.

This uses Clause 73 for Autoneg. I can add that into PHYLINK core if you=20
agree.
=20
---
Thanks,
Jose Miguel Abreu